Update search engine defaults for CA / DE / FR / GB / US #18331

bsclifton · 2021-09-24T06:50:04Z

Test plan

Region set to CA / DE / FR / GB / US

Fresh profile
Search onboarding should NOT be shown
Default search engine SHOULD be Brave
Visit brave://settings/searchEngines
Brave SHOULD be first in the Default search engines list

Region set to anything else

Fresh profile
Search onboarding SHOULD be shown
Default will NOT be Brave Search
Brave Search should NOT be in the Onboarding list
Visit brave://settings/searchEngines
Brave SHOULD be first in the Default search engines list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second

Description

Update search engine defaults for:

Canada (CA)
Germany (DE)
France (FR)
Great Britain (GB)
United States (US)

Brave should be at the top of drop down list at brave://settings/search

Please see details here: https://github.com/brave/internal/issues/816

The text was updated successfully, but these errors were encountered:

iccub · 2021-09-24T09:56:05Z

iOS ticket tracked here
brave/brave-ios#4221

Fixes brave/brave-browser#18331

kjozwiak · 2021-10-13T05:27:13Z

Adding QA/Blocked as the above will require a 1.31.x RC which I'm hoping to kick off tonight 👍 We'll need 1.31.84 or higher.

LaurenWags · 2021-10-13T12:12:10Z

Removing QA/Blocked since 1.31.84 is available - https://github.com/brave/brave-browser/releases/tag/v1.31.84

LaurenWags · 2021-10-13T17:35:58Z

Verified passed with

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | macOS Version 10.15.7 (Build 19H1417)

Verified brave/brave-core#10326 (comment) for US and GB regions.

US region - Clean Install - PASSED

ensured that the search section under brave://welcome was removed
ensured that Brave is the default SE on a clean profile
ensured that Brave appears as the default SE under brave://settings/search

Example	Example

US region - Upgrade (Default SE not changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and ensured that the default SE is set as Google
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Google was still the default SE after upgrading

Example	Example

US region - Upgrade (Default SE changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and set the SE to be Ecosia from brave://welcome
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Ecosia was still the SE after upgrading

Example	Example

GB region - Clean Install - PASSED

ensured that the search section under brave://welcome was removed
ensured that Brave is the default SE on a clean profile
ensured that Brave appears as the default SE under brave://settings/search

Example	Example

GB region - Upgrade (Default SE not changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and ensured that the default SE is set as Google
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Google was still the default SE after upgrading

Example	Example

GB region - Upgrade (Default SE changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and set the SE to be Bing from brave://welcome
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Bing was still the SE after upgrading

Example	Example

Confirmed for Spain and Russia regions that SE is not set to Brave on clean install:

Spain region - Clean Install - PASSED

ensured that the search section under brave://welcome was not removed
ensured that Brave is not the default SE on a clean profile
Saw that Brave appears as an option on brave://welcome and brave://settings/search (this is ok per Brave appears under on-boarding via brave://welcome for locales other than CA / DE / FR / GB / US #18720 (comment))

Example	Example	Example

Russia region - Clean Install - PASSED

ensured that the search section under brave://welcome was not removed
ensured that Brave is not the default SE on a clean profile, Yandex is
Saw that Brave appears as an option on brave://welcome and brave://settings/search (this is ok per Brave appears under on-boarding via brave://welcome for locales other than CA / DE / FR / GB / US #18720 (comment))
confirmed that Brave is not first in the list, Yandex is

Example	Example	Example

Verified `IN-PROGRESS` with

Brave	1.31.84 Chromium: 95.0.4638.40 (Oficjalna wersja) (64-bitowa)
Wersja	e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
System operacyjny	Linux

Verified brave/brave-core#10326 (comment) for DE and FR regions.

DE region - Clean Install - PASSED

ensured that the search section under brave://welcome was removed
ensured that Brave is the default SE on a clean profile
ensured that Brave appears as the default SE under brave://settings/search

Example	Example

DE region - Upgrade (Default SE not changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and ensured that the default SE is set as Google
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Google was still the default SE after upgrading

Example	Example

DE region - Upgrade (Default SE changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and set the SE to be Startpage from brave://welcome
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Startpage was still the SE after upgrading

Example	Example

FR region - Clean Install - PASSED

ensured that the search section under brave://welcome was removed
ensured that Brave is the default SE on a clean profile
ensured that Brave appears as the default SE under brave://settings/search

Example	Example

FR region - Upgrade (Default SE not changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and ensured that the default SE is set as Qwant
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Qwant was still the default SE after upgrading

Example	Example

FR region - Upgrade (Default SE changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and set the SE to be Bing from brave://welcome
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Bing was still the SE after upgrading

Example	Example

Confirmed for Spain and Russia regions that SE is not set to Brave on clean install:

Spain region - Clean Install - PASSED

ensured that the search section under brave://welcome was not removed
ensured that Brave is not the default SE on a clean profile
Saw that Brave appears as an option on brave://welcome and brave://settings/search (this is OK per Brave appears under on-boarding via brave://welcome for locales other than CA / DE / FR / GB / US #18720 (comment))

Example	Example	Example

Russia region - Clean Install - PASSED

ensured that the search section under brave://welcome was not removed
ensured that Brave is not the default SE on a clean profile, Yandex is
Saw that Brave appears as an option on brave://welcome and brave://settings/search (this is ok per Brave appears under on-boarding via brave://welcome for locales other than CA / DE / FR / GB / US #18720 (comment))
confirmed that Brave is not first in the list, Yandex is

Example	Example	Example

Verification passed on

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 10 Version 21H1 (Build 19043.1266)

Verified brave/brave-core#10326 (comment) for CA region

CA region - Clean Install - PASSED

ensured that the search section under brave://welcome was removed
ensured that Brave is the default SE on a clean profile
ensured that Brave appears as the default SE under brave://settings/search

Example	Example

CA region - Upgrade (Default SE not changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and ensured that the default SE is set as Google
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Google was still the default SE after upgrading

Example	Example

CA region - Upgrade (Default SE changed) - PASSED

Installed 1.30.89 Chromium: 94.0.4606.81 and set the SE to be Startpage from brave://welcome
Upgraded to 1.31.84 Chromium: 95.0.4638.40 and ensured that Startpage was still the SE after upgrading

Example	Example

Confirmed for India region the SE is not set to Brave on clean install:

India region - Clean Install - PASSED

ensured that the search section under brave://welcome was not removed
ensured that Brave is not the default SE on a clean profile
Saw that Brave appears as an option on brave://welcome and brave://settings/search

Example	Example	Example

kjozwiak · 2021-10-13T20:00:57Z

@brave/legacy_qa as discussed with @bsclifton, the full verifications were done on Nightly on Win via brave/brave-core#10326 (comment) before uplifting the Brave Search work into 1.31.x. So in interest of time, we can just run through ~two of the locales when running through verifications rather than checking all five of the locales (CA / DE / FR / GB / US).

srirambv · 2021-10-18T08:48:32Z

Verification passed on Samsung Tab A with Android 10 running 1.31.86 x64 build

Verified steps from Update default search for 5 regions brave-core#10326 (comment)

Region: US
Install Type: Clean Install

Verified on clean install search engine onboarding is not shown for US
Verified default search engine is set to Brave
Verified Brave is listed on top of all search engines
Encountered Make ordering of the default search engine list consistent across all products #18609

Clean Install screenshots

Normal Tab SE	Private Tab SE

Install type: Upgrade

Verified upgrading from previous version retains the search engine selected
Verified before upgrade Brave is listed second on the list. Post upgrade, Brave is listed on top of the list

Upgrade screenshots

Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)	Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)

Region: France (FR)
Install Type: Clean Install

Verified on clean install search engine onboarding is not shown for France
Verified default search engine is set to Brave
Verified Brave is listed on top of all search engines
Encountered Make ordering of the default search engine list consistent across all products #18609

Upgrade screenshots

Normal Tab SE	Private Tab SE

Install type: Upgrade

Verified upgrading from previous version retains the search engine selected
Verified before upgrade Brave is listed second on the list. Post upgrade, Brave is listed on top of the list

Upgrade screenshots

Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)	Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)

Regions: India
Install Type: Clean Install

Verified onboarding is shown on clean install
Verified Brave is not listed as an option in the onboarding screen
Verified Brave is listed as the first option for both normal and private tab search engine settings

Verification passed on Oppo Reno 5 with Android 11 running 1.31.86 x64 build

Verified steps from Update default search for 5 regions brave-core#10326 (comment)

Region: UK
Install Type: Clean Install

Verified on clean install search engine onboarding is not shown for UK
Verified default search engine is set to Brave
Verified Brave is listed on top of all search engines
Encountered Make ordering of the default search engine list consistent across all products #18609

Clean Install screenshots

Normal Tab SE	Private Tab SE

Install type: Upgrade

Verified upgrading from previous version retains the search engine selected
Verified before upgrade Brave is listed second on the list. Post upgrade, Brave is listed on top of the list

Upgrade screenshots

Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)	Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)

Region: Germany (DE)
Install Type: Clean Install

Verified on clean install search engine onboarding is not shown for Germany
Verified default search engine is set to Brave
Verified Brave is listed on top of all search engines
Encountered Make ordering of the default search engine list consistent across all products #18609

Upgrade screenshots

Normal Tab SE	Private Tab SE

Install type: Upgrade

Verified upgrading from previous version retains the search engine selected
Verified before upgrade Brave is listed second on the list. Post upgrade, Brave is listed on top of the list

Upgrade screenshots

Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)	Normal Tab SE (before upgrade)	Normal Tab SE (post upgrade)

Regions: India
Install Type: Clean Install

Verified onboarding is shown on clean install
Verified Brave is not listed as an option in the onboarding screen
Verified Brave is listed as the first option for both normal and private tab search engine settings

bertrandfalguiere · 2021-10-23T15:29:19Z

Brave should be at the top of drop down list at brave://settings/search

Please see details here: https://github.com/brave/internal/issues/816

What is the rationale for this? The provided link for details doesn't work

bsclifton added OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 24, 2021

bsclifton self-assigned this Sep 24, 2021

iccub mentioned this issue Sep 24, 2021

Update search engine defaults for CA / DE / FR / GB / US brave/brave-ios#4221

Closed

bsclifton added a commit to brave/brave-core that referenced this issue Sep 28, 2021

Update default search engines for CA/DE/FR/GB/US

a87d99a

Fixes brave/brave-browser#18331

rebron mentioned this issue Sep 28, 2021

remove Set default search engine screen for CA / DE / FR / GB / US #18415

Closed

rebron added QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. labels Sep 28, 2021

This was referenced Sep 29, 2021

Remove Search Engine screen from onboarding for CA / DE / FR / GB / US #18452

Closed

Update default search for 5 regions brave/brave-core#10326

Merged

bsclifton added a commit to brave/brave-core that referenced this issue Sep 30, 2021

Update default search engines for CA/DE/FR/GB/US

f55f43c

Fixes brave/brave-browser#18331

bsclifton mentioned this issue Sep 30, 2021

Search updates #18473

Closed

bsclifton closed this as completed in brave/brave-core#10326 Oct 5, 2021

bsclifton added this to the 1.32.x - Nightly milestone Oct 5, 2021

brave-builds mentioned this issue Oct 5, 2021

Update default search for 5 regions (uplift to 1.31.x) brave/brave-core#10374

Merged

7 tasks

bsclifton added the release-notes/include label Oct 6, 2021

bsclifton mentioned this issue Oct 11, 2021

Update search order for Brave Search brave/brave-core#10450

Merged

24 tasks

kjozwiak mentioned this issue Oct 12, 2021

Brave appears under on-boarding via brave://welcome for locales other than CA / DE / FR / GB / US #18720

Closed

kjozwiak modified the milestones: 1.32.x - Beta, 1.31.x - Release Oct 13, 2021

kjozwiak added the QA/Blocked label Oct 13, 2021

LaurenWags removed the QA/Blocked label Oct 13, 2021

LaurenWags added the QA/Test-All-Platforms label Oct 13, 2021

LaurenWags added the QA Pass-macOS label Oct 13, 2021

stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 13, 2021

GeetaSarvadnya added the QA Pass-Win64 label Oct 14, 2021

srirambv added QA Pass - Android ARM QA Pass - Android Tab labels Oct 18, 2021

kjozwiak mentioned this issue Oct 19, 2021

Release notes for 1.31.x - Release #18861

Closed

kjozwiak mentioned this issue Nov 2, 2021

Release notes for 1.31.x #19158

Closed

rebron mentioned this issue Jul 1, 2022

Update search engine defaults for AT / ES / MX #23814

Closed

rebron mentioned this issue Oct 21, 2022

Update search engine defaults for BR / AR #26181

Closed

timchilds mentioned this issue Oct 27, 2022

[Android] Update search engine defaults for BR / AR #26318

Closed

rebron mentioned this issue Jan 9, 2023

Update search engine default for IN #27709

Closed

rebron mentioned this issue Apr 5, 2023

Update Search suggestions settings text and default it on for Brave Search for new users #29517

Closed

5 tasks

rebron mentioned this issue May 2, 2024

Update search engine default for Italy (IT) #38028

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update search engine defaults for CA / DE / FR / GB / US #18331

Update search engine defaults for CA / DE / FR / GB / US #18331

bsclifton commented Sep 24, 2021 •

edited

Loading

iccub commented Sep 24, 2021 •

edited

Loading

kjozwiak commented Oct 13, 2021 •

edited

Loading

LaurenWags commented Oct 13, 2021

LaurenWags commented Oct 13, 2021 •

edited by GeetaSarvadnya

Loading

kjozwiak commented Oct 13, 2021

srirambv commented Oct 18, 2021 •

edited

Loading

bertrandfalguiere commented Oct 23, 2021

Update search engine defaults for CA / DE / FR / GB / US #18331

Update search engine defaults for CA / DE / FR / GB / US #18331

Comments

bsclifton commented Sep 24, 2021 • edited Loading

Test plan

Region set to CA / DE / FR / GB / US

Region set to anything else

Description

iccub commented Sep 24, 2021 • edited Loading

kjozwiak commented Oct 13, 2021 • edited Loading

LaurenWags commented Oct 13, 2021

LaurenWags commented Oct 13, 2021 • edited by GeetaSarvadnya Loading

Verified IN-PROGRESS with

kjozwiak commented Oct 13, 2021

srirambv commented Oct 18, 2021 • edited Loading

bertrandfalguiere commented Oct 23, 2021

bsclifton commented Sep 24, 2021 •

edited

Loading

iccub commented Sep 24, 2021 •

edited

Loading

kjozwiak commented Oct 13, 2021 •

edited

Loading

LaurenWags commented Oct 13, 2021 •

edited by GeetaSarvadnya

Loading

Verified `IN-PROGRESS` with

srirambv commented Oct 18, 2021 •

edited

Loading