Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search engine defaults for AT / ES / MX #23814

Closed
rebron opened this issue Jul 1, 2022 · 7 comments · Fixed by brave/brave-core#14177
Closed

Update search engine defaults for AT / ES / MX #23814

rebron opened this issue Jul 1, 2022 · 7 comments · Fixed by brave/brave-core#14177

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 1, 2022

Description

Update search engine defaults for:

  • Austria (AT)
  • Spain (ES)
  • Mexico (MX)

Brave should be at the top of drop down list at brave://settings/search

Related: #18331

Test plan

Region set to AT / ES / MX

  1. Fresh profile
  2. Search onboarding should NOT be shown
  3. Default search engine SHOULD be Brave
  4. Visit brave://settings/searchEngines
  5. Brave SHOULD be first in the Default search engines list

Region set to anything else (excluding CA / DE / FR / GB / US)

  1. Fresh profile
  2. Search onboarding SHOULD be shown
  3. Default will NOT be Brave Search
  4. Visit brave://settings/searchEngines
  5. Brave SHOULD be first in the Default search engines list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.
@rebron rebron added OS/Desktop OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/include labels Jul 1, 2022
@rebron rebron changed the title Update search engine defaults for AT / ES / IE / MT Update search engine defaults for AT / ES / MX / IE / MT Jul 6, 2022
@rebron rebron changed the title Update search engine defaults for AT / ES / MX / IE / MT Update search engine defaults for AT / ES / MX / MT Jul 7, 2022
@rebron rebron changed the title Update search engine defaults for AT / ES / MX / MT Update search engine defaults for AT / ES / MX Jul 7, 2022
@bsclifton bsclifton assigned spylogsster and unassigned bsclifton Jul 14, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 19, 2022
@kjozwiak
Copy link
Member

The above will require 1.42.80 or higher for 1.42.x verification 👍

@kjozwiak
Copy link
Member

@brave/qa-team as discussed with @rebron, we don't need to run through each locale like I did via brave/brave-core#14177 (comment) on Nightly before uplifted. On each platform, we can check the following:

  • single check on either AT, ES or MX
  • single check on either CA, DE, FR, GB or US
  • single check of a locale that isn't listed above to ensure that Brave Search isn't default and the search screen is still visible via brave://welcome during onboarding.

Please coordinate so we're not doing the same locales twice when verifying via 1.42.x.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 27, 2022

Verification PASSED on

Brave | 1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit)
-- | --
Revision | 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS | Windows 10 Version 21H2 (Build 19044.1826)

AT (Austria) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
image image image

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Google/Google)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Google was the default SE selected under brave://settings/searchEngines
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Google is still the default SE in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Startpage/DDG)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Google is the default SE for both Normal and Private windows
  • Change the SE to Startpage in Normal windows SE dropdown
  • Change the SE to DDG in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that Startpage was the default SE selected under brave://settings/searchEngines for Normal windows
  • Ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Ecosia/Qwant)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Ecosia was the default SE selected under brave://settings/searchEngines
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Google is the default SE for both Normal and Private windows
  • Change the SE to Ecosia in Normal windows SE dropdown
  • Change the SE to Qwant in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that Ecosia was the default SE selected under brave://settings/searchEngines for Normal windows
  • Ensured that Qwant was the default SE selected under brave://settings/searchEngines for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example (Brave at top of list) Example (Brave at top of list)
image image

As per #23908, ensured that locales from CA / DE / FR / GB / US are not displaying the Set default search engine screen via brave://welcome (onboarding).

US (United states) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
image image image

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Brave/Brave)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Brave was the default SE selected under brave://settings/searchEngines
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Brave is still the default SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (DDG/Startpage)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows and
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Brave is the default SE in both Normal and Private window SE
  • Change the SE to DDG in Normal windows SE dropdown
  • Change the SE to Startpage in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • Ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

Checking to ensure that locales that don't have Brave Search as the default and still have the Set default search engine screen screen via brave://welcome (onboarding) are working as expected.

IN (India) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example Example
image image image image

Case #2 - #23814

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Google/Google)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Google was the default SE selected under brave://settings/searchEngines
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Google is still the default SE in both Normal and Private window SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Qwant/Bing)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Google is the default SE in both Normal and Private window SE
  • Change the SE to Qwant in Normal windows SE dropdown
  • Change the SE to Bing in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • Ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
image image
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example (Brave at top of list) Example (Brave at top of list)
image image

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 27, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jul 27, 2022

Verified with

Brave | 1.42.80 Chromium: 104.0.5112.57 (Official Build) (x86_64)
-- | --
Revision | 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS | macOS Version 12.5 (Build 21G72)

ES (Spain) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
Captura de Pantalla 2022-07-27 a las 14 04 00 Captura de Pantalla 2022-07-27 a las 14 04 11 Captura de Pantalla 2022-07-27 a las 14 04 22

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example
1 2 3 4
Updated Profile (Google/Google)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Google was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Google is still the default SE in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4
Updated Profile (Startpage/DDG)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Startpage was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Google is the default SE for both Normal and Private windows
  • Change the SE to Startpage in Normal windows SE dropdown
  • Change the SE to DDG in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that Startpage was the default SE selected under brave://settings/search for Normal windows
  • Ensured that DDG was the default SE selected under brave://settings/search for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
Example (Brave at top of list) Example (Brave at top of list)
3 4
Updated Profile (Ecosia/Qwant)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Ecosia was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Google is the default SE for both Normal and Private windows
  • Change the SE to Ecosia in Normal windows SE dropdown
  • Change the SE to Qwant in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that Ecosia was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Qwant was the default SE selected under brave://settings/search for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
Example (Brave at top of list) Example (Brave at top of list)
3 4

As per #23908, ensured that locales from CA / DE / FR / GB / US are not displaying the Set default search engine screen via brave://welcome (onboarding).

FR (France) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
Capture d’écran 2022-07-27 à 15 36 46 Capture d’écran 2022-07-27 à 15 36 57 Capture d’écran 2022-07-27 à 15 37 08

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example
1 2 3 4
Updated Profile (Brave/Brave)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Brave was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Brave is still the default SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4
Updated Profile (DDG/Startpage)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows and
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Brave is the default SE in both Normal and Private window SE
  • Change the SE to DDG in Normal windows SE dropdown
  • Change the SE to Startpage in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that DDG was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Startpage was the default SE selected under brave://settings/search for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4

Checking to ensure that locales that don't have Brave Search as the default and still have the Set default search engine screen screen via brave://welcome (onboarding) are working as expected.

FI (Finland) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was not removed from brave://welcome as per the following:

Example Example Example Example
Näyttökuva 2022-7-27 kello 16 02 34 Näyttökuva 2022-7-27 kello 16 02 54 Näyttökuva 2022-7-27 kello 16 03 02 Näyttökuva 2022-7-27 kello 16 03 13

Case #2 - #23814

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Google was selected as the default via brave://settings/searchEngines
Example Example Example Example
Näyttökuva 2022-7-27 kello 16 17 16 Näyttökuva 2022-7-27 kello 16 17 31 Näyttökuva 2022-7-27 kello 16 17 40 Näyttökuva 2022-7-27 kello 16 17 51
Updated Profile (Google/Google)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Google was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Google is still the default SE in both Normal and Private window SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4
Updated Profile (Qwant/Bing)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Qwant was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Brave at top of list) Example (Brave at top of list)
3 4
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Google is the default SE in both Normal and Private window SE
  • Change the SE to Qwant in Normal windows SE dropdown
  • Change the SE to Bing in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that Qwant was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Bing was the default SE selected under brave://settings/search for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
Example (Brave at top of list) Example (Brave at top of list)
3 4

Checking to ensure that locales that have Yandex as the default and still have the Set default search engine screen screen via brave://welcome (onboarding) are working as expected.

RU (Russia) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was not removed from brave://welcome as per the following:

Example Example Example Example
Снимок экрана 2022-07-27 в 16 55 57 Снимок экрана 2022-07-27 в 16 56 05 Снимок экрана 2022-07-27 в 16 56 15 Снимок экрана 2022-07-27 в 16 56 28

Case #2 - #23814

Clean Profile
  • ensured that Yandex was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Private windows
  • ensured that Yandex was selected as the default via brave://settings/searchEngines
Example Example Example Example
Снимок экрана 2022-07-27 в 16 58 30 Снимок экрана 2022-07-27 в 16 58 36 Снимок экрана 2022-07-27 в 16 58 43 Снимок экрана 2022-07-27 в 16 58 52
Updated Profile (Yandex/Yandex)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Yandex was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Yandex is still the default SE in both Normal and Private window SE
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Yandex at top of list) Example (Yandex at top of list)
3 4
Updated Profile (DDG/Qwant)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that DDG was the default SE selected under brave://settings/search
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Private windows
1.41.100 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
Example (Yandex at top of list) Example (Yandex at top of list)
3 4
  • Install beta version 1.42.78 Chromium: 103.0.5060.134
  • Open brave://settings/search and ensure that Yandex is the default SE in both Normal and Private window SE
  • Change the SE to DDG in Normal windows SE dropdown
  • Change the SE to Qwant in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.42.80 Chromium: 104.0.5112.57
  • Ensured that DDG was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Qwant was the default SE selected under brave://settings/search for Private windows
1.42.78 Chromium: 103.0.5060.134 1.42.80 Chromium: 104.0.5112.57
1 2
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Private windows
Example (Yandex at top of list) Example (Yandex at top of list)
3 4

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 27, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 28, 2022

Verification PASSED on Samsung Galaxy S21 using

Brave	1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit) 
Revision	212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS	Android 12; Build/SP1A.210812.016

MX (Mexico) locale

Case #1 - #23908

Onboarding Flow

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from onboarding modals.

23814_MX2.mp4

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Google/Google)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Google was the default SE selected
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Google is still the default SE in both Normal and Private windows
  • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Startpage/DDG)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Startpage was the default SE selected for normal windows and 'DuckDuckGo' for Private windows.
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were selected as the default.
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Bing/Qwant)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Bing was the default SE selected for normal windows and Qwant for private
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default
  • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows

As per #23908, ensured that locales from CA / DE / FR / GB / US are not displaying the Set default search engine screen via brave://welcome (onboarding).

GB (United Kingdom) locale

Case #1 - #23908

Onboarding Flow

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from onboarding.

23814_GB1.mp4

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Brave/Brave)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Brave was the default SE selected
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Brave is still the default SE
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (DDG/Startpage)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that DDG was the default SE selected for Normal windows and Startpage for private windows.
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows

Checking to ensure that locales that don't have Brave Search as the default and still have the Set default search engine screen screen via brave://welcome (onboarding) are working as expected.

BR (Brazil) locale

Case #1 - #23908

Onboarding Flow

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was not removed from onboarding.

23814_Brazil1.mp4

Case #2 - #23814

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Google/Google)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Google was the default SE selected
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Google is still the default SE in both Normal and Private window SE
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Qwant/Bing)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Qwant was the default SE selected under
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 28, 2022

Verification PASSED on Samsung Galaxy Tab S7 using

Brave	1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit) 
Revision	212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS	Android 12; Build/SP1A.210812.016

AT (Austria) locale

Case #1 - #23908

Onboarding Flow

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from onboarding modals.

23814_Austria_Tab.mp4

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Google/Google)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Google was the default SE selected
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Google is still the default SE in both Normal and Private windows
  • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Startpage/DDG)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Startpage was the default SE selected for normal windows and 'DuckDuckGo' for Private windows.
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were selected as the default.
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Bing/Qwant)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Bing was the default SE selected for normal windows and Qwant for private
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default
  • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows

As per #23908, ensured that locales from CA / DE / FR / GB / US are not displaying the Set default search engine screen via brave://welcome (onboarding).

DE (Germany) locale

Case #1 - #23908

Onboarding Flow

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from onboarding.

23814_Germany_Tab.mp4

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (Brave/Brave)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Brave was the default SE selected
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Brave is still the default SE
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows
Updated Profile (DDG/Startpage)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that DDG was the default SE selected for Normal windows and Startpage for private windows.
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list for Normal windows
  • ensured that Brave was the first engine via the drop down list for Private windows

Checking to ensure that locales that don't have Brave Search as the default and still have the Set default search engine screen screen via brave://welcome (onboarding) are working as expected.

RU (Vladivostok, Russia) locale

Case #1 - #23908

Onboarding Flow

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was not removed from onboarding.

23814_Russia_Vladivostok_Tab.mp4

Case #2 - #23814

Clean Profile
  • ensured that Yandex was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the second engine via the drop down list for Normal windows
  • ensured that Brave was the second engine via the drop down list for Private windows
Updated Profile (Yandex/Yandex)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Yandex was the default SE selected
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that Yandex is still the default SE in both Normal and Private window SE
  • ensured that Brave was the second engine via the drop down list for Normal windows
  • ensured that Brave was the second engine via the drop down list for Private windows
Updated Profile (Qwant/Bing)
  • installed 1.41.100 Chromium: 103.0.5060.134
  • ensured that Qwant was the default SE selected
  • updated to 1.42.80 Chromium: 104.0.5112.57 and ensured that both SE engines were still selected as the default in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the second engine via the drop down list for Normal windows
  • ensured that Brave was the second engine via the drop down list for Private windows

@btlechowski
Copy link

Verification passed on

Brave 1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Ubuntu 18.04 LTS

ES (Spain) locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

image
image
image

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines

image
image
image
image

Updated Profile (Google/Google)
  • installed 1.41.x
  • ensured that Google was the default SE selected under brave://settings/search
  • updated to 1.42.x and ensured that Google is still the default SE in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

1.41.x
image
image

1.42.x
image
image
image

Updated Profile (Startpage/DDG)
  • installed 1.41.x
  • ensured that Startpage was the default SE selected under brave://settings/search
  • updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

image
image
image
image

Updated Profile (Ecosia/Qwant)
  • installed 1.41.x
  • ensured that Ecosia was the default SE selected under brave://settings/search
  • updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

image
image
image


As per #23908, ensured that locales from CA / DE / FR / GB / US are not displaying the Set default search engine screen via brave://welcome (onboarding).

de locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

image
image
image

Case #2 - #23814

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines

image
image
image

Updated Profile (Brave/Brave)
  • installed 1.41.x
  • ensured that Brave was the default SE selected under brave://settings/search
  • updated to 1.42.x and ensured that Brave is still the default SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

image
image
image

Updated Profile (DDG/Startpage)
  • installed 1.41.x
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows and
  • updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

1.41.x
image

1.42.x
image
image
image


Checking to ensure that locales that don't have Brave Search as the default and still have the Set default search engine screen screen via brave://welcome (onboarding) are working as expected.

PL locale

Case #1 - #23908

brave://welcome

Using the STR/Cases outlined via #23908 (comment) and ensured that the Set default search engine screen was not removed from brave://welcome as per the following:

image

Case #2 - #23814

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Google was selected as the default via brave://settings/searchEngines

image
image
image

Updated Profile (Google/Google)
  • installed 1.41.x
  • ensured that Google was the default SE selected under brave://settings/search
  • updated to 1.42.x and ensured that Google is still the default SE in both Normal and Private window SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

image
image
image

Updated Profile (Qwant/Bing)
  • installed 1.41.x
  • ensured that Qwant was the default SE selected under brave://settings/search
  • updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

1.41.x
image

1.42.x
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants