Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Set default search engine screen for CA / DE / FR / GB / US #18415

Closed
rebron opened this issue Sep 28, 2021 · 4 comments · Fixed by brave/brave-core#10326
Closed

remove Set default search engine screen for CA / DE / FR / GB / US #18415

rebron opened this issue Sep 28, 2021 · 4 comments · Fixed by brave/brave-core#10326

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 28, 2021

Test plan

See #18331

Description

In brave://welcome/, remove Set default search engine screen for the following locales: CA / DE / FR / GB and US.

Screen Shot 2021-09-28 at 1 51 07 PM

Expected Result

  1. Go to brave://welcome/
  2. Set default search engine screen should be removed for CA / DE / FR / GB and US. Screen should remain for all other locales.
  3. Onboarding should be four steps now instead of five.

Brave version (brave://version info)

Target version is 1.31.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Dependency on #18331

Please see details here: https://github.com/brave/internal/issues/816

@kjozwiak
Copy link
Member

kjozwiak commented Oct 13, 2021

Adding QA/Blocked as the above will require a 1.31.x RC which I'm hoping to kick off tonight 👍 We'll need 1.31.84 or higher.

@LaurenWags
Copy link
Member

Removing QA/Blocked since 1.31.84 is available - https://github.com/brave/brave-browser/releases/tag/v1.31.84

@kjozwiak
Copy link
Member

@brave/legacy_qa as discussed with @bsclifton, the full verifications were done on Nightly on Win via brave/brave-core#10326 (comment) before uplifting the Brave Search work into 1.31.x. So in interest of time, we can just run through ~two of the locales when running through verifications rather than checking all five of the locales (CA / DE / FR / GB / US).

@LaurenWags
Copy link
Member

LaurenWags commented Oct 13, 2021

Verified passed with

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | macOS Version 10.15.7 (Build 19H1417)

Verified brave/brave-core#10326 (comment) for US and GB regions.

Confirmed that the search section under brave://welcome was removed for US and GB regions:

Example Example
US welcome GB1

Confirmed that the search section under brave://welcome was not removed for Spain and Russia regions:

Spain Spain Russia Russia
Spain-onboarding2 Spain-onboarding1 R1 R2

Verified PASSED using

Brave 1.31.84 Chromium: 95.0.4638.40 (Build oficial) (64 bits)
Revisión e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
Sistema operativo Linux

Verified brave/brave-core#10326 (comment) for US and GB regions.

Confirmed that the search section under brave://welcome was removed for FR and DE regions:

Example Example
Screen Shot 2021-10-13 at 12 47 13 PM Screen Shot 2021-10-13 at 12 50 40 PM

Confirmed that the search section under brave://welcome was not removed for Poland and Spain regions:

Poland Poland Spain Spain
Screen Shot 2021-10-13 at 1 03 50 PM Screen Shot 2021-10-13 at 12 56 39 PM Screen Shot 2021-10-13 at 1 01 55 PM Screen Shot 2021-10-13 at 12 58 48 PM

Verification passed on

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 10 Version 21H1 (Build 19043.1266)

Confirmed that the search section under brave://welcome was removed for US, GB and CA regions:

US GB CA
image image image

Confirmed that the search section under brave://welcome was not removed for Japan region:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment