Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #18523: Improve ads notification serving logging #18726

Closed
btlechowski opened this issue Oct 12, 2021 · 2 comments
Closed

Follow up to #18523: Improve ads notification serving logging #18726

btlechowski opened this issue Oct 12, 2021 · 2 comments
Assignees
Labels

Comments

@btlechowski
Copy link

Follow up to #18523: High CPU usage while Brave ads is enabled
The fix for above issue introduces a boolean flag which tracks if we are already serving an ad.
It could happen that the flag is not cleared therefor preventing users from getting ads.
The log will help us debug those scenarios.

Steps to Reproduce

  1. Add logging:
    https://github.com/brave/brave-core/blob/100ab8e90be161e96333ca493e7d5f0342799cfa/vendor/bat-native-ads/src/bat/ads/internal/ad_serving/ad_notifications/ad_notification_serving.cc#L101

Brave version (brave://version info)

Brave 1.32.62 Chromium: 95.0.4638.40 (Official Build) nightly (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @tmancey @jsecretan

@btlechowski btlechowski changed the title Follow up to #18523: Improve logging Follow up to #18523: Improve ads notification serving logging Oct 12, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude feature/ads labels Oct 12, 2021
@tmancey
Copy link
Contributor

tmancey commented Oct 12, 2021

Closing issue as will be resolved by #17542

@kjozwiak
Copy link
Member

As per brave/brave-core#10613 (comment), the uplift PR was scaled back and just includes the logging component rather than all the code from brave/brave-core#10459 which is going to ride the trains via 1.33.x. as per the discussion on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants