Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A/B test custom Brave ad notification dark mode background color #17528

Closed
tmancey opened this issue Aug 17, 2021 · 2 comments · Fixed by brave/brave-core#10041
Closed

A/B test custom Brave ad notification dark mode background color #17528

tmancey opened this issue Aug 17, 2021 · 2 comments · Fixed by brave/brave-core#10041
Assignees
@aseren
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.31.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 17, 2021

No description provided.

@aseren aseren self-assigned this Sep 8, 2021
aseren added a commit to brave/brave-core that referenced this issue Sep 10, 2021
@aseren
Feature param for custom ad notification dark mode background color.
1e54f66 
fix brave/brave-browser#17528
@aseren aseren mentioned this issue Sep 10, 2021
Merged
24 tasks
@tmancey tmancey added release-notes/exclude QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 15, 2021
@tmancey tmancey added this to the 1.31.x - Nightly milestone Sep 15, 2021
@LaurenWags
Copy link
Member

@tmancey @aseren could one of you please add a test plan for QA for this one if manual QA is needed? if no manual QA is needed we should change the label from QA/Yes to QA/No.

labelling as QA/Blocked until this is completed, thanks!

@btlechowski
Copy link

btlechowski commented Oct 12, 2021 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.31.71 Chromium: 94.0.4606.71 (Official Build) beta (64-bit)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS Ubuntu 18.04 LTS

Verified default custom ads color, used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled"

image

Compared the default color with 202327.
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/202327"

Verified they are the same color
image

Verified 000000 - black color
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/000000"

image

Verified FFFFFF - white color
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/FFFFFF"

image

Verified PASSED using

Brave 1.31.82 Chromium: 95.0.4638.40 (Official Build) beta (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Verified default custom ads color, used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled"

Screen Shot 2021-10-12 at 3 22 33 PM

Compared the default color with 202327.
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/202327"

Verified they are the same color
Screen Shot 2021-10-12 at 3 26 33 PM

Verified 000000 - black color
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/000000"

Screen Shot 2021-10-12 at 3 28 48 PM

Verified FFFFFF - white color
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/FFFFFF"

Screen Shot 2021-10-12 at 3 30 30 PM

Verification passed on

Brave | 1.31.82 Chromium: 95.0.4638.40 (Official Build) beta (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 10 Version 21H1 (Build 19043.1266)

Verified default custom ads color, used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled"

image

Compared the default color with 202327.
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/202327"

Verified they are the same color
image

Verified 000000 - black color
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/000000"

image

Verified FFFFFF - white color
Used command line:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:ad_notification_dark_mode_background_color/FFFFFF"

image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Feature param for custom ad notification dark mode background color. brave/brave-core
6 participants
@stephendonner @tmancey @LaurenWags @btlechowski @GeetaSarvadnya @aseren