Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards info links #1256

Closed
LaurenWags opened this issue Sep 24, 2018 · 5 comments
Closed

Brave Rewards info links #1256

LaurenWags opened this issue Sep 24, 2018 · 5 comments

Comments

@LaurenWags
Copy link
Member

Description

There are no links to Terms of Service, FAQ, or Uphold prior to or after enabling Brave Rewards.

Prior to enabling Brave Payments in b-l, a user could easily access the Terms of Service, FAQ, and Uphold links. Additionally, after enabling Brave Payments these links were still accessible from the Payments Page. Brave Rewards does not currently have these links. We should link to the corresponding items so users can review the info prior to deciding to enable Brave Rewards as well as have them easily accessible after BR has been enabled.

Steps to Reproduce

Using b-l (screenshots are from 0.24.0):
Launch Brave and Navigate to about:preferences#payments.
screen shot 2018-09-24 at 10 25 08 am
1 and 4 open a new tab for https://brave.com/Payments_FAQ.html
2 opens a new tab for https://uphold.com/
3 opens a new tab for https://basicattentiontoken.org/contributor-terms-of-service/

screen shot 2018-09-24 at 10 26 38 am
5 opens a new tab for https://brave.com/Payments_FAQ.html
6 opens a new tab for https://basicattentiontoken.org/contributor-terms-of-service/

screen shot 2018-09-24 at 10 28 34 am
7 opens a new tab for https://uphold.com/en/brave

Actual result:

Brave Payments contains links to Terms of Service, FAQ, and Uphold

Expected result:

Brave Rewards should contain links to Terms of Service, FAQ, and Uphold

Reproduces how often:

easily

Brave version (chrome://version info)

all BR enabled versions

Reproducible on current release:

no

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Uphold and ToS links were specifically added to Brave Payments:
brave/browser-laptop#11420
brave/browser-laptop#11942
brave/browser-laptop#11242

@LaurenWags
Copy link
Member Author

after talking about this with @NejcZdovc last week, @davidtemkin could you review and decide if we want to implement this from a product perspective? Personally I think it's a good idea to give the user the necessary info prior to enabling BR (whether they read it or not). And then to keep the info close at hand after enabling the feature.

@davidtemkin
Copy link

@jenn-rhim I believe that all of the elements that @LaurenWags called out need to be added to Brave Rewards. Can you take a look and make the necessary additions?

cc: @NejcZdovc @mandar-brave @bradleyrichter

@kjozwiak
Copy link
Member

kjozwiak commented Oct 3, 2018

A good candidate for the https://uphold.com/en/brave link could be the bolded Uphold under the wallet summary. Example:

screen shot 2018-10-03 at 5 55 37 pm

@NejcZdovc NejcZdovc modified the milestones: 1.0, 0.57.x - Dev Oct 22, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 31, 2018
@Miyayes
Copy link
Collaborator

Miyayes commented Dec 18, 2018

Terms of Service should be viewed as much higher priority than the other informational elements.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@NejcZdovc
Copy link
Contributor

closing as this is not valid anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants