Brave sync silently broken after switching a keyring on Linux

[butla]

Description

It looks like switching the keyring (DBus Secret Service) on my Linux made Brave sync broken and it's menu unresponsive. It looks like I can change settings, but if I leave the screen and come back all the options are unselected. Data isn't synced between my browsers.

Steps to Reproduce

1. Have gnome-keyring (or KDE Wallet? Or probably othet Secret Service implementation) running.
2. Add Brave to a sync chain.
3. Enable "sync everything"
4. Turn off Brave.
5. Kill gnome-keyring
6. Turn on a different keyring daemon (I did that by turning on the "Secret Service Integration" in KeePassXC)
7. Turn on Brave
8. Go to sync settings

Actual result:

All the sync options are unchecked. You can select them, but they'll go back to being unchecked if you close the settings and open them again.

Expected result:

Some info or error message should explain why the sync isn't working and what you should do.

Reproduces how often:

Always.

Workaround

1. Turn on the keyring you had running when you initially joined the sync chain (for me that was gnome-keyring)
2. Leave the sync chain in Brave.
3. Turn off Brave
4. Kill the old keyring daemon (gnome-keyring)
5. Start the new keyring daemon (KeePassXC, for me)
6. Turn on Brave
7. Join the sync chain again.

The above didn't work on my second laptop (same OS, same configuration), so after step 5 I:

• uninstalled Brave
• wiped ~/.config/BraveSoftware (so that all the settings are properly wiped)
• reinstalled Brave
• turned sync on

Brave version (info found on brave://version)

Brave 1.30.87 Chromium: 94.0.4606.71 (Official Build) unknown (64-bit)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS Linux
JavaScript V8 9.4.146.18
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36
Command Line /usr/lib/brave/brave --enable-crashpad --disable-client-side-phishing-detection --disable-domain-reliability --enable-dom-distiller --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=WebUIDarkMode,PrefetchPrivacyChanges,PasswordImport,ReducedReferrerGranularity,AutoupgradeMixedContent,SafetyTip,LegacyTLSEnforced,DnsOverHttps --disable-features=AutofillServerCommunication,HandwritingRecognitionWebPlatformApiFinch,FlocIdComputedEventLogging,FledgeInterestGroups,InterestCohortFeaturePolicy,LiveCaption,SignedExchangeSubresourcePrefetch,NavigatorPluginsFixed,TrustTokens,DirectSockets,IdleDetection,TextFragmentAnchor,ReadLater,NotificationTriggers,WebOTP,NetworkTimeServiceQuerying,SubresourceWebBundles,SignedExchangePrefetchCacheForNavigations,FirstPartySets,FledgeInterestGroupAPI,AutofillEnableAccountWalletStorage,InterestCohortAPIOriginTrial,PrivacySandboxSettings,FederatedLearningOfCohorts,LangClientHintHeader --flag-switches-begin --flag-switches-end
Executable Path /usr/lib/brave/brave
Profile Path /home/butla/.config/BraveSoftware/Brave-Browser/Default

Additional info

I'm on Manjaro XFCE.