Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include BAT ad values as part of the catalog #9835

Closed
jsecretan opened this issue May 19, 2020 · 2 comments · Fixed by brave/brave-core#9986
Closed

Include BAT ad values as part of the catalog #9835

jsecretan opened this issue May 19, 2020 · 2 comments · Fixed by brave/brave-core#9986
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.31.x - Release

Comments

@jsecretan
Copy link

Description

Currently, the ad protocol will return the ad value upon being seen. We could more reliably manage the display of estimated earnings with this.
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@tmancey tmancey added blocked and removed OS/Android Fixes related to Android browser functionality labels Aug 20, 2020
@tmancey
Copy link
Contributor

tmancey commented Aug 20, 2020

Blocked until catalog endpoint is updated to support ad values

@srirambv srirambv changed the title Include BAT ad values as part of the catalog [Desktop] Include BAT ad values as part of the catalog Sep 9, 2020
@LaurenWags LaurenWags mentioned this issue Nov 13, 2020
Closed
@tmancey tmancey changed the title [Desktop] Include BAT ad values as part of the catalog Include BAT ad values as part of the catalog Dec 5, 2020
@tmancey tmancey self-assigned this Sep 6, 2021
@tmancey tmancey added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. and removed blocked labels Sep 6, 2021
@tmancey tmancey mentioned this issue Sep 6, 2021
Merged
24 tasks
@tmancey tmancey added this to the 1.31.x - Nightly milestone Sep 8, 2021
@btlechowski
Copy link

Verification passed on

Brave 1.31.71 Chromium: 94.0.4606.71 (Official Build) beta (64-bit)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS Ubuntu 18.04 LTS

Verified values are part of catalog v8 on production
image

Verified values are parsed into database
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Include BAT ad values as part of the catalog brave/brave-core
3 participants
@jsecretan @tmancey @btlechowski