Add link on about:preferences#payments panel to Brave Payments Contributors Terms of Service

[mrose17]

as noted in the mockup above, there should be a link on about:preferences#payments labelled "Terms of Service" that opens a new tab at https://basicattentiontoken.org/contributor-terms-of-service/

New mock for ledger table

[bsclifton]

Moving back to Hotfix 6; if we can get a PR for this today, reviewer can decide on whether or not to pull into Hotfix 5 (since we need a release candidate today)

[cezaraugusto]

Opened #11957 moving back to hotfix 5

[srirambv]

Not as per mockup spec. Terms of service link is shown below the table.

[NejcZdovc]

@srirambv mock was updated and you can find it here #11957 (comment). Will update this issue as well

[kjozwiak]

Currently, the ToS only appears in the wallet when there's entries within the the ledger table... However, the ToS are not being displayed in the following cases:

• initial wallet creation
• empty ledger table

After a quick discussion with @mrose17, the ToS should be visible at all times.

STR:

• install brave and create a wallet (no ToS being displayed)
• visit a website and popular the ledger table (ToS visible)
• remove the entry from the table (no ToS being displayed)

[luixxiul]

If TOS should be displayed even before enabling the payments, the link should be displayed just above the closing div tag.

browser-laptop/app/renderer/components/preferences/paymentsTab.js

Lines 287 to 297 in 83e78cb

	{
	this.enabled
	? <EnabledContent settings={this.props.settings}
	onChangeSetting={this.props.onChangeSetting}
	ledgerData={this.props.ledgerData}
	showOverlay={this.props.showOverlay}
	siteSettings={this.props.siteSettings}
	/>
	: <DisabledContent />
	}
	</div>

[NejcZdovc]

@kjozwiak I think that need to display it only when wallet is enabled. Can you please confirm this?

[mrose17]

@NejcZdovc - it's needs to be there even when the wallet is enabled. it is entirely reasonable for someone to want to look at the terms of service before opting in. we need to give them that opportunity.

of course, "nobody reads those things" (or so i'm told), but it still needs to be available to allow people to make a fully informed decision, if they so chose.

that's one reason why the publishers.basicattentiontoken.org has a link to the publishers' terms of service on the home page, even if you haven't logged in...