Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Shields: Wants access to this site text on hover on pages where Brave Shields is non-functional #18685

Open
Tonev opened this issue Oct 11, 2021 · 1 comment

Comments

@Tonev
Copy link
Contributor

Tonev commented Oct 11, 2021

Description

I noticed a Wants access to this site text when hovering over the Brave Shields icon in the address bar, although I was currently on a page where Brave Shields is non-functional - an empty new tab page. I don't know if this new change is intentional, couldn't find any relevant pull requests in both Beta and Nightly milestones.

Steps to Reproduce

  1. Open a page where Brave Shields is non-functional, for example a blank new tab page or brave://settings/.
  2. Hover on the Brave Shields icon in the address bar.
  3. Observe the displayed text.

Actual result:

Untitled

Expected result:

I believe there shouldn't be such a text on pages where Brave Shields is non-functional.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.31.74 Chromium: 94.0.4606.71 (Official Build) beta (64-bit)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.32.58 Chromium: 95.0.4638.40 (Official Build) nightly (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CC: @antonok-edm

@pes10k
Copy link
Contributor

pes10k commented Oct 11, 2021

This might be related to @ShivanKaul 's (IIRC) work on disabling shields on brave:// pages, and a side effect of shield's extension-ish implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants