Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google appears at the top under brave://settings/search for certain locales #18683

Closed
kjozwiak opened this issue Oct 11, 2021 · 4 comments · Fixed by brave/brave-core#10450
Closed

Comments

@kjozwiak
Copy link
Member

Description

As per #18452, Brave should be set as the default browser and should be at the top of the dropdown list under brave://settings/search

Steps to Reproduce

  1. install 1.32.61 Chromium: 95.0.4638.40 using either Canada or USA as the locale
  2. launch Brave and visit brave://settings/search
  3. Brave should be the first entry under Search engine used in the address bar

Actual result:

image

Expected result:

image (1)

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.32.61 Chromium: 95.0.4638.40 (Official Build) nightly (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 11 Version 21H2 (Build 22000.194)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @brave/legacy_qa

@bsclifton
Copy link
Member

Note: fix should be added to uplift here:
brave/brave-core#10374

@kjozwiak
Copy link
Member Author

kjozwiak commented Oct 13, 2021

Adding QA/Blocked as the above will require a 1.31.x RC which I'm hoping to kick off tonight 👍 We'll need 1.31.84 or higher.

@LaurenWags
Copy link
Member

Removing QA/Blocked since 1.31.84 is available - https://github.com/brave/brave-browser/releases/tag/v1.31.84

@stephendonner
Copy link

stephendonner commented Oct 13, 2021

Verified PASSED using

Brave 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launch Brave
  3. visit brave://settings/search

Confirmed Brave shows up as the 1st entry in Search engine used in the address bar

Screen Shot 2021-10-13 at 8 50 43 AM


Verified PASSED using

Brave 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Linux

Steps:

  1. new profile
  2. launch Brave
  3. visit brave://settings/search

Repeated steps 1-3 with an additional step of changing display language in Ubuntu to French and English (Canada):

en-US fr en-CA
Screen Shot 2021-10-13 at 12 17 16 PM Screen Shot 2021-10-13 at 12 22 05 PM Screen Shot 2021-10-13 at 12 24 36 PM

Confirmed Brave shows up as the 1st entry in Search engine used in the address bar


Verification passed on

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 10 Version 21H1 (Build 19043.1266)

Steps:

  1. new profile
  2. launch Brave
  3. visit brave://settings/search

US Region
Confirmed Brave shows up as the 1st entry in Search engine used in the address bar
image

Confirmed Brave shows up as the 1st entry in Search engine used in the address bar in Guest window
image

DE Region
image

GB Region
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment