Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-ipfs does not start without Rosetta on Apple Silicon #16912

Closed
lidel opened this issue Jul 12, 2021 · 3 comments · Fixed by brave/brave-core#10364
Closed

go-ipfs does not start without Rosetta on Apple Silicon #16912

lidel opened this issue Jul 12, 2021 · 3 comments · Fixed by brave/brave-core#10364

Comments

@lidel
Copy link

lidel commented Jul 12, 2021

Description

IPFS activation is broken when macOS on Apple Silicon has no Rosetta installed.

Steps to Reproduce

  1. Install Brave for Apple Silicon on new macOS 11.2 or later (eg. M1 Mac Mini) without Rosetta
  2. Try activating local go-ipfs

Actual result:

Get error as seen below:

Screenshot 2021-07-12 at 22 01 32

Expected result:

Run without error.

Reproduces how often:

Always.

Brave version

Nightly v1.28.74

Fix suggestions

I believe there are two ways to fix this:

  • User should either get a prompt to install Rosetta (like they already do when amd64 version of Brave is about to be run on ARM) or similar meaningful error that points the user at an issue with macOS (current one suggest Brave/IPFS is at fault).
  • Brave build for arm64 should use arm64 binary for go-ipfs (right now it seems to use amd64, which fails when Rosetta is missing)
@lidel
Copy link
Author

lidel commented Jul 26, 2021

IPFS project is aiming at having signed arm64 binaries for go-ipfs 0.10.
I suggest we park this until then, and use them on Apple Silicon, so there is no need for Rosetta.

@spylogsster spylogsster self-assigned this Aug 9, 2021
@dvcrn
Copy link

dvcrn commented Sep 28, 2021

@lidel is it possible to tell brave to use a specific binary for go-ipfs instead of downloading it? This way I could just point it to the already installed Apple Silicon variant

/EDIT: Oh actually there is! It's just not exposed in the UI. Editing the Brave preferences file (binary_path) directly works.

Brave running with Apple Silicon built ipfs as local node:

Screen Shot 2021-09-28 at 17 54 11

@stephendonner
Copy link

Verified PASSED using

Brave 1.32.66 Chromium: 95.0.4638.40 (Official Build) nightly (arm64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave using --use-dev-goupdater-url
  3. loaded ipns://en.wikipedia-on-ipfs.org
  4. clicked Install and start

Confirmed I got go-ipfs_v0.10.0_darwin-arm64 and was able to start/stop/restart node, and open IPNS/IPFS links

example example
Screen Shot 2021-10-12 at 10 13 36 AM Screen Shot 2021-10-12 at 10 17 22 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment