Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue rather than orange page loading animation #18650

Closed
Tonev opened this issue Oct 8, 2021 · 4 comments · Fixed by brave/brave-core#10426
Closed

Blue rather than orange page loading animation #18650

Tonev opened this issue Oct 8, 2021 · 4 comments · Fixed by brave/brave-core#10426

Comments

@Tonev
Copy link
Contributor

Tonev commented Oct 8, 2021

Description

The page loading animation in Brave Nightly is blue rather than Brave's orange. The issue is present with both Light and Dark Brave colors.

Steps to Reproduce

  1. Install the latest Brave Nightly.
  2. Load a random page.
  3. Observe the color of the page loading animation.

Actual result:

t5t0gvSwLV

Expected result:

P9SdFIhZfd

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.32.56 Chromium: 95.0.4638.40 (Official Build) nightly (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

Thanks, @Tonev; nice catch! Definitely a Chromium Release 95 (CR95) issue. /cc @mkarolin @rebron @kjozwiak

(I wonder how many more of these Brave-specific UI changes I fail to notice.)

mkarolin added a commit to brave/brave-core that referenced this issue Oct 8, 2021
Fixes brave/brave-browser#18650

Also, affects omnimox results highlight color, action icon updates, and
some others.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/fee66411adf9bd8754a150a57ef0fab1e259ffc7

commit fee66411adf9bd8754a150a57ef0fab1e259ffc7
Author: Peter Boström <pbos@chromium.org>
Date:   Thu Aug 26 19:28:43 2021 +0000

    Use accent color for tab-icon throbber

    Bug: 1217742
mkarolin added a commit to brave/brave-core that referenced this issue Oct 8, 2021
This is conjunction with a prior change to
NativeTheme::kColorId_FocusedBorderColor in chromium_src/ui/native_theme/common_theme.cc

Fixes brave/brave-browser#18650
@simonhong simonhong added this to the 1.32.x - Nightly milestone Oct 11, 2021
@kjozwiak
Copy link
Member

Adding QA/Blocked as the above will require a 1.31.x RC which I'm hoping to kick off tonight 👍 We'll need 1.31.84 or higher.

@LaurenWags
Copy link
Member

Removing QA/Blocked since 1.31.84 is available - https://github.com/brave/brave-browser/releases/tag/v1.31.84

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 13, 2021
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | macOS Version 10.15.7 (Build 19H1417)
  • ensured that the loading animation appears uses the correct color when loading websites
  • ensured that the loading animation appears uses the correct color when loading brave:// pages
  • ensured that the selection highlight under the omnibox is using the correct color when selecting items

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants