Deploy Checklist: New Expensify 2023-07-10

[OSBotify]

Release Version: 1.3.39-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• 17004 - add new ESLint rules to enforce use of accessible pressable components #20363
• Fix user isn't a participant of report displays in detail #20497
• Update Avatar Patterns for LHN #20512
• fix: 20517 quickly clicking on different chats on LHN it opens one by one #20797
• feat: support Spanish emojis #20828
• Implement Task Detailed View Redesign #20841
• Improve delete contact method #20842
• Display Money Request reports as Cards in the chat #20900
• migrating MoneyRequestAmountPage to functional component #21005
• Update Everything-About-Chat.md #21364
• Update style guide #21478
• Fix app show infinite loading page after create workspace from oldDot #21572
• [No QA] Fast fetch! #21651
• migrate LogOutPreviousUserPage #21767
• Refactor new date picker #21792
• Only render UserDetailsTooltip on web #21807
• Money request header scrollable #21918
• open date-picker on focus on mobile chrome #21928
• fix console error on report screen which has task #22007
• Remove all uses of report.lastActorEmail #22008
• Migrate to function component  #22025
• Remove all uses of report.ownerEmail and replace with ownerAccountID where appropriate #22075
• Remove all uses of report.managerEmail #22081
• fix wrong image shown in share section when creating a task in money request report #22137
• [NO QA] Use bundle exec for pod install #22144
• fix dismiss split bill modal when update only admin #22198
• [NoQA] Increase the octokit gh throttling times #22210
• Refactor: Migrate BankAccountManualStep.js to function component  #22245
• Fix for: Reopened task message does not translate to Spanish in LHN #22277
• fix: Green dot doesn't get removed from an archived taskReport row in LHN #22278
• Fix<21793>: Error is shown in state/province field of Home address, Personal details while changing to a different location than US #22288
• fix Not able to invite an email when it's a substring of the selected email #22319
• Hidden the attachment that is invisible #22320
• Hide validate code form immediately when account is cleared #22324
• Reset last visible message on failure of attachment upload #22342
• do not clear composer when escape is pressed #22350
• Add international code to @expensify.sms numbers so that the filters work #22352
• fix console error on attach large file #22354
• Create Expensify-Chat-Playbook-for-Conferences #22369
• placeholder replaced with label in task pages #22379
• [No QA] Fix hitslop calculation in pressables with shouldUseAutoHitSlop #22396
• [TextInput] show default cursor when hover over label and line #22397
• Make auto-hitslop opt-in instead of opt-out on Pressables #22400
• Revert the ability to search a report by participant accountID #22407
• Changed the logic to be AND, also removed the usage of underscore #22411
• Move the no result found message to top in the emoji menu #22428
• Fix The tooltip changes its position when changed the language preference #22457
• Fix crash for tasks on mobile #22458
• Resend magic code link title #22466
• Fix: Typing feedback text under composer is not being displayed #22501
• Fix: Compose box is stuck with non removable space if we add space, click on upper arrow to edit and save edited message #22530
• Ensure the paypal option is showing based on the payee data #22531
• fix enabled property warning #22538
• PressableWithoutFocus followup - change style propType to be in line with GenericPressable type #22539
• [NO QA] Revert "Release pending versions before submitting a new version for review" #22541
• Fix lint warning #22544
• Minor ReportActionComposer code clean up #22550
• Fix copy for tasks #22563
• break-word style added in tooltip login #22567
• Use correct function getTopmostReportId instead of removed one #22584
• Fix clickable area of multiple avatars component #22595

Deploy Blockers:

• [$1000] Flag as offensive option show for their own comment in offline mode #22286
• Workspace - Email is missing in member tooltip when hovering over member #22636
• [HOLD for payment 2023-07-26] IOU - Money request header is not greyed out in offline mode #22640
• Web - Workspace name missing after #announce or #admins #22647
• [$1000] [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected #22654
• [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] New Task - Crash when choosing Assignee as phone number #22657
• Assign task - The word title is not translated into Spanish in chat #22684
• Emoji - Emoji search results in English are displayed for account with Spanish language set #22687
• Task - Button does not changes to "Mark as incomplete" when check to complete #22694
• [HOLD for payment 2023-08-10] [$2000] 'Date' section is not grayed out and the cursor does not change on the IOU report #22742
• WS - Members - Inviting new user is duplicated in members list #22747
• [$1000] Chat - Part to in IOU preview money request can be moved #22756

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[francoisl]

Going to check the following PRs that were CP'ed for the previous checklist and already tested:

• 22595
• 22584
• 22501

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.39-5 🚀

[mvtglobally]

Can you check this internally #20363 (comment)

[mvtglobally]

@francoisl regression is in progress. we still have about 35% to go

We are still working on the 20 PR validations across platforms

[francoisl]

👍 Thanks for the update. I took care of that internal QA, and we're working on the 2 open blockers in the meantime.

[mvtglobally]

PR #20841 is failing #20841
PR #21918 is failing #22640

[mvtglobally]

@francoisl
#21364 is PROD QA, are we ok to check it off?
#21807 (comment) This is unclear on what needs to be tested. Can we get updated QA steps or just validate this internally?

[francoisl]

#21364 is PROD QA, are we ok to check it off?

Yes let's check it off

#21807 (comment) This is unclear on what needs to be tested. Can we get updated QA steps or just validate this internally?

I'll take care of this internally, and ask the author if needed.
Edit: done internally

[mvtglobally]

#20497 is is failing as we are getting Continuous loading spinner after removing the member from workspace on user A & also repro old KI #19994. Pls double check

[Julesssss]

I checked off #22742 because it is too minor to be a blocker.

[mvtglobally]

@Julesssss @francoisl Regression is completed

Final summary
#20497 is is failing as we are getting Continuous loading spinner after removing the member from workspace on user A & also repro old KI #19994. Pls double check
#20512 pending validation on all platform.
PR #20841 is failing #20841
PR #21918 is failing #22640
#21767 (comment)
#22075 is failing #22747
#22324 pending validation on all platform.
#22369 is failing #22682

[mvtglobally]

We are done,

Checking off #22324
#20512 is failing #22751

Also, let us know if any CPs need to be verified

[francoisl]

Thanks @mvtglobally, I'm going to check those above you mentioned.

Also FYI, we've been having issues with cherry-picks yesterday, but we have a fix that we think might work now. I'll post an update later when those are ready to test.

[francoisl]

• Fix user isn't a participant of report displays in detail #20497 - we tested internally, checking it off
• The fix for blocker [$1000] [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected #22654 was CP'ed and tested internally, checking it off
• I removed the blocker from [$1000] Chat - Part to in IOU preview money request can be moved #22756, doesn't seem to be a major issue. We'll treat it like a regular bug
• Create Expensify-Chat-Playbook-for-Conferences #22369 will be internal production QA. I assigned the author of the PR a reminder to perform the production QA, checking it off
• Checking 21767 based on the comment in the PR
• 22640/21918 the blocker label was removed by the assignees, checking
• 20512: no need to block on 22751, we'll treat it as a regular issue (there's already a proposal)
• 22075/22747 is also happening on production and is being worked on already, checking off

Still looking into the last 2 blockers:

• WS - Members - Inviting new user is duplicated in members list #22747
• [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] New Task - Crash when choosing Assignee as phone number #22657

[arosiclair]

Removed blocker label from #22747. Issue is already on prod.

[francoisl]

The fix for the last blocker is being cherry-picked right now, I'll test it on staging and if all goes well, we'll be good to go.

[mvtglobally]

@francoisl keep us posted if you want us to QA or you can Internally validate faster

[francoisl]

Thanks. I'll take care of it, it should be pretty quick.

[francoisl]

QA passes for the last CP, everything is checked, going to close and ship this.

[francoisl]

[francoisl]

The deploy failed due to a protection on the production branch. Looking into it now, but reopening this so that no other PRs get accidentally deployed to staging in the meantime.

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[francoisl]