Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected #22654

Closed
5 of 6 tasks
lanitochka17 opened this issue Jul 11, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #20828

Action Performed:

  1. Open NewDot
  2. Open any chat
  3. Open emoji picker
  4. Select Non-default skintone
  5. Select any emojis supporting skintone
  6. Open emoji picker again

Expected Result:

Frequently used emoji should be displayed with selected skintone

Actual Result:

Frequently used emoji is displayed with default skintone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6124037_video_77.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01531da77fbe1c9bc3
  • Upwork Job ID: 1683864020992884736
  • Last Price Increase: 2023-07-25
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 11, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 11, 2023
@stitesExpensify
Copy link
Contributor

This PR caused the regression #20828

@francoisl
Copy link
Contributor

The fix was CP'ed to staging and tested there, removing the DeployBlocker label and checking it off the checklist.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jul 13, 2023
@melvin-bot melvin-bot bot changed the title Emoji - Frequently Used emojis display default skintone color instead of selected [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected Jul 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 14, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

@stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 25, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected [$1000] [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] Emoji - Frequently Used emojis display default skintone color instead of selected Jul 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01531da77fbe1c9bc3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@stitesExpensify
Copy link
Contributor

@bfitzexpensify can we pay @0xmiroslav for their role as C+ reviewer? The PR is already merged, we just didn't have anyone assigned on this issue for payment

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2023
@bfitzexpensify
Copy link
Contributor

Offer sent @0xmiroslav

@0xmiros
Copy link
Contributor

0xmiros commented Jul 27, 2023

@bfitzexpensify can you please hold my payment until further notice? I am working on some stuff due to recent measurements in my region. And update issue to Monthly. Same applies to any other issues I am assigned. Thanks

@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@bfitzexpensify bfitzexpensify added Monthly KSv2 and removed Daily KSv2 labels Jul 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@bfitzexpensify
Copy link
Contributor

Still held on @0xmiroslav's payment particulars

@melvin-bot melvin-bot bot removed the Overdue label Sep 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2023
@bfitzexpensify
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@stitesExpensify
Copy link
Contributor

I don't think @0xmiroslav is still holding payment anymore

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Nov 6, 2023

still 😞
Let's close this. I am tracking myself. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants