-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong image shown in share section when creating a task in money request report #22137
Conversation
@mollfpr Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @mollfpr can you handle the checklist and testing?
Reviewer Checklist
Screenshots/VideosWeb22137.Web.movMobile Web - Chrome22137.mWeb.Chrome.webmMobile Web - Safari22137.mWeb.Safari.mp4Desktop22137.Desktop.moviOS22137.iOS.mp4Android22137.Android.webm |
src/libs/actions/Task.js
Outdated
@@ -551,8 +551,9 @@ function getAssignee(details) { | |||
* */ | |||
function getShareDestination(reportID, reports, personalDetails) { | |||
const report = lodashGet(reports, `report_${reportID}`, {}); | |||
const personalDetail = personalDetails[0] || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this. The personalDetails
is an object, and end up the personal detail always {}
.
src/libs/actions/Task.js
Outdated
return { | ||
icons: ReportUtils.getIcons(report, personalDetails), | ||
icons: ReportUtils.getIcons(report, personalDetails, UserUtils.getAvatar(personalDetail.avatar, personalDetail.accountID), true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here getAvatar
will always return the fallback svg because of the undefined value of personalDetail
.
Passing isPayer
is always to true is off for me. We only need the isPayer
to true when the report is an IOU. So it's better to pass the value from isIOUReport
.
@mollfpr You are right. Please re-review PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well 👍
@bondydaa Could you please re-review this PR? |
@bondydaa Could you please merge this PR into main branch? |
oh yep sorry was waiting for checks to finish and got distracted with other stuff. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.39-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀
|
Details
Fixed Issues
$ #21582
PROPOSAL: $ #21582 (comment)
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Web.mov
Mobile Web - Chrome
Android-Chrome.mp4
Mobile Web - Safari
iOS-Safari.mov
Desktop
Desktop.mov
iOS
iOS.mov
Android
Android.mp4