Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task - Button does not changes to "Mark as incomplete" when check to complete #22694

Closed
3 of 6 tasks
lanitochka17 opened this issue Jul 11, 2023 · 5 comments
Closed
3 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #20841

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to + > Assign task & finish the flow for creating the task
  3. Click on the title item & change the title to be a really long name
  4. Click on the description item & change the title to be a really long name
  5. Assign the task to a person with existing chat
  6. Click on "Confirm task" button
  7. Click the checkmark to complete the task

Expected Result:

After clicking the checkmark to complete the task - the text in the button above should change to "Mark as incomplete" & when uncheck the checkmark the text in the button above should change to "Mark as done"

Actual Result:

The text in the button does not change to "Mark as incomplete"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6123699_Recording__338.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

[View all open jobs on GitHub](https://github.com/Expensify/App/issues?q=is%3Aopen+is%3

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 11, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Nikhil-Vats
Copy link
Contributor

@thienlnam @jasperhuangg is this expected behaviour or is this a bug?

@francoisl
Copy link
Contributor

@jasperhuangg is working on several improvements for tasks in #22586, so maybe it's not worth blocking on this. That said, I can reproduce the issue even on the branch from 22586, so this could be something he didn't know about yet.

@thienlnam
Copy link
Contributor

Moving the blocker label as it's not really a bug - this seems to expected. The mark as done button is removed after the task is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants