-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app show infinite loading page after create workspace from oldDot #21572
Conversation
Screen.Recording.2023-06-27.at.23.38.49.movThe chat is correctly navigated to the workspace admin room, but the infinite loading still appears. I'm testing with a sign-out account. It's working fine if you already sign-in. |
Thanks for reviewing @mollfpr . I will take a look into this case |
@mollfpr I think those LOC do not work anymore. It seems we can't navigate to a chatReport by setParams anymore App/src/libs/actions/Policy.js Lines 1044 to 1046 in 0bbf3fc
This is the API logs I screenshot when we navigate from oldDot to newDot when we're not logged in There is no API call of There is a GH report for this case here #21408. I think they're same root cause. Wdyt? (I mean when we create new WS, we can't open the Admin page behind the RHN atm). |
Sorry for the delay @hoangzinh and thanks for the investigation for the LOC! I'll check the proposal in #21408 and see if it's fix our issue here. Otherwise, we can continue with what we have here and log that issue. |
Reviewer Checklist
Screenshots/VideosWeb21572.Web.movMobile Web - Chrome21572.mWeb.Chrome.webmMobile Web - Safari21572.mWeb.Safari.mp4DesktopiOSAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly bump @techievivek for a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for fixing this up.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.39-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀
|
Details
Fixed Issues
$ #18351
PROPOSAL: #18351 (comment)
Tests
On Web:
On mWeb:
Offline tests
Can not test when offline
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-06-26.at.21.52.59.-.web.mp4
Mobile Web - Chrome
Screen.Recording.2023-06-26.at.23.07.42.-.android.chrome.mov
Mobile Web - Safari
Screen.Recording.2023-06-26.at.23.11.30.-.ios.safari.mov
Desktop
N/A because this issue has not fixed #17391
iOS
N/A
Android
N/A