-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 20517 quickly clicking on different chats on LHN it opens one by one #20797
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR change looks good, but I'll need sometime to test. I'll have the update by tomorrow.
@tienifr I think we should add a comment on why we're making this change and why it's for small screen device only. |
@mananjadhav Check it out! |
@mananjadhav Can you help check again? |
@tienifr I did try to test this but I am blocked on the testing. The chat page doesn't load for me at all. I thought it was my network, but I switched my branch to main and it loaded just fine (and few other PRs I QAed). Can you confirm it is working fine for you? I would recommend try incognito and sign-in. Attempt from an existing Account Screen.Recording.2023-07-05.at.10.54.43.PM.movAttempt from an new Account incognito Screen.Recording.2023-07-05.at.11.01.34.PM.mov |
@mananjadhav It's working fine for me after pulling |
@tienifr This is taking unexpectedly longer. Your screencasts shows the last chat always opened. But for my testing this always opens the first chat I clicked. The behavior is same for Android and Android Chrome. Screen.Recording.2023-07-07.at.1.10.53.AM.movScreen.Recording.2023-07-07.at.1.02.56.AM.mov |
@stitesExpensify can I get some help here in testing if you're experiencing the same issues? |
@mananjadhav I don't know why it took so long on your side, but it's working fine on mine. The transition is even so fast that I can barely reproduce the bug. Maybe @stitesExpensify can help verify here. Also in my screenshots, it opened the first clicked chat too, not the last one. Actually in the Android video, there were two chats with the same recipient: |
I'll give this a test today! |
I am also seeing the first chat always open, at least on iOS. That is the expected result right? My android environment is currently stuck on the loading page, it looks like more people are running into it too https://expensify.slack.com/archives/C01GTK53T8Q/p1688665141544519 2023-07-07_16-28-41.mp42023-07-07_16-29-59.mp4 |
Yes, that's expected. And the skeleton issue on Android is not related to this PR. I have faced that several times on emulator too. Cc @mananjadhav |
Reviewer Checklist
Screenshots/VideosWebweb-back-to-back-navigation.movMobile Web - Chromemweb-chrome-back-to-back-navigation.movMobile Web - Safarimweb-safari-back-to-back-navigation.movDesktopdesktop-back-to-back-navigation.moviOSios-back-to-back-navigation.movAndroidandroid-back-to-back-navigation.movThanks for the patience here, and sorry for the delay. I was OOO and I had 0 network to inform about it. @tienifr Yeah the confusion was due to the similar name. Thanks to you and @stitesExpensify for clarifying. The reason for the latency could be I was using high traffic account with 3G connection hotspot. I just added screencasts for all and it tests well. |
@stitesExpensify All yours 🎀 👀 🎀 C+ Reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.39-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀
|
Details
Fixed Issues
$ #20517
PROPOSAL: #20517 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-06-15.at.15.54.14.mov
Mobile Web - Chrome
video_2023-07-07_09-44-11.mp4
Mobile Web - Safari
original-D45AFADE-81D4-4776-8572-54E38C68A3BF.mp4
Desktop
Screen.Recording.2023-06-15.at.16.03.47.mov
iOS
Screen.Recording.2023-06-15.at.12.34.57.mov
Android
Screen.Recording.2023-06-15.at.16.36.23.mov