-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix enabled property warning #22538
fix enabled property warning #22538
Conversation
@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSios.movAndroidandroid.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested already while in draft. Works well.
Wait for a second, doesn't this change the behavior? If I've used a weird syntax for this 😐 This may be the proper solution to resolve this problem |
How about using that syntax already in this PR? |
But it changes the behavior. If the |
This component should be used as enabled by default even if the prop enabled isn't defined |
I meant to use |
Ah, yes sorry 😄 Yeah I think we could create a new patch and replace the current one with the code from react-native PR. To make sure that the changes here are the same as the proposed one for the upstream fix |
Should I create a PR or maybe @ntdiary can continue with this one? |
I think @ntdiary can continue here. @adamgrzybowski you still review this |
have replaced with |
LGTM |
@ntdiary which RN version are you based on? patch doesn't work for me, seems conflict |
@0xmiroslav, RN version is still the same. Could you try |
I will try again. Please pull main |
Worked after this step. @robertjchen all yours! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@robertjchen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.39-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀
|
Details
Fixed Issues
$ #22206
PROPOSAL: #22206 (comment)
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
N/AMobile Web - Chrome
N/AMobile Web - Safari
N/ADesktop
N/AiOS
ios-native.mp4
Android
android-native.mp4