[HOLD for payment 2023-07-20] [$1000] Dev : closing the keyboard shows a warning on dev.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Run the dev app.
2. Go to any chat.
3. Tab composer to open the keyboard.
4. Hide the keyboard by dragging down.

Expected Result:

No warnings are shown.

Actual Result:

A warning is shown(See the attachment).

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688406249179949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0135902153bfc14487
• Upwork Job ID: 1678296096048033792
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[parasharrajat]

Cc: @ntdiary You might be interested in solving this.

[dylanexpensify]

posted to slack to get someone with a dev acct to repro this

[ntdiary]

Cc: @ntdiary You might be interested in solving this.

Yeah, it's still reproducible, and if needed, I'm glad to raise a proposal and PR. : )

test.mp4

[ntdiary]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Closing the keyboard will generate a warning that the enabled property does not exist.

What is the root cause of that problem?

App/patches/react-native+0.71.2-alpha.3.patch

Line 67 in 15e547e

+ if (enabled && duration && easing) {

This enabled variable is not defined.

What changes do you think we should make in order to solve the problem?

I think what we actually wanted to use is this.props.enabled, we can replace enabled with this.props.enabled

What alternative solutions did you explore? (Optional)

N/A

[parasharrajat]

@dylanexpensify It is reproducible on main. We don't need to wait here. Let's get this fixed.

@ntdiary 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

THis issue might be the root cause of #21540 (comment).

[ntdiary]

I raised a draft PR. If permitted, I will test and fill the checklist later. : )

[robertjchen]

Thanks- the proposal makes sense to me! Assigning to @ntdiary

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0135902153bfc14487

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[0xmiros]

yup, this is straightforward fix. As there's no lint rule in patch, this bug couldn't be easily discovered.
I commented on offending PR which caused this regression.

[0xmiros]

• The PR that introduced the bug has been identified. Link to the PR: [navigation-refactor ] Disable KeyboardAvoidingView for the BaseSidebarScreen and fix KeyboardAvoidingView used with react-freeze #21124
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [navigation-refactor ] Disable KeyboardAvoidingView for the BaseSidebarScreen and fix KeyboardAvoidingView used with react-freeze #21124 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I don't think regression test is needed. We're still updating RN version to higher (0.72)

[parasharrajat]

Reporting payment requested.

[parasharrajat]

@dylanexpensify Can you please post the payment summary here?

[parasharrajat]

@dylanexpensify I am not C+ on this.

[0xmiros]

The PR was merged the same day @ntdiary was assigned

[dylanexpensify]

apologies, UPDATE:

Summarizing pay outs for the issue:

Issue reporter: @parasharrajat $250
Contributor: @ntdiary $1500
Contributor+: @0xmiroslav $1500

Upwork job is here.

[ntdiary]

have applied 😄
https://www.upwork.com/freelancers/~01cc34a71a6b35f7a5

[JmillsExpensify]

Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

[ntdiary]

@dylanexpensify, a friendly reminder. 🙂

[dylanexpensify]

Offer sent @ntdiary!

[ntdiary]

@dylanexpensify, Hi, it seems the offer amount is wrong. : )

[dylanexpensify]

@ntdiary modified offer to show $1,500 amount!

[dylanexpensify]

Payment sent/contract closed!

[dylanexpensify]

@0xmiroslav are you paid in ND? Or upwork still?

[0xmiros]

@dylanexpensify please hold my payment. I just replied email with full details - #22745 (comment)

[dylanexpensify]

got it, moving this to weekly!

[dylanexpensify]

still waiting

[0xmiros]

Not on hold anymore.
@dylanexpensify can you check last email thread and handle my payment please?

[dylanexpensify]

Yes! TY!

[dylanexpensify]

@0xmiroslav do we just need a new upwork job for Volodymyr to apply to?

[0xmiros]

I think https://www.upwork.com/jobs/~0135902153bfc14487 can be reused if not expired.

[dylanexpensify]

@0xmiroslav mind having them apply here? 🙇‍♂️

[dylanexpensify]

bump on this @0xmiroslav ^ 🙇‍♂️

[0xmiros]

@dylanexpensify applied. thanks

[dylanexpensify]

offer sent @0xmiroslav!

[dylanexpensify]

all done!