[$1000] Flag as offensive option show for their own comment in offline mode

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to offline
2. go to any chat
3. send any message
4. hover on that message

Expected Result:

Flag as offensive option should not show for own comment

Actual Result:

Flag as offensive shows for own comment

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.37-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-05.at.6.12.49.PM.mov

Recording.1169.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688561027320599

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01517ea79f1ae718c6
• Upwork Job ID: 1678677924567666688
• Last Price Increase: 2023-07-11

[esh-g]

Proposal

Please re-state the problem

Flag as offensive option show for their own comment in offline mode

What is the root cause of that problem?

This is a regression of the PR: #21874
We can see the line below:

App/src/libs/ReportUtils.js

Line 2113 in f9a8529

!loginList.includes(reportAction.actorEmail) &&

Here we are checking if the reportAction.actorEmail is present in the user login methods. But when offline, the optimistic report action doesn't have reportAction.actorEmail because that was removed in this PR: #21771

What changes do you think we should make to solve this problem?

Instead of checking each login method, we can just check the accountID because actorAccountD is present for optimistic chat report. Just like we do in canEditReportAction

App/src/libs/ReportUtils.js

Line 205 in f9a8529

reportAction.actorAccountID === currentUserAccountID &&

What other approach did you explore?

None

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

Reverted the PR that caused this

[luacmartins]

Since we're reverting this, I'm gonna close the PR I had to fix undefined logins/displayNames

[iwiznia]

Asked for CP here https://expensify.slack.com/archives/C07J32337/p1688587371095319

[iwiznia]

Tested it and the bug is gone

[gadhiyamanan]

reporting bonus is pending
Cc: @iwiznia @laurenreidexpensify

[gadhiyamanan]

bump @iwiznia @laurenreidexpensify ^^

[iwiznia]

cc @laurenreidexpensify on the above

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01517ea79f1ae718c6

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[laurenreidexpensify]

@gadhiyamanan pls apply https://www.upwork.com/jobs/~01517ea79f1ae718c6 and I will issue bonus thanks

[gadhiyamanan]

@laurenreidexpensify applied, thanks!

[francoisl]

To clarify, we just need to handle payment at this point and this is no longer a deploy blocker, right? Going to remove the label.

[gadhiyamanan]

@laurenreidexpensify offer accepted, thanks!

[laurenreidexpensify]

@gadhiyamanan has been paid 👍