Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Chat - Part to in IOU preview money request can be moved #22756

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 12, 2023 · 14 comments
Closed
1 of 6 tasks

[$1000] Chat - Part to in IOU preview money request can be moved #22756

lanitochka17 opened this issue Jul 12, 2023 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Login with any account
  3. Create money request
  4. Open IOU preview
  5. Swipe down with your finger

Expected Result:

Part to in the IOU preview money request NOT moves

Actual Result:

Part to in the IOU preview money request can be moved
Split bill the same

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6125248_RPReplay_Final1689107086.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019548cf7c39f424bc
  • Upwork Job ID: 1679207753173835776
  • Last Price Increase: 2023-07-12
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 12, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@c3024
Copy link
Contributor

c3024 commented Jul 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

The To and below part in money request report bounces.

What is the root cause of that problem?

Bouncing appears to be the default behaviour for FlatList

What changes do you think we should make in order to solve the problem?

I think we should pass bounces={!(this.props.report.type == 'iou')} from ReportScreen to ReportActionsView and so on to index.ios.js in InvertedFlatList
We may decide what other kind of reports for which the bouncing needs to be disabled and use in the boolean accordingly or just pass false directly for all.

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Jul 12, 2023
@francoisl
Copy link
Contributor

I'm going to remove the deploy blocker label, this can be worked on now but isn't stopping from using the app.

PS: @c3024 can you tell if this is a regression from a recent PR?

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Jul 12, 2023
@c3024
Copy link
Contributor

c3024 commented Jul 12, 2023

I'm checking but could not find any PR that might have caused this change yet.

@marcochavezf
Copy link
Contributor

I will apply the Bug label here to follow the BZ process

@marcochavezf marcochavezf added the Bug Something is broken. Auto assigns a BugZero manager. label Jul 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@marcochavezf marcochavezf added Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor labels Jul 12, 2023
@melvin-bot melvin-bot bot changed the title Chat - Part to in IOU preview money request can be moved [$1000] Chat - Part to in IOU preview money request can be moved Jul 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~019548cf7c39f424bc

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@aimane-chnaif
Copy link
Contributor

This is not a bug but expected for now.
This page is being refactored again in #22484
Here's design - #20486 (comment)

@marcochavezf
Copy link
Contributor

Oh thanks @aimane-chnaif, given that's being refactored, I'm leaning towards closing this GH, what do you think?

@aimane-chnaif
Copy link
Contributor

yes, we can close this

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants