Sync 2.5 release #116
Merged
Sync 2.5 release #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename k8serrors to apierrs for consistency - Use controllerutil methods add and remove finalizer Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 4869de8)
- user will be able to enable/disable component from Yaml view (cherry picked from commit 13a7e82)
* Update opendatahub label * Update Codeflare manifests path * Move creation of default DSC * Trigger delete configmap after finalizer removal * Revert changes in deploy Revert changes made in deploy.go. Dashboard resources fail to cleanup with updated changes (cherry picked from commit 1e3b083)
…pendatahub-io#674) Implements wait with timeout for DSCI to be actually deleted from the cluster as part of the test cleanup. Otherwise we might end up with DSCI not deleted yet when another test starts. This leads to failing/flaky tests. (cherry picked from commit e5bc958)
* update(kserve): manifests path from in-repo * update: no more odh-manifests in ODH build Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 890da22)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit c88d84d)
… on namespaces (opendatahub-io#679) * backport(2.4): add permission related to motnioring and labelling on ns * fix(typo): variable name Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit c9aa358)
* chore(script): removes unused vars * chore: removes irrelevant docs (cherry picked from commit eaa564e)
Extracts the fluent interface for Features from PR opendatahub-io#605. This allows other components to configure cluster resources using this approach before the original PR gets merged. (cherry picked from commit adb6658)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 5de4fd2)
…datahub-io#688) (cherry picked from commit 95112ac)
…atahub-io#689) (cherry picked from commit d356d80)
…tahub-io#663) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 09c0785)
…hub-io#695) (cherry picked from commit 78041ea)
…pendatahub-io#687) * DSCc, DSCIc: move len > 1 check after getting first instance. In case of > 1 dataclusters installed report error condition in the kubernetes status which previously was only reported in the operator logs. Add DuplicateDataScienceCluster string constant for that. * DSCc, DSCIc: set status for > 1 DSCInitialization Repeat for DSCInitialization the same logic as for DataScienceCluster. The check is performed in both DSCInitialization and DataScienceCluster controllers. Fixes: opendatahub-io#644 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit 4e95d43)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 9ff16dd)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 023d6c4)
(cherry picked from commit 18b00eb)
* Unset Tech Preview components by default * Update default DSC and DSCI name (cherry picked from commit 1ccbe05)
remove extra spaces to make easier to copy & paste (cherry picked from commit ac8d56c)
(cherry picked from commit da25fa5)
- we covered the case when set component from Managed to Remvoe - this is to cover the case when set have component as Managed and delete DSC CR - so if we do not set at first it wont get deleted Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit e9461e0)
* Patch stale OauthClient resource * Fix DSCI Patch (cherry picked from commit 8dd0139)
- downstream: remove legacy prometheus and blackbox for upgrade - downstream: monitoring updates Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 82c2215)
* rbac: add permissions for imagestreams, daemonsets, apiservices Prepare for watching v1 resources (issue opendatahub-io#637) To enable watching for DaemonSet and APIService (REST api resources daemonsets and apiservices) reading/watching permissions required for the operator's role. Otherwise it gets errors like: ``` User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope E1018 20:00:55.374514 1 reflector.go:140] go/pkg/mod/k8s.io/client-go@v0.26.0/tools/cache/reflector.go:169: Failed to watch *v1.DaemonSet: failed to list *v1.DaemonSet: daemonsets.apps is forbidden: User "system:serviceaccount:openshift-operators:opendatahub-operator-controller-manager" cannot list resource "daemonsets" in API group "apps" at the cluster scope ``` For ImageStream `get` permissing is needed for cli.Get() in deploy's manageResources()[1], otherwise it does not set ownersReference (missing the branch apierrs.IsNotFound(err) since err is related to permissions). Autogenerated files: - config/rbac/role.yaml (make manifests) - bundle/manifests/opendatahub-operator.clusterserviceversion.yaml (make bundle) [1] https://github.com/opendatahub-io/opendatahub-operator/blob/13a7e822c0c75f361c319f8256a2d199d031d97c/pkg/deploy/deploy.go#L199 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * DSC controller: manage missing resources previously defined v1 Add the following resources to manage: - PersistentVolumeClaim - Service - DaemonSet - StatefulSet - DeploymentConfig - ImageStream - BuildConfig - CustomResourceDefinition - APIService - Ingress - MutatingWebhookConfiguration - ValidatingWebhookConfiguration - ServiceAccount It requires to add them to the scheme in main.go. Also `go mod tidy` is run to update modules information to make it buildable (keep bisectable). Autogenerated files: - go.mod - go.sum Closes: opendatahub-io#637 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit 91fe6f2)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 38b208d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes for 2.5 sprint
opendatahub-io#661
opendatahub-io#547
opendatahub-io#667
opendatahub-io#657
opendatahub-io#681
opendatahub-io#683
opendatahub-io#668
opendatahub-io#660
opendatahub-io#676
opendatahub-io#668
opendatahub-io#660
opendatahub-io#676
opendatahub-io#689
opendatahub-io#700
opendatahub-io#703
opendatahub-io#715
opendatahub-io#717
opendatahub-io#708
opendatahub-io#721
opendatahub-io#722
opendatahub-io#725
opendatahub-io#716
opendatahub-io#669
opendatahub-io#737