Skip to content

Commit

Permalink
chore(script): removes unused vars (opendatahub-io#683)
Browse files Browse the repository at this point in the history
* chore(script): removes unused vars

* chore: removes irrelevant docs
  • Loading branch information
bartoszmajsak authored Oct 31, 2023
1 parent c9aa358 commit eaa564e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ Each component is associated with its manifest location in the `COMPONENT_MANIFE
1. The script clones the remote repository `<repo-org>/<repo-name>` from the specified `<branch-name>`.
2. It then copies the content from the relative path `<source-folder>` to the local `odh-manifests/<target-folder>` folder.

In cases where components cannot directly use manifests from `opendatahub-io/<repo-name>`, the script defaults to the `opendatahub-io/odh-manifests` git repository.

The version of manifests fetched from `opendatahub-io/odh-manifests` is determined by the `MANIFEST_RELEASE` variable in the `get_all_manifests.sh` script.

#### Local Storage

The script utilizes a local, empty folder named `odh-manifests` to host all required manifests, sourced either directly from the component’s source repository or the default `odh-manifests` git repository.
Expand All @@ -84,7 +80,6 @@ If the flag name matches components key defined in `COMPONENT_MANIFESTS` it will
##### for local development

```
make get-manifests
```

Expand Down
5 changes: 0 additions & 5 deletions get_all_manifests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
set -e

GITHUB_URL="https://github.com/"
# update to use different git repo for legacy manifests
MANIFEST_ORG="opendatahub-io"
# comment out below logic once we have all component manifests ready to get from source git repo
MANIFEST_RELEASE="master"
MANIFESTS_TARBALL_URL="${GITHUB_URL}/${MANIFEST_ORG}/odh-manifests/tarball/${MANIFEST_RELEASE}"

# component: dsp, kserve, dashbaord, cf/ray. in the format of "repo-org:repo-name:branch-name:source-folder:target-folder"
# TODO: odh-mm-monitoring, etc
Expand Down

0 comments on commit eaa564e

Please sign in to comment.