Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(script): removes unused vars #683

Merged
merged 3 commits into from
Oct 31, 2023
Merged

chore(script): removes unused vars #683

merged 3 commits into from
Oct 31, 2023

Conversation

bartoszmajsak
Copy link
Contributor

@bartoszmajsak bartoszmajsak commented Oct 31, 2023 •
edited
Loading

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@bartoszmajsak bartoszmajsak requested review from zdtsw and VaishnaviHire and removed request for etirelli and LaVLaS October 31, 2023 13:54
@zdtsw
Copy link
Member

zdtsw commented Oct 31, 2023

can have https://github.com/maistra/opendatahub-operator/blob/get_manifests_cleanup/README.md#workflow updated?

@bartoszmajsak
Copy link
Contributor Author

can have maistra/opendatahub-operator@get_manifests_cleanup/README.md#workflow updated?

Done in c09dfa2

zdtsw
zdtsw approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 31, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zdtsw
Once this PR has been reviewed and has the lgtm label, please assign vaishnavihire for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw enabled auto-merge (squash) October 31, 2023 16:43
@zdtsw zdtsw merged commit eaa564e into opendatahub-io:incubation Oct 31, 2023
6 of 7 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 15, 2023
@bartoszmajsak @VaishnaviHire
chore(script): removes unused vars (opendatahub-io#683)
6dd78c3 
* chore(script): removes unused vars

* chore: removes irrelevant docs

(cherry picked from commit eaa564e)
@VaishnaviHire VaishnaviHire mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw approved these changes

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees

@zdtsw zdtsw

Labels
lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartoszmajsak @zdtsw