fix: ensures cluster-wide resources are removed during test cleanup #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements wait with timeout for DSCI to be actually deleted from the cluster as part of the test cleanup. Otherwise we might end up with DSCI not deleted yet when another test starts. This leads to failing/flaky tests.
|
Should merge automatically once #667 merges |
3 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AjayJagan, VaishnaviHire, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test opendatahub-operator-e2e |
|
@VaishnaviHire I updated the branch with your changes. Let's see if it passes now. Afterwards, we can squash-merge this commit. |
|
New changes are detected. LGTM label has been removed. |
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Nov 15, 2023
…pendatahub-io#674) Implements wait with timeout for DSCI to be actually deleted from the cluster as part of the test cleanup. Otherwise we might end up with DSCI not deleted yet when another test starts. This leads to failing/flaky tests. (cherry picked from commit e5bc958)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements wait with timeout for DSCI to be actually deleted from the cluster as part of the test cleanup.
Otherwise, we might end up with DSCI not deleted yet when another test starts. This leads to failing/flaky tests - see https://github.com/opendatahub-io/opendatahub-operator/actions/runs/6655639303/job/18086337958?pr=605 for example
How Has This Been Tested?
Merge criteria: