Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(namespace): for access dashboard #700

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 3, 2023

ref: #461

Description

How Has This Been Tested?

manually tested in Andriana's PSI cluster with OCP 4.10
Alex also helped to test this patch on his cluster with OCP 4.13

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Nov 3, 2023

/test opendatahub-operator-e2e

@zdtsw zdtsw merged commit 9ff16dd into opendatahub-io:incubation Nov 3, 2023
7 of 9 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 15, 2023
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 9ff16dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant