Recreate stale OauthClient resource #716
Conversation
VaishnaviHire
force-pushed
the
fix_oauthclient
branch
from
92fab51
to
456b2c7
Compare
VaishnaviHire
force-pushed
the
fix_oauthclient
branch
from
456b2c7
to
c536e81
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VaishnaviHire
force-pushed
the
fix_oauthclient
branch
from
c536e81
to
010042f
Compare
|
New changes are detected. LGTM label has been removed. |
|
/test opendatahub-operator-e2e |
1 similar comment
|
/test opendatahub-operator-e2e |
|
/retest |
|
strange error from yesterday: Account with ID 2DUeKzzTD9ngfsQ6YgkzdJn1jA4 denied access to perform create on Certificate with HTTP call POST /api/accounts_mgmt/v1/certificates"} |
* Patch stale OauthClient resource * Fix DSCI Patch (cherry picked from commit 8dd0139)
| @@ -73,7 +75,8 @@ func (d *Dashboard) GetComponentName() string { | |||
| // Verifies that Dashboard implements ComponentInterface. | |||
| var _ components.ComponentInterface = (*Dashboard)(nil) | |||
|
|
|||
| func (d *Dashboard) ReconcileComponent(cli client.Client, owner metav1.Object, dscispec *dsciv1.DSCInitializationSpec) error { | |||
| //nolint:gocyclo | |||
There was a problem hiding this comment.
@VaishnaviHire @zdtsw as I am merging 605 with incubation I came across this change and I am wondering what was the rationale behind disabling gocyclo linter in this particular case.
These tools play a crucial role in ensuring our code remains straightforward and accessible, especially for those who might be revisiting it after some time or are new to the codebase.
My concern is that bypassing these checks could lead to potential challenges in maintaining the project in the long run. I'm quite curious to understand the reasoning behind explicitly disabling this check. Was there a specific obstacle that prevented simplifying the code to comply with the linter? Maybe we can figure out together how to make this code simpler and benefit from linter complaints instead of keeping them silent? :)
Fixes #712
Description
How Has This Been Tested?
Merge criteria: