Sync servicemesh changes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold Needs #116 to be merged first |
…equisites (opendatahub-io#691) * Implement installation and configuration of KServe prerequisites KServe pre-requisites are: * Service Mesh (Istio) * A minimal Control Plane is configured for KServe with only Pilot and default gateways. * An additional knative: ingressgateway is set for the Istio Ingress gateway workload. * Some ports are excluded from envoy to allow for metrics collection and KNative hooks. * Metrics collection is configured for Pilot and the gateways. * Serverless (KNative) * Only serving components are needed from KNative. * For the most part, a typical Serving deployment is configured, with Istio as networking layer. * By default, a self-signed certificate is generated using the OpenShift Ingress domain. Users can provide their own secret with a production ready TLS certificate. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * chore: updates apis/dscinitialization/v1/servicemesh_types.go Co-authored-by: Cameron Garrison <cgarriso@redhat.com> * wip: serverless as part of kserve * chore: removes identitytype from CRD * feat: ensures that serverless config is removed when KServe is enabled * chore: checks if service mesh is configured when serving is enabled * fix: returns error on fail to remove serverless * chore(dsci): attempts to reduce test flakyness * chore: removes misleading TODO * Fix Dockerfile Add new COPY statement, due to the new `infrastructure` directory Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * chore: regenerates bundle --------- Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Cameron Garrison <cgarriso@redhat.com>
This disables automatic OpenShift routes creation. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> (cherry picked from commit 2c6f48c)
VaishnaviHire
force-pushed
the
sync_servicemesh_changes
branch
from
e029575
to
6c50824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes for Kserve integration with Servicemesh
feat(kserve): automates installation and configuration of KServe prerequisites opendatahub-io/opendatahub-operator#691
fix(ossm): disables service mesh routes generation opendatahub-io/opendatahub-operator#738
Defaults for New Installs