Removing `id` for default window #7

ghostoy · 2016-03-09T02:49:32Z

rogerwang · 2016-03-10T22:52:06Z

merged with the master patch.

… (patchset #7 id:100001 of https://codereview.chromium.org/1988813002/ ) Reason for revert: Other vendors didn't implement this yet. And work with the others to either get all to fix or to change the spec. BUG=614198 Original issue's description: > getComputedStyle should handle over-constrained properties. > > If neither 'left' nor 'right' is 'auto', the position is over-constrained, > and one of them has to be ignored. If 'direction' property of the > containing block is 'ltr', the value of 'left' wins and 'right' > becomes -'left'. If 'direction' of the containing block is 'rtl', > 'right' wins and 'left' is ignored. Detail is described by > https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning > > BUG=601118 > > Committed: https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05 > Cr-Commit-Position: refs/heads/master@{#394780} TBR=mstensho@opera.com,alancutter@chromium.org,rune@opera.com,eae@chromium.org,timloh@chromium.org BUG=601118 Review-Url: https://codereview.chromium.org/2016913003 Cr-Commit-Position: refs/heads/master@{#396470} (cherry picked from commit 9835ebf) Review URL: https://codereview.chromium.org/2025523002 . Cr-Commit-Position: refs/branch-heads/2743@{#116} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

…atchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )" This reverts commit 7017855. Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production. Fix the underlying crash problem and add new test: ImeMenuTrayTest.QuitChromeWithMenuOpen to cover it. TBR=jamescook@chromium.org NOPRESUBMIT=true NOTRY=true BUG=640432 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2277753006 Cr-Commit-Position: refs/heads/master@{#414819} (cherry picked from commit c6200ab) Review-Url: https://codereview.chromium.org/2288823004 Cr-Commit-Position: refs/branch-heads/2840@{#30} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

#7 id:260001 of https://codereview.chromium.org/2205623002/ ) Reason for revert: This CL caused some regressions regarding BWE stats and HW encoder performance. Reasons include: 1) Modifying scoped_refptr<media::VideoFrame>'s timestamp causes problems for other clients using the same media::VideoFrame. 2) WebRTC's RTP timestamp isn't suitable for using as presentation timestamp in Mac and Win HW encoders. BUG=641230 Original issue's description: > Use webrtc::VideoFrame timestamp in RTCVideoEncoder > > This CL fixes input timestamp mismatch in RTCVideoEncoder, which > broke googAvgEncodeMs and googEncodeUsagePercent stats in webrtc-internals > for hardware encoders. > With this change, we start using WebRTC given timestamp() so that > OveruseFrameDetector can match the timestamps and calculate the stats. > > BUG=597087 > TEST=googAvgEncodeMs and googEncodeUsagePercent works on Mac(H264) and > veyron_jerry(VP8). > > Committed: https://crrev.com/e3195490a63d9545fb1bfe560aa21680ba0b5843 > Cr-Commit-Position: refs/heads/master@{#414589} TBR=wuchengli@chromium.org,pbos@chromium.org,posciak@chromium.org BUG=597087 Review-Url: https://codereview.chromium.org/2296273002 Cr-Commit-Position: refs/heads/master@{#415752} (cherry picked from commit eb436dd) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2303053002 Cr-Commit-Position: refs/branch-heads/2840@{#110} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

BUG=666911 Review-Url: https://codereview.chromium.org/2513143002 Cr-Commit-Position: refs/heads/master@{#433358} (cherry picked from commit 8037248) Review URL: https://codereview.chromium.org/2511393003 . Cr-Commit-Position: refs/branch-heads/2924@{#7} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

Cr-Commit-Position: refs/branch-heads/2987@{#7} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

Test that the DataCompressionProxyLitePageFallback field trial requests Lo-Fi images when a Lite Page is not returned. Also check that when the user is not in the field trial, Lo-Fi images are not requested. Seperate the Lo-Fi and WebLite test files. BUG=660212 Review-Url: https://codereview.chromium.org/2726423003 Cr-Commit-Position: refs/heads/master@{#454724} (cherry picked from commit a9a7fa9) Review-Url: https://codereview.chromium.org/2729773007 . Cr-Commit-Position: refs/branch-heads/3029@{#7} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

…tion (patchset #7 id:120001 of https://codereview.chromium.org/2685723005/ ) Reason for revert: Changing this functionality improved spec conformance, but introduced regressions where text that used to be copied is no longer copied: crbug.com/695568 crbug.com/700163 A proposal to change the spec was made here: w3c/clipboard-apis#40 Original issue's description: > Make Editor::findEventTargetFrom() to align Clipboard API specification > > This patch changes |Editor::findEventTargetFrom()| to return focused element if > selection start is not editable to align Clipboard API specification[1] for > improving interoperability. > > [1] https://w3c.github.io/clipboard-apis/#to-fire-a-clipboard-event > > BUG=690104 > TEST=webkit_unittests --gtest_filter=ClipboardEventFlowTest.* > > Review-Url: https://codereview.chromium.org/2685723005 > Cr-Commit-Position: refs/heads/master@{#451716} > Committed: https://chromium.googlesource.com/chromium/src/+/7afbab0f7619c89aa7a5896024d1628a59cc0ef1 TBR=tkent@chromium.org,ojan@chromium.org,yosin@chromium.org,yutak@chromium.org,sigbjornf@opera.com,mwrobel@opera.com BUG=690104 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2745813002 Cr-Commit-Position: refs/heads/master@{#456232} (cherry picked from commit 0b5fb5f) Review-Url: https://codereview.chromium.org/2745353002 Cr-Commit-Position: refs/branch-heads/3029@{#179} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

Cr-Commit-Position: refs/branch-heads/3071@{#7} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

TBR=dimu@chromium.org Change-Id: I5da17ed4853f267db0e3d11c7b6ca0cb70fbcbdb Reviewed-on: https://chromium-review.googlesource.com/582172 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#7} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

This patch also disables MetricsCollectorTest on Windows because it failed on Win 7 dbg. This is a reland of f28e176 Original change's description: > Reland "Reland "[GRC] Add heuristics UKM and refactor MetricsCollector."" > > This is a reland of 6bc2eb1 > Original change's description: > > Reland "[GRC] Add heuristics UKM and refactor MetricsCollector." > > > > This is a reland of e31b0b4 > > Original change's description: > > > > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org > > > [GRC] Add heuristics UKM and refactor MetricsCollector. > > > > > > This patch: > > > 1. adds heuristics UKM; > > > 2. rafactors MetricsCollector to unify background tabs metrics report; > > > 3. moved metrics report 5-minutes timeout logic to MetricsCollector; > > > 4. adds more unit tests. > > > > > > BUG=731270, 753486 > > > > > > Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7 > > > Reviewed-on: https://chromium-review.googlesource.com/627594 > > > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > > Reviewed-by: Steven Holte <holte@chromium.org> > > > Commit-Queue: lpy <lpy@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#497900} > > > > Bug: 731270, 753486 > > Change-Id: I43c99c0cdc7c7d3431f08fae86cb10d6d87d99fa > > Reviewed-on: https://chromium-review.googlesource.com/640010 > > Reviewed-by: lpy <lpy@chromium.org> > > Commit-Queue: lpy <lpy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#498395} > > TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org > > Bug: 731270, 753486 > Change-Id: I65f2a5bc86e8ddd4af4b1739c306b6d1bc70b4b1 > Reviewed-on: https://chromium-review.googlesource.com/643568 > Commit-Queue: lpy <lpy@chromium.org> > Reviewed-by: lpy <lpy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#498965} TBR=chrisha@chromium.org,dcheng@chromium.org,holte@chromium.org Bug: 731270, 753486 Change-Id: I10d8a16821848c8896e054dad0185b368905dc6e Reviewed-on: https://chromium-review.googlesource.com/646533 Reviewed-by: lpy <lpy@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499148}(cherry picked from commit 85b2a0f) Reviewed-on: https://chromium-review.googlesource.com/648186 Cr-Commit-Position: refs/branch-heads/3202@{#7} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

TBR=dimu@chromium.org Change-Id: I1ef78c24921acb88f2b8880b927161591f756380 Reviewed-on: https://chromium-review.googlesource.com/720299 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#7} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

TBR=dimu@chromium.org Change-Id: I7d766582fd65a4662daca69b9dd6fb15615f484d Reviewed-on: https://chromium-review.googlesource.com/877422 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#7} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

TBR=dimu@chromium.org Change-Id: I4cd2dee0d349c4a1b657ad9fc37532cd137f84b9 Reviewed-on: https://chromium-review.googlesource.com/947772 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#7} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

TBR=dimu@chromium.org Change-Id: Icf4c267dc64e3579531b6d64d2352332657c1e9e Reviewed-on: https://chromium-review.googlesource.com/1012535 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#7} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

TBR=mmoss@chromium.org Change-Id: Ib020a2a2ee3a073b9492cca85c5467ef19456ef8 Reviewed-on: https://chromium-review.googlesource.com/1074347 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#7} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

TBR=mmoss@chromium.org Change-Id: Id12085394f0099bb89020b714c7167fa1c9943fa Reviewed-on: https://chromium-review.googlesource.com/1145850 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#7} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

1) Added legal message (clickable) to the offer dialog. 2) Added a Close Button which will be shown when the user clicks save button and the migration process lasts for more than 5 secs. 3) Modified ChromeAutofillClient to enable passing legal message to the LocalCardMigrationDialogControllerImpl. 4) Adjusted format/style of the dialog contents according to the mock: go/autofill-paradise. 5) Added an experiment flag (disabled by default) to control whether we want to show migration feedback to the user. Bug: 852904 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic0ca348fc689486a21d53a76921ee5954cb08295 Reviewed-on: https://chromium-review.googlesource.com/1192688 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587886}(cherry picked from commit 35d6e5b) Reviewed-on: https://chromium-review.googlesource.com/1199601 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3538@{#7} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

TBR=mmoss@chromium.org Change-Id: Iea1c8832f88e0db26686faff8b2dbeecc3ba9e98 Reviewed-on: https://chromium-review.googlesource.com/c/1279365 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#7} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

TableViewTextItem.textColor. The Canary crashes when a TableViewTextItem configures its cell and checks its "textColor" property, which is "assign" and might get released after assigned. This CL fixes it by changing the property's "assign" attribute to "strong" so that the UIColor object will be retained. Bug: 910542 Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b Reviewed-on: https://chromium-review.googlesource.com/c/1356585 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612716}(cherry picked from commit 17c608f) Reviewed-on: https://chromium-review.googlesource.com/c/1356809 Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#7} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

TBR=govind@chromium.org Change-Id: Id9a3f237122ff52b85a76758edf9d1f41ba89d58 Reviewed-on: https://chromium-review.googlesource.com/c/1437835 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#7} Cr-Branched-From: e510299-refs/heads/master@{#625896}

- The method GetRandomAvatarIconIndex() is updated to only use the modern avatar icon indices. - This CL also fixes the issue that the method returned indices out of range. (|rand| was wrongly initialized because the code assumed that base::RandInt(min,max) returns a value in [min, max).) Bug: 938707, 937834 Change-Id: Ief64906e83da83ec0e63db9cd6916a9a2bea0859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508264 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#638965}(cherry picked from commit 2ae0c680853e41bdb22fb7c128c93c29eaf910b4) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512633 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#7} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

Make the minimum SDK version for all components of Trichrome be Q, if we're building with the Q SDK. SDK28 builds of Trichrome are only for temporary testing and can be left alone until they're removed. TBR=torne@google.com (cherry picked from commit 4f4c5ff15edd97d29d55ea6fa195cac11a9b4a85) (cherry picked from commit 69d6a3ee54008ae116cbd355784c7b8e8e7a3c0a) Bug: 952383 Change-Id: I8e9bac555456868ccf414a56f499d03fd2d1ef34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566372 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#652207} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574883 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3769@{#7} Cr-Original-Branched-From: 80d72d8cd21cf76df583e29676b987ac1e3b90e9-refs/heads/master@{#651997} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577481 Cr-Commit-Position: refs/branch-heads/3729@{#905} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

chrome-tpm and others added 3 commits March 1, 2016 17:37

Publish DEPS for Chromium 49.0.2623.75

9909a1c

nwjs master

7fee480

Removing id for default window

6d6c9d7

Fixed nwjs/nw.js#4493

rogerwang force-pushed the nw13 branch from 7fee480 to ea112a8 Compare March 9, 2016 08:39

rogerwang closed this Mar 10, 2016

GnorTech pushed a commit that referenced this pull request Jan 29, 2017

Incrementing VERSION to 57.0.2987.5

4815b3f

Cr-Commit-Position: refs/branch-heads/2987@{#7} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

GnorTech pushed a commit that referenced this pull request Apr 26, 2017

Incrementing VERSION to 59.0.3071.5

564922a

Cr-Commit-Position: refs/branch-heads/3071@{#7} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing `id` for default window #7

Removing `id` for default window #7

ghostoy commented Mar 9, 2016

rogerwang commented Mar 10, 2016

Removing id for default window #7

Removing id for default window #7

Conversation

ghostoy commented Mar 9, 2016

rogerwang commented Mar 10, 2016

Removing `id` for default window #7

Removing `id` for default window #7