Use correct origin for chrome.desktopCapture.chooseDekstopMedia
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWJS app allows running on origins other than `chrome-extension://*/*`. The origin should then be from the senders URL, in order not to fail the origin checking in `DesktopStreamsRegistry::RequestMediaForStreamId`. Fixed nwjs/nw.js#4579
|
@rogerwang Please review |
ghostoy
pushed a commit
to ghostoy/nw.js
that referenced
this pull request
Mar 18, 2016
NWJS app allows running on origins other than `chrome-extension://*/*`. The origin should then be from the senders URL, in order not to fail the origin checking in `DesktopStreamsRegistry::RequestMediaForStreamId`. See also nwjs/chromium.src#11
rogerwang
force-pushed
the
nw13
branch
3 times, most recently
from
3a413b2 to
9f49374
Compare
|
merged with the master patch. |
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
canMakeActivePayment() is a proposed function on PaymentRequest object. Proposal: https://github.com/zkoch/zkoch.github.io/blob/master/pr-detect-avail.md Example usage: pr.canMakeActivePayment() .then(result => { if (result) return pr.show(); }) .catch(error => { console.log(error); }); When canMakeActivePayment() is called, Chrome stores the website origin and the payment methods that it's checking in memory. That's shared across the whole browser, in global state. (Not storing this on disk, so the user can clear this data via browser restart.) Then Chrome starts a timer for 30 minutes. When the timer fires, Chrome removes that origin and the payment methods that it was checking from the list. If the same origin tries to check different payment methods within the 30 minute window, Chrome rejects that request. If canMakeActivePayment() is rejected, then pr.show() can still be called regardless. Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/IoIxRpn6l9g/ux1C1Cj7AQAJ Tag review: w3ctag/design-reviews#146 OWP launch tracking bug: http://crbug.com/664619 Link to entry on the feature dashboard: https://www.chromestatus.com/feature/5702608073261056 The feature is behind chrome://flags/#enable-experimental-web-platform-features until it is approved to ship. BUG=662931,664619 Review-Url: https://codereview.chromium.org/2467393002 Cr-Commit-Position: refs/heads/master@{#433164} (cherry picked from commit 5132963) Review URL: https://codereview.chromium.org/2516923002 . Cr-Commit-Position: refs/branch-heads/2924@{#11} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
PermissionSelectorRow's preferred size is smaller than the width of the Page Info Bubble, so when a permission changes, resizing to the preferred size means that the row shrinks smaller than the other rows and the dropdown jumps around. Instead, simply call Layout() to do a fresh layout of the row. The parent()->SizeToPreferredSize() call is no longer necessary because WebsiteSettingsPopupView calls SizeToContents() when a permission is changed. Note that bug 655880 may want to reintroduce the PermissionSelectorRow::ChildPreferredSizeChanged override and propagate the change to WebsiteSettingsPopupView that way instead of via OnPermissionChanged, but it's not needed now -- and I'm guessing that, for that bug, PermissionSelectorRow::ChildPreferredSizeChanged may want to call parent()->PreferredSizeChanged(), rather than calling SizeToPreferredSize() (which assumes that the parent ought to be at its preferred size). BUG=657286 TEST=On Windows/Linux, visit https://google.com (or any other site) and open Page Info by clicking on the security indicator in the omnibox. Change a permission, change it again. Observe that the dropdown does not jump to the left of where it started. Review-Url: https://codereview.chromium.org/2647633002 Cr-Commit-Position: refs/heads/master@{#445017} (cherry picked from commit f24aa8a) Review-Url: https://codereview.chromium.org/2647173002 . Cr-Commit-Position: refs/branch-heads/2987@{#11} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
…pace. BUG=590095 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2727093002 Cr-Commit-Position: refs/heads/master@{#454522} (cherry picked from commit 3a2c466) Review-Url: https://codereview.chromium.org/2735643002 . Cr-Commit-Position: refs/branch-heads/3029@{#11} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
…spatcher Currently we create an IPC message for each URLLoaderClient call for code maintenanceability. This CL stops that for performance. BUG=710969 Review-Url: https://codereview.chromium.org/2814013004 Cr-Commit-Position: refs/heads/master@{#464646} (cherry picked from commit e45a888) Review-Url: https://codereview.chromium.org/2823803002 . Cr-Commit-Position: refs/branch-heads/3071@{#11} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang
pushed a commit
that referenced
this pull request
Jul 20, 2017
This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
TBR=dimu@chromium.org Change-Id: I721a6e8229e7989d7138feaff7b681ff14599568 Reviewed-on: https://chromium-review.googlesource.com/582979 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#11} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
Pre-emptively adding more strings for alternate UI. TBR=pkl@chromium.org (cherry picked from commit d2c811d) Bug: 755524 Change-Id: I680810a9e82bd537b2438fa32867c6aae541846f Reviewed-on: https://chromium-review.googlesource.com/647788 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499216} Reviewed-on: https://chromium-review.googlesource.com/648465 Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#11} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
Boxes without control clips don't necessarily have PaintLayers, so in the current code are not necessarily fragmented. (*) Such boxes should only end up in one fragment, because fragmenting input elements or buttons doesn't make sense. This patch computes the position of that fragment, and places the control clip at that location. (*) This is being changed in another much bigger patch, but this bugfix is needed for M63. TBR=chrishtr@chromium.org (cherry picked from commit 945b31d) Bug: 772850 Change-Id: I187d3dcf9c0dea2b7703dd759bf8b5f2886d4e2e Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/720200 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508952} Reviewed-on: https://chromium-review.googlesource.com/721759 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#11} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
GamepadSharedBuffer was internally creating an anonymous shared memory object, prohibiting the object from being sharable as anything other than read-write on some platforms. This CL corrects the situation. TBR=rockot@chromium.org (cherry picked from commit 5e56614) Bug: 803768 Change-Id: I122d71753be2dd02d12e5bb9f23c1bfc71623f34 Reviewed-on: https://chromium-review.googlesource.com/877042 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530670} Reviewed-on: https://chromium-review.googlesource.com/878020 Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#11} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
Currently in RenderWidgetHostInputEventRouter, we use TransformPointToCoordSpaceForView [1] to transform locations, which uses SurfaceHittest in normal chrome. We don't want to use SurfaceHittest in normal chrome and can't use SurfaceHittest in OOP-D. This CL changes to use HitTestQuery::TransformLocationForTarget instead. [1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_base.h?l=328 Bug: 811928 Test: site-per-process-hit-test-browsertests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie2ea51f0c12e17612aca17e322b592cdbdce5614 Reviewed-on: https://chromium-review.googlesource.com/917205 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540387}(cherry picked from commit 5650168) Reviewed-on: https://chromium-review.googlesource.com/949078 Reviewed-by: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#11} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
…ated transform If the SVG to border box transform or any other transform in SVG above <foreignObject> is non-identity, then hit testing of the <foreignObject> and content below it is incorrect, because it does not take into account such transforms. Before SPv175 + <foreignObject> as stacking context, content underneath the <foreignObject> did not paint with the correct sizing either, which hid this bug to some extent. To make this work requires a little bit of special-casing of foreignObject, because of the quirk that its location offset is applied *after* transform, not before. TBR=chrishtr@chromium.org (cherry picked from commit b19cea8) Bug: 820482,831591 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ided2b46f2ea12dd61c254892f5fbabb821f6229e Reviewed-on: https://chromium-review.googlesource.com/974568 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550825} Reviewed-on: https://chromium-review.googlesource.com/1012537 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#11} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
This reverts commit ea9f6b4. TBR=yawano@chromium.org Change-Id: Ie4d1134ef666d34b8554f259cffeb628f77fc5f1 Reviewed-on: https://chromium-review.googlesource.com/1075287 Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#11} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yC_UowCRnaY Spec: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addtransceiver This method is only supported if sdpSemantics:'unified-plan' is used, for more information see intent to ship which explains the background. In "Unified Plan", this creates a transceiver. Otherwise, this throws an kInvalidStateError. external/wpt/webrtc/ runs in default "Plan B" mode, virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ runs in "Unified Plan" mode. -expected.txt files are updated accordingly. If there is no -expected.txt file in "virtual" then it uses the same -expected.txt as the non-"virtual" if there is one; PASS-only files are needed in "virtual" if the non-"virtual" one contained any FAIL (as opposed to ommiting the -expected.txt file because everything passed). Most WPT uses addTransceiver(), so adding it made *A LOT* of tests that weren't running before either pass or run further and fail differently, hence the vast amount of -expected.txt files being changed. TBR=hbos@chromium.org (cherry picked from commit ab1bc90) Bug: 777617 Change-Id: Icb37e4f0934592f0e334a8f07f1dc1f55e2ca8f2 Reviewed-on: https://chromium-review.googlesource.com/1143478 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Florent Castelli <orphis@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576854} Reviewed-on: https://chromium-review.googlesource.com/1146568 Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#11} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
Before this CL, chrome://webrtc-logs/ only displayed textual logs. After this CL, event logs are also displayed. Bug: 775415 Change-Id: Iadfaf6173b118edb11641736b566c96b346c376e Reviewed-on: https://chromium-review.googlesource.com/1189483 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588145}(cherry picked from commit f1fab0c) Reviewed-on: https://chromium-review.googlesource.com/1201850 Reviewed-by: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#11} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
TBR=cmasso@chromium.org Change-Id: I8533086adc16b311a4d57575cd1ab85ebc35a6e0 Reviewed-on: https://chromium-review.googlesource.com/c/1279381 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#11} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
TBR=abdulsyed@chromiue.org Change-Id: I6d9502a815bc23bc1fe3aca10fc4e4c063a0ba66 Reviewed-on: https://chromium-review.googlesource.com/c/1358705 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#11} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
ImageChanged() is called immediately when a LayoutObject is added as an ImageObserver of a StyleImage. Previously LayoutBlock::ImageChanged() called FirstLineStyleRef() which would update the first line style cache which might be too early. Particulary, that caused re-entrance of AddClient() when we updated the pending image observer when the cache was updated. Now don't call FirstLineStyleRef() from LayoutBlock::ImageChanged(). Also added DCHECKs to ensure a LayoutObject calls StyleImage::AddClient() and StyleImage::RemoveClient() for exactly the same count. TBR=wangxianzhu@chromium.org (cherry picked from commit 735c7ad) Bug: 924457 Change-Id: Ib3f33febfbc591707e70813c7cb4add90ced7671 Reviewed-on: https://chromium-review.googlesource.com/c/1436881 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626182} Reviewed-on: https://chromium-review.googlesource.com/c/1437622 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#11} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
The current code only waits on a fence from either GL or the android framework depending on which was the last user of the buffer. However, if that buffer is used by both these APIs, we should be waiting on fences from both these consumers when releasing this buffer back to the AImageReader. Fix that. R=liberato@chromium.org, piman@chromium.org Bug: 889328 Change-Id: I03623aea03fc894362758ced490caeb3487d9f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506947 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639127}(cherry picked from commit 74931d3c037f45a14cc458aaa74174bc3f4340b3) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513044 Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#11} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NWJS app allows running on origins other than
chrome-extension://*/*.The origin should then be from the senders URL, in order not to fail
the origin checking in
DesktopStreamsRegistry::RequestMediaForStreamId.Fixed nwjs/nw.js#4579