Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nw15 mas #17

Open
wants to merge 10 commits into
base: nw15
Choose a base branch
from
Open

Nw15 mas #17

wants to merge 10 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented May 12, 2016

No description provided.

chrome-cron and others added 10 commits May 8, 2016 00:04
Publish DEPS for Chromium 51.0.2704.40
b962543
@rogerwang
nwjs master
940620e
Enabled sandbox support for MAS
2de20f4 
* fixed long socket file path issue
* used constant name for mach global lookup/checkin
Removed private API calls
25c11bb 
Removed private API calls according to a list of crbug:
https://bugs.chromium.org/p/chromium/issues/detail?id=496049

The following non-public APIs are reported:

'/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit'
: _NSAppendToKillRing
: _NSDrawCarbonThemeBezel
: _NSDrawCarbonThemeListBox
: _NSInitializeKillRing
: _NSNewKillRingSequence
: _NSPrependToKillRing
: _NSSetKillRingToYankedState
: _NSYankFromKillRing

'/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices'
: CGSSetDenyWindowServerConnections
: CGSShutdownServerConnections

‘/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation'
: _CFBundleLoadExecutableAndReturnError
: _CFURLCopyPropertyListRepresentation
: _CFURLCreateFromPropertyListRepresentation

'/usr/lib/libSystem.B.dylib'
: vproc_swap_complex # this one is not found in NW.js binary
Removed private API calls to xpc_*
eaaf5ab
Fix for "Anatomy of Framework Bundles" compatible
568e2b7 
Apple requires frameworks to be "versioned". Files in top folder
should be symblic links to it's current version folder (`Versions/Current`),
which is also a symbolic link to a real version in the same folder
(like `Versions/A`).
Removed app_mode_app
ba83f44
Fixed property list file for mac
2e1bdcd 
* Removed `CFBundleDocumentTypes` and `CFBundleURLTypes`
* Declared `*.nw` files being opened by NW.js
fix magic check fail in sandbox
e843b10
Fixed another sandbox failure
caf4633 
When using `const char* outer_app_dir_c = ....c_str()`, the local
variable finally points to a bad memory location within Mac Sandbox.
@rogerwang rogerwang force-pushed the nw15 branch 7 times, most recently from 8ef4420 to 96991b8 Compare May 19, 2016 02:42
@rogerwang rogerwang force-pushed the nw15 branch 3 times, most recently from 4f29938 to d5bd333 Compare May 24, 2016 23:08
@rogerwang rogerwang force-pushed the nw15 branch 5 times, most recently from f160e9d to 5c2963f Compare June 2, 2016 02:58
@rogerwang rogerwang force-pushed the nw15 branch 5 times, most recently from 801ca87 to 8770324 Compare June 12, 2016 02:53
@rogerwang rogerwang force-pushed the nw15 branch 4 times, most recently from 039b9bd to 2a42a57 Compare June 17, 2016 13:50
@rogerwang rogerwang force-pushed the nw15 branch 6 times, most recently from db31318 to b33fad2 Compare June 28, 2016 12:34
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
[ash-md] Allows ToggleButton to have a border and adds focus rectangle
7061f7f 
- Allows ToggleButton to accept a border set externally.
- Allows ToggleButton to have a tooltip that includes ThumbView.
- Adds TrayPopupUtils::CreateToggleButton to set up ToggleButtons for
  use in system menu.
- Uses TrayPopupUtils::CreateToggleButton in IME, Bluetooth and Network
  pages.

BUG=652492
TEST=manual
  Bring focus using Tab to a toggle button in Network detailed page.
  (focus rectangle appears).
  Press Space (toggle switches)
  Press Enter (toggle switches)
  Tab (focus switches to the next row).

Review-Url: https://codereview.chromium.org/2506133003
Cr-Commit-Position: refs/heads/master@{#433386}
(cherry picked from commit 9bd7f8c)

Review URL: https://codereview.chromium.org/2520793002 .

Cr-Commit-Position: refs/branch-heads/2924@{#17}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
@sammc
Retrieve NTP thumbnail URLs from the right frame
bda82aa 
The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749

Review-Url: https://codereview.chromium.org/2646133003
Cr-Commit-Position: refs/heads/master@{#445072}
(cherry picked from commit 73a0a96)

Review-Url: https://codereview.chromium.org/2649833002 .
Cr-Commit-Position: refs/branch-heads/2987@{#17}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
Add WebView-specific whitelist for crash keys.
d125f5a 
WebView shouldn't upload data representing all crash keys declared by
Chrome since some of that data could be private.
To be able to re-use the existing crash-keys mechanism we here add a
WebView-only whitelist that will be applied at the time data is set for
a key, rather than at registration time.
In this way we ensure that all keys that are being set are also being
registered, while allowing WebView to avoid adding all registered keys.

BUG=691560

Review-Url: https://codereview.chromium.org/2717223003
Cr-Commit-Position: refs/heads/master@{#454611}
(cherry picked from commit 59b1a9c)

Review-Url: https://codereview.chromium.org/2734823002 .
Cr-Commit-Position: refs/branch-heads/3029@{#17}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@hiroshige-g
Revert of Rename PendingScript::Url() to UrlForClassicScript() (patch…
4ef50c3 
…set #1 id:1 of https://codereview.chromium.org/2815163005/ )

Reason for revert:
https://codereview.chromium.org/2653923008/ is
suspected to cause CHECK() failure (crbug.com/711703)
inside PendingScript's prefinalizer.

BUG=711703

Original issue's description:
> Rename PendingScript::Url() to UrlForClassicScript()
>
> Because it is/can be used only for classic scripts.
>
> BUG=686281
>
> Review-Url: https://codereview.chromium.org/2815163005
> Cr-Commit-Position: refs/heads/master@{#464613}
> Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0

TBR=kouhei@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686281

Review-Url: https://codereview.chromium.org/2822763002
Cr-Commit-Position: refs/heads/master@{#464766}
(cherry picked from commit 476b2ca)

Review-Url: https://codereview.chromium.org/2826493002 .
Cr-Commit-Position: refs/branch-heads/3071@{#17}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang pushed a commit that referenced this pull request Jul 17, 2017
Media Galleries: Fix render-frame-host gone case in GetMetadata call
0006b51 
Sometimes, the render frame host goes away before
the MediaGalleries GetMetadata call completes per
the comment #17 on crbug.com/673459

BUG=673459
TEST=could not reproduce the crash locally but the fix makes sense logically
TBR=satorux@chromium.org

(cherry picked from commit 3afaca4)

Review-Url: https://codereview.chromium.org/2971763002
Cr-Original-Commit-Position: refs/heads/master@{#484418}
Change-Id: Ib97b1a38c6837d485fa0a3f182f2fe7bc52f4c6f
Reviewed-on: https://chromium-review.googlesource.com/569199
Reviewed-by: Satoru Takabayashi <satorux@google.com>
Cr-Commit-Position: refs/branch-heads/3112@{#602}
Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
rogerwang pushed a commit that referenced this pull request Jul 20, 2017
Revert "Listen to changes to touch input devices"
6b860e9 
This reverts commit 1b60006.

Reason for revert:
Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash.

Failing build (chromeos-side waterfall):
https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205

Stack (from running manually with chrome --mash on Linux):

[60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created.
#0 0x7f06a03468bc base::debug::StackTrace::StackTrace()
#1 0x7f06a036a121 logging::LogMessage::~LogMessage()
#2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance()
#3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl()
#4 0x55f1834066ad chromeos::ShowLoginWizard()
#5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize()
#6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit()
#7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun()
#9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun()
#11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow()
#12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks()
#13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize()
#14 0x7f069d9e0b57 content::BrowserMain()
#15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run()
#16 0x7f06a0890d39 service_manager::Main()
#17 0x7f069e1e7384 content::ContentMain()
#18 0x55f182e8132f ChromeMain
#19 0x7f069454af45 __libc_start_main
#20 0x55f182e81194 <unknown>

Original change's description:
> Listen to changes to touch input devices
>
> In https://codereview.chromium.org/2964823002 the OobeDisplayChooser
> started using the DeviceDataManager to look for touchscreen devices when
> searching for a good primary display to use during OOBE.
>
> On device cold boot the DeviceDataManager has not yet found any
> touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely
> due to lower level systems not being fully initialized).
>
> This CL make LoginDisplayHostImpl an observer of changes to connected
> touchscreen devices, re-triggering the OobeDisplayChooser when the
> DeviceDataManager is notified of the connected touchscreens. This
> overcomes the timing issues on cold boot.
>
> Bug: 738885
> Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd
> Reviewed-on: https://chromium-review.googlesource.com/569958
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487007}

TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit 0cd134a)

Bug: 738885
Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4
Reviewed-on: https://chromium-review.googlesource.com/574731
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487191}
Signed-off-by: Bernie Thompson <bhthompson@google.com>
Reviewed-on: https://chromium-review.googlesource.com/575149
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#623}
Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Remove the --disable-native-cups flag.
50c8bed 
Native CUPS has been turned on since M59 and it has settled well.
The flag to turn it off is being removed.  Also clean up code that is
now extraneous.

TBR=skau@chromium.org

(cherry picked from commit 80e92e7)

Bug: 733793
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I351790c7f8f0a486743e190355af7922b0105676
Reviewed-on: https://chromium-review.googlesource.com/575829
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488695}
Reviewed-on: https://chromium-review.googlesource.com/583480
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#17}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@beccahughes
Media Engagement: Disable syncing of MEI data.
ec23cad 
Disable syncing on MEI data due to the conflicts bug. Also
increase the schema version to wipe any corrupt data.

BUG=760956

Change-Id: I6e428c2e07b5448be4656442f4b04563370bd124
Reviewed-on: https://chromium-review.googlesource.com/645977
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499210}(cherry picked from commit 71806d6)
Reviewed-on: https://chromium-review.googlesource.com/647449
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#17}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@ccameron-chromium
Revert "hdr: Don't use angle D3D11Device to query HDR"
34384e5 
This reverts commit f21e201.
Bug:774323

Reason for revert: Broke layout tests on Win7.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56507

Original change's description:
> hdr: Don't use angle D3D11Device to query HDR
>
> The HDR state is snapshotted at the time that the D3D11Device is
> created. This needs to return the most up to date value every time that
> it is called.
>
> Also remove the ENABLE_HDR_DETECTION guard since it's no longer needed.
>
> OldBug: 682416
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I8b6b05f077309dbf58fcc189e2fb36b3a8d3c2c3
> Reviewed-on: https://chromium-review.googlesource.com/714495
> Commit-Queue: ccameron chromium <ccameron@chromium.org>
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508423}

TBR=ccameron@chromium.org, geofflang@chromium.org, yhirano@chromium.org, zmo@chromium.org

(cherry picked from commit 690c132)

Change-Id: I811f2ee5fd08a109a530049bd734746a9187c905
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
OldBug: 682416
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/716937
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508580}
Reviewed-on: https://chromium-review.googlesource.com/721738
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#17}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@agrieve
Revert "Android: Simplify DeviceFormFactor.isTablet()"
91e6189 
This reverts commit d875cac.

Reason for revert:  Probably causing other crashing (see bug)

Original change's description:
> Android: Simplify DeviceFormFactor.isTablet()
>
> Rather than provide a setIsTablet(), just move the resource from
> chrome->ui and have DeviceFormFactor use it directly.
>
> Change-Id: Ie867fc604aa223a6c4896124e3dfe80c09675593
> Reviewed-on: https://chromium-review.googlesource.com/769348
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518274}

TBR=agrieve@chromium.org, tedchoc@chromium.org, twellington@chromium.org, yfriedman@chromium.org


(cherry picked from commit c258ff1)

Bug: 794551
Change-Id: Iec913f6b1d36f188326cb0f0b8a52138c8a3b456
Reviewed-on: https://chromium-review.googlesource.com/876262
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530545}
Reviewed-on: https://chromium-review.googlesource.com/879084
Cr-Commit-Position: refs/branch-heads/3325@{#17}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@stevenjb
Network config: Explicitly show save or connect
0a4513a 
Using the configured and saved state of a network to determine whether
to show 'Save' or 'Connect' was not always correct; instead let the UI
determine which button to show.

Also includes a minor improvement to the error messaging.

TBR=stevenjb@chromium.org

(cherry picked from commit 6cf2476)

Bug: 814939
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifb9a854826a3e4f45c17cb22ef03ed6b23c6f58c
Reviewed-on: https://chromium-review.googlesource.com/943922
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540624}
Reviewed-on: https://chromium-review.googlesource.com/949967
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#17}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Incrementing VERSION to 67.0.3396.6
d903b05 
TBR=dimu@chromium.org

Change-Id: I446b46ca961468caea1ed3124b9f9eab860c4c51
Reviewed-on: https://chromium-review.googlesource.com/1014240
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#17}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
@tapted
[merge m68] MacViews: Harden MenuRunnerImplCocoa against an obscure A…
b19993c 
…ppKit lifetime issue

If a toolkit-views MenuRunner is destroyed while a menu is open, the
menu is closed. Often this occurs because the ui::MenuModel is also about
to be destroyed. Normally this is fine.

However, if an event has already been generated by the user to select
a menu item, which hasn't yet been processed by the event queue, it's
possible for a retained NSMenu to still have access to the ui:MenuModel
raw pointer via its delegate (the Cocoa MenuController), causing an error.

To fix, reset the MenuController when a MenuRunnerImplCocoa is released
in this way. MenuRunnerImplCocoa has the only reference to MenuController
so this will cause its -[MenuController dealloc] to clear itself as a
delegate of the NSMenu it's still showing.

Adds MenuRunnerImplCocoa.MenuRunnerImplCocoa which tickle the asan
bots without the fix.

TBR=tapted@chromium.org

(cherry picked from commit 9cbd880)

Bug: 823373
Change-Id: I9fc08108569a80f6b1c279f4eeef89f4a14d9dcf
Reviewed-on: https://chromium-review.googlesource.com/1071275
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561736}
Reviewed-on: https://chromium-review.googlesource.com/1075829
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#17}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@tim-loh @pbos
Revert "Match security chip visibility with focus ring"
3c83f32 
This reverts commit 26399bc.

Reason for revert: OmniboxViewViewsTest.SelectAllOnTabToFocus is Flaky

Original change's description:
> Match security chip visibility with focus ring
>
> Instantly hides or shows the IconLabelBubbleView separator when focus
> rings are available to prevent showing the separator when a focus ring
> overlaps it.
>
> Bug: chromium:865029
> Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99
> Reviewed-on: https://chromium-review.googlesource.com/1142442
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576358}

TBR=pbos@chromium.org,bsep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 865029, 866230
Change-Id: I30372e90c1613b33690b43dd28fbe151abddddef
Reviewed-on: https://chromium-review.googlesource.com/1146421
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577110}(cherry picked from commit e722946)
Reviewed-on: https://chromium-review.googlesource.com/1147081
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#17}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@alancutter
Update hosted app origin text animation
3a090fd 
This CL updates the opening animation for hosted app titlebars to
match recent UI mocks by:
 - Removing the slide motion but retain the fade animation of the
   origin text.
 - Making the origin text bold.
 - Synchronising the fade durations of the origin text and app menu
   button highlight.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1

This CL only includes the minimal changes needed to update the
animation to be suitable for merging to M70. Further code clean
ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1

Bug: 878187
Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc
Reviewed-on: https://chromium-review.googlesource.com/1192463
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588223}(cherry picked from commit 1375b6e)
Reviewed-on: https://chromium-review.googlesource.com/1203511
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#17}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
CrOS shelf: permanent background behind back + launcher buttons
7b6d332 
Replace the logic in ShelfView's overridden OnPaint with a simpler
view and rounded corners.

You can see a screenshot in comment #17 of the linked bug.

TBR=manucornet@chromium.org

(cherry picked from commit 80db7d2)

Bug: 874161
Change-Id: I416e670ca578e6fd5d4e7681c8c19acf2fa17c3a
Reviewed-on: https://chromium-review.googlesource.com/1198525
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588220}
Reviewed-on: https://chromium-review.googlesource.com/1213515
Cr-Commit-Position: refs/branch-heads/3538@{#159}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
[Tango->FCM] Do not perform bulk unregistering on shutdown and on han…
8f6a554 
…dler unregistering.

* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown

TBR=gab@chromium.org, melandory@chromium.org, pavely@chromium.org

(cherry picked from commit 5c8b5d9)

Bug: 894752, 801985
Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
Reviewed-on: https://chromium-review.googlesource.com/c/1277908
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599206}
Reviewed-on: https://chromium-review.googlesource.com/c/1280202
Cr-Commit-Position: refs/branch-heads/3578@{#17}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@jdoerrie
[Autofill Home] Show Google Account Link for Signed-In Users
03f0beb 
This change updates the people section to show a link to the Google
Account in case the current user is signed-in.

Bug: 907035
Change-Id: I51a5d4df2563a1c646377abba74d810f7a24a426
Reviewed-on: https://chromium-review.googlesource.com/c/1346049
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612836}(cherry picked from commit 888f7df)
Reviewed-on: https://chromium-review.googlesource.com/c/1358639
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#17}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
NQE: Cap effective connection type when cell signal strength is low
f5610c7 
In Network Quality Estimator (NQE), start an experiment to
cap the value of the Effective Connection Type (ECT) when
the signal strength is low. Currently, NQE computes ECT based
on the observed RTT of the network traffic. This CL adds a mechanism
to modify ECT on connections expected to be slower without waiting
for the network traffic to take the full RTT.

Change-Id: I271aa0e461b4de96d8b33dd87c6a9e23298fadf9
Bug: 924160
Reviewed-on: https://chromium-review.googlesource.com/c/1420270
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626184}(cherry picked from commit b361d98)
Reviewed-on: https://chromium-review.googlesource.com/c/1439296
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#17}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
[getUserMedia] Do not read experimental flag to determine system EC o…
ee53471 
…n source.

During the rewrite in r617125, the code was changed so that in the case
of LocalMediaAudioSource the EC type would be inferred from both system
and experimental system EC bits in the device effects. This is, however,
incorrect, as the code previously was only looking at the system EC
effects bit.

This CL fixes this incorrect behavior and adds a test that guards for
future similar mistakes.

BUG=939328
TESTED=verified that the test fails without the fix.

Change-Id: I16c572c0f0092aefa06311e890aa796b7ebeb2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511458
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639037}(cherry picked from commit 529ef63b43f2cadd7690c242a51780a766ac8b67)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513712
Cr-Commit-Position: refs/branch-heads/3729@{#17}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostoy @rogerwang