[win] Update with correctly resized icons #14

ghostoy · 2016-04-07T02:37:48Z

rogerwang · 2016-04-07T02:48:16Z

merged into the master patch.

…ed content value (patchset #14 id:260001 of https://codereview.chromium.org/1812763002/ ) Reason for revert: BUG=609848 A lot of sites in production are depending on content returning an empty string. Original issue's description: > Pseudo and non pseudo elements should return correct computed content value > > This patch makes sure that content computes to "normal" for elements > (not pseudo elements) and to "none" if the specified value of pseudo > elements ::before and ::after is "normal." > > This patch makes us interoperable with all other browsers for the > case of pseudo elements :before and ::after where the specified value > is "normal". > > With regards to non psuedo elements we are now interoperable with IE > and the spec and return "normal" for the computed content all all non > psuedo elements. > Other browsers are inconcistent on this behaviour: > 1. Edge returns an empty string for non pseudo elements > 2. FF returns none for non pseudo elements. > > The spec implemented is given here: > https://drafts.csswg.org/css2/generate.html#content > > BUG=597500 > > Committed: https://crrev.com/aaeefae6c3a945e7fcfef382c3a82002ffae0e19 > Cr-Commit-Position: refs/heads/master@{#383949} TBR=alancutter@chromium.org,timloh@chromium.org BUG=597500 Review-Url: https://codereview.chromium.org/1977323002 Cr-Commit-Position: refs/heads/master@{#394729} (cherry picked from commit bd9df7c) Review URL: https://codereview.chromium.org/2021163002 . Cr-Commit-Position: refs/branch-heads/2704@{#681} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}

This prevents flickering when the font is first displayed. BUG=657340 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2509593007 Cr-Commit-Position: refs/heads/master@{#433071} (cherry picked from commit 505f6aa) Review URL: https://codereview.chromium.org/2520763002 . Cr-Commit-Position: refs/branch-heads/2924@{#14} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

Cr-Commit-Position: refs/branch-heads/2987@{#14} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

ArcDocumentsProviderWatcherManager simply calls ArcDocumentsProviderRoot. BUG=chromium:684233 TEST=trybot TEST=Media view refreshes on media provider changes. Review-Url: https://codereview.chromium.org/2709013003 Cr-Commit-Position: refs/heads/master@{#454598} (cherry picked from commit 7b44260) Review-Url: https://codereview.chromium.org/2736613002 . Cr-Commit-Position: refs/branch-heads/3029@{#14} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

…hset #14 id:280001 of https://codereview.chromium.org/2692813002/ ) Reason for revert: Broke MSAN https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/698 Is enable_server_push_cancellation initialized? Original issue's description: > Server push cancellation: add a finch trial parameter > "enable_server_push_cancellation" to control the feature of server push > cancellation. Create a HttpCacheLookupManager in HttpCache's constructor > and set it to HttpNetworkSession which will set it thru reaching > QuicChromiumClientSession and SpdySession. > > BUG=232040 > > Review-Url: https://codereview.chromium.org/2692813002 > Cr-Commit-Position: refs/heads/master@{#454457} > Committed: https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7a8cd805f13e8 R=rch@chromium.org TBR=ckrasic@chromium.org, rch@chromium.org, zhongyi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=232040 Review-Url: https://codereview.chromium.org/2730053002 Cr-Commit-Position: refs/heads/master@{#454554} (cherry picked from commit cfb060c) Review-Url: https://codereview.chromium.org/2751623002 . Cr-Commit-Position: refs/branch-heads/3029@{#187} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

This will inform whether we can make the change suggested in w3c/fxtf-drafts#11 BUG=711736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2817583006 Cr-Commit-Position: refs/heads/master@{#464853} (cherry picked from commit e208bf0) Review-Url: https://codereview.chromium.org/2821943002 . Cr-Commit-Position: refs/branch-heads/3071@{#14} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

TBR=dimu@chromium.org Change-Id: I30052271c827530ced804a616c14d277e06060c4 Reviewed-on: https://chromium-review.googlesource.com/583639 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#14} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

TBR=dimu@chromium.org Change-Id: I05e3e4722f6699d807d73f2d9507faede8691000 Reviewed-on: https://chromium-review.googlesource.com/648683 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#14} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

…antheon > CL [1] fixed a bug where Chrome wouldn't add any frame buttons on a > maximized browser window. The Unity desktop environment draws these > buttons for us in the top menu bar for maximized windows, so we only > disabled these buttons on the Unity DE. > > However, we were also pretending that the Pantheon DE (used on > ElementaryOS) was Unity, so that libappindicator would work. This CL > adds Pantheon as a new base::DesktopEnvironment to solve both of these > issues. > > [1] https://crrev.com/0960ecfad7787c492f407054c9a9ba1b7134ef5d > > BUG=773233 > R=sky@chromium.org > CC=erg@chromium.org > > Change-Id: If66f748e69c202d09c9ed6dfc0490bb2ce0d5609 > Reviewed-on: https://chromium-review.googlesource.com/717479 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508792} TBR=sky@chromium.org BUG=773233 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Change-Id: I176e570a04d76970830d6ebbf9b1c2cb3f4d2888 Reviewed-on: https://chromium-review.googlesource.com/721694 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#14} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

TBR=dimu@chromium.org Change-Id: I48fa96ce32e0336ebbe376f20ffbc9fe2fb9dbe7 Reviewed-on: https://chromium-review.googlesource.com/878060 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#14} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

…dow bounds changes: When arc window is moved to a workspace, ensure 26 DIPs window visibility. TBR=oshima@chromium.org TBR=reveman@chromium.org (cherry picked from commit 968c8d2) Bug: 806094 Test: device test and added test coverage Change-Id: I498d468d0e1767f62426f6e896992aaee33eeb83 Reviewed-on: https://chromium-review.googlesource.com/930661 Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Original-Commit-Position: refs/heads/master@{#540630} Reviewed-on: https://chromium-review.googlesource.com/949411 Reviewed-by: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/branch-heads/3359@{#14} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

When the context is closing, the nodes that were processing their tails need to be stopped. This disables the output of the node, which might cause other nodes to disable their outputs, and these nodes are placed on |finished_tail_processing_handlers_|. These also need to be handled when finishing tail processing. So loop around processing |finished_tail_processing_handlers_| and |tail_processing_handlers_| until disabling of outputs no longer adds anything to either of these. Bug: 832043, 828826 Test: run-webkit-tests --enable-leak-detection no longer detects leaks Change-Id: I6ca195352b240d343095c208c9b70b0c5553c925 Reviewed-on: https://chromium-review.googlesource.com/1010833 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550468}(cherry picked from commit cecfc61) Reviewed-on: https://chromium-review.googlesource.com/1014164 Reviewed-by: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#14} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

…in DOM tree This is a workaround for crbug.com/845849. In some buggy cases, we get ComputeVisibleSelectionInFlatTree() returning non-null, but ComputeVisibleSelectionInDOMTree() returning null. This makes FrameSelection::Contains() return true erroneously. As we don't have a fix to the inconsistency, this patch adds a workaround that, we call ComputeVisibleSelectionInDOMTree() first to set the cached VisibleSelections to null also for flat tree, so that the following computation does not work on a non-null VS in flat tree erroneously. Bug: 845849 Change-Id: I7255d8224b8b6e29d479dd635e2c4ee99b366fc1 Reviewed-on: https://chromium-review.googlesource.com/1072924 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561775}(cherry picked from commit b6f6b01) Reviewed-on: https://chromium-review.googlesource.com/1075707 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#14} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

This reverts commit 6bb055b. Reason for revert: P0 bug https://crbug.com/865882 Original change's description: > tools/luci-go: remove old way of mapping isolate > > It's now only mapped via CIPD, which is the right solution going forward. > > Bug: 851596,865541 > Change-Id: I25ddd0e059c818fafbc5587b06ff35b6c733a16e > Reviewed-on: https://chromium-review.googlesource.com/1143448 > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576550} TBR=maruel@chromium.org,tandrii@chromium.org,jbudorick@chromium.org Change-Id: I2d432e9c80379c41e22b7a1cfdb4ea3f54586baa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851596, 865541, 865882 Reviewed-on: https://chromium-review.googlesource.com/1145020 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576823}(cherry picked from commit 31d0faa) Reviewed-on: https://chromium-review.googlesource.com/1146841 Reviewed-by: John Budorick <jbudorick@google.com> Cr-Commit-Position: refs/branch-heads/3497@{#14} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

https://crrev.com/c/1180637 introduced a regression on the simplified NTP. TextView in native page has a sizing issue when View#layout() is invoked in unattached state. This CL makes layout not performed in the corresponding state. TBR=tedchoc@chromium.org, twellington@chromium.org Bug: 876686 Change-Id: I81eff601781ec85e398ccc4d1ce555c441e20ddb Reviewed-on: https://chromium-review.googlesource.com/1189682 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587916}(cherry picked from commit 2db4f03) Reviewed-on: https://chromium-review.googlesource.com/1203470 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#14} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

TBR=cmasso@chromium.org Change-Id: I478e4bad53d4891c3a0b300f4bd32bfe8ec4497f Reviewed-on: https://chromium-review.googlesource.com/c/1280043 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#14} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

…tates. Otherwise if there is a commit request and we early out due to being invisible before commiting, and we set the max+requested_pipeline_stage_ to NO_PIPELINE_STAGE, then that commit is lost. For flash this results in a commit never receiving callback, and the next commit can never be requested, thus rendering is stalled. BUG=890008 TEST=cc_unittests R=piman@chromium,enne@chromium.org,danakj@chromium.org Change-Id: I240be7bb5496f28c0217ee7ef86533509bafcd16 Reviewed-on: https://chromium-review.googlesource.com/c/1343048 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: enne <enne@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612872}(cherry picked from commit 5b30cf3) Reviewed-on: https://chromium-review.googlesource.com/c/1359312 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#14} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

When connecting touch devices via a USB-C cable, the touch-display pairing may fail. This happens specifically when multiple external displays are connected. The only way to resolve this is by performing a manual calibration. The default heuristic that pairs touch controllers and displays connected via the USB fails since the display is actually connected via the display link interface rather than the USB. The display is thus listed as an evdi device when the pairing happens. This patch changes the way we identify USB devices and lists evdi displays as USB displays instead. Bug: 925211 Change-Id: I2568d41360f6f23465fd28314d5602f29f562204 Component: Touch device manager, evdi, usb, pairing Reviewed-on: https://chromium-review.googlesource.com/c/1435758 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626169}(cherry picked from commit aae861b) Reviewed-on: https://chromium-review.googlesource.com/c/1439015 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#14} Cr-Branched-From: e510299-refs/heads/master@{#625896}

…e session starts I've been using Eve and Samus to test this feature, but things on Nocturne look different: it's not uncommon to run into crbug.com/934979 on a Nocturne. The screensaver often launches behind the login screen, and if we remove splash screen at this point, then login screen is still shown for about 1-2 sec. We could consider postpone launching the screensaver until login screen is destroyed (i.e. session state changes to ACTIVE), but I'm not sure how complex it is to ensure the web store and the Chrome code stay in sync. Bug: 894270 Change-Id: I3a995f4a04257ee12c0e444231368cf4ed773db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510053 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#638948}(cherry picked from commit cf27d3aeff7379fc2b8b19cab46e3002f0b73416) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513049 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#14} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

rogerwang and others added 2 commits April 5, 2016 14:00

nwjs master

85c8bc4

[win] Update with correctly resized icons

4c78978

Fixed nwjs/nw.js#4649

ghostoy mentioned this pull request Apr 7, 2016

Custom app icon with incorrect size under volume mixer nwjs/nw.js#4649

Closed

rogerwang force-pushed the nw13 branch from 85c8bc4 to 53ac9e0 Compare April 7, 2016 02:48

rogerwang closed this Apr 7, 2016

GnorTech pushed a commit that referenced this pull request Jan 29, 2017

Incrementing VERSION to 57.0.2987.6

4541b06

Cr-Commit-Position: refs/branch-heads/2987@{#14} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[win] Update with correctly resized icons #14

[win] Update with correctly resized icons #14

ghostoy commented Apr 7, 2016

rogerwang commented Apr 7, 2016

[win] Update with correctly resized icons #14

[win] Update with correctly resized icons #14

Conversation

ghostoy commented Apr 7, 2016

rogerwang commented Apr 7, 2016