Use package name as WM_CLASS #15

ghostoy · 2016-04-11T08:34:22Z

This patch fixed the name in top bar of GNOME.

This patch fixed the name in top bar of GNOME. Fixed nwjs/nw.js#4693

rogerwang · 2016-04-11T08:48:31Z

merged into the master patch.

(patchset #15 id:360001 of https://codereview.chromium.org/1849153003/ ) Reason for revert: Caused crashes: https://crbug.com/612815. Reopening the browser from a notification unregisters the notification's keepalive before creating the new browser window, so we get in situations where we try opening a new browser while the shutdown sequence is started. Original issue's description: > [bgmode] Make push notifications register KeepAlives > > A KeepAlive is now registered in the following cases: > a) There is an in-flight push message > b) A Notification is being shown by the message center > > That will happen on all platforms supporting Chrome's > background mode. > > BUG=585080 > > Committed: https://crrev.com/f43094f56012798a8bb0144b0e17076abc8c8dd0 > Cr-Commit-Position: refs/heads/master@{#394194} TBR=peter@chromium.org,sky@chromium.org NOTRY=true NOPRESUBMIT=true BUG=612815 patch from issue 2020563003 at patchset 1 (http://crrev.com/2020563003#ps1) Review-Url: https://codereview.chromium.org/2016393002 Cr-Commit-Position: refs/branch-heads/2743@{#103} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

…0001 of https://codereview.chromium.org/2453813004 ) Reason for revert: Top canary crasher https://bugs.chromium.org/p/chromium/issues/detail?id=666227 Original issue's description: > WebFonts cache-aware timeout adaptation > > This CL introduces adaptive webfont display behavior, reducing unnecessary Flash > of Unstyled Text (FOUT) if webfont is already available in disk cache. This is > available as a experimental Web Platform feature. > > In webfont display, fallback font will be used if webfont loading time exceeds > certain timeout values in slow network. However it's observed that disk cache > RTT may also hit the timeout regardless of network speed. In such cases we would > like to block display until disk cache misses and actual network request is > being sent. > > BUG=570205 > Committed: https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e > Cr-Commit-Position: refs/heads/master@{#432425} TBR=shaochuan@chromium.org,tkent@chromium.org,ksakamoto@chromium.org,isherman@chromium.org,yhirano@chromium.org BUG=666227,570205 Review-Url: https://codereview.chromium.org/2512773002 Cr-Commit-Position: refs/heads/master@{#433067} (cherry picked from commit 9112036) Review URL: https://codereview.chromium.org/2511783004 . Cr-Commit-Position: refs/branch-heads/2924@{#5} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu * Prevent label text from wrapping during animations BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2502413003 Cr-Commit-Position: refs/heads/master@{#433107} (cherry picked from commit 572f871) Review URL: https://codereview.chromium.org/2520623004 . Cr-Commit-Position: refs/branch-heads/2924@{#15} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

Move the note-taking app setting and "find more apps" link from the stylus settings overlay of chrome://settings into their own rows to add more vertical spacing between them and the other settings. BUG=633596,633243 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2643313002 Cr-Commit-Position: refs/heads/master@{#445121} (cherry picked from commit e133e51) Review-Url: https://codereview.chromium.org/2645213002 . Cr-Commit-Position: refs/branch-heads/2987@{#15} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

These are being added before branch point so they can be localized. Code will follow. BUG=697259,698368 Review-Url: https://codereview.chromium.org/2730903006 Cr-Original-Commit-Position: refs/heads/master@{#454667} Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa2774980dc4eb Review-Url: https://codereview.chromium.org/2730903006 Cr-Commit-Position: refs/heads/master@{#454698} (cherry picked from commit 16fe9a0) Review-Url: https://codereview.chromium.org/2735653002 . Cr-Commit-Position: refs/branch-heads/3029@{#15} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

BUG=711591 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2821573003 Cr-Commit-Position: refs/heads/master@{#464814} (cherry picked from commit c194280) Review-Url: https://codereview.chromium.org/2820133002 . Cr-Commit-Position: refs/branch-heads/3071@{#15} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

This CL correct dialog footer styling so that a footer will have a gray separator line consistently. TBR=dschuyler@chromium.org (cherry picked from commit 80f42ed) Bug: 746186 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1822f3724762f07658404ed03772d2bb8a83e507 Reviewed-on: https://chromium-review.googlesource.com/578375 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488564} Reviewed-on: https://chromium-review.googlesource.com/583936 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#15} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

HttpURLConnection.getErrorStream() can return null when there is no response body (e.g. HEAD request). Avoid crashing in InputStreamChannel by not creating an InputStreamChannel. TBR=pauljensen@chromium.org (cherry picked from commit c899367) Bug: 761397 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I9a094efe1a759f87d8444da2bf745cfe40a46f5c Reviewed-on: https://chromium-review.googlesource.com/647831 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499303} Reviewed-on: https://chromium-review.googlesource.com/648847 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#15} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

Some code reads the metadata of the actual /etc symlink, so that path needs to be allowed by the sandbox. Bug: 773532 Change-Id: I663b5e4f62705bbc42cd7a83578d63279ad8cb0c Reviewed-on: https://chromium-review.googlesource.com/719407 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508781}(cherry picked from commit 9509209) Reviewed-on: https://chromium-review.googlesource.com/721874 Cr-Commit-Position: refs/branch-heads/3239@{#15} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

Update the HSTS preload list with manually-requested entries. TBR=palmer@chromium.org Change-Id: I7aadcbc4da452dc918226112b3085afa70892a20 Reviewed-on: https://chromium-review.googlesource.com/875255 Reviewed-by: Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530390}(cherry picked from commit c725c61) Reviewed-on: https://chromium-review.googlesource.com/878981 Cr-Commit-Position: refs/branch-heads/3325@{#15} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

(cherry picked from commit f2ae6ac) Bug: 818055 Change-Id: Ia0f8ee535c45ede4047e02f068def70e538b8524 Reviewed-on: https://chromium-review.googlesource.com/946740 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540648} Reviewed-on: https://chromium-review.googlesource.com/949566 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#15} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

Update preload=none state based on the new mocks. Also adds ShouldShow[Audio/Video]Controls to MediaControlsImpl to simplify the logic around which set of controls we should show. BUG=818659 No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ide3bed15161aa5e1e1096275212c718eacb24a77 Reviewed-on: https://chromium-review.googlesource.com/993757 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550487}(cherry picked from commit 096153b) Reviewed-on: https://chromium-review.googlesource.com/1014181 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#15} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

This CL unconditionally enables the fullscreen exit UI as we get all approvals on the launch bug. Bug: 829606 Change-Id: Ia8dd65b0946999d5cba9d897f068f4c9858ff163 Reviewed-on: https://chromium-review.googlesource.com/1073625 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562041}(cherry picked from commit 1c11fb9) Reviewed-on: https://chromium-review.googlesource.com/1075688 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#15} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

Bug: 865119 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2a6fdb250075d14306eb4f581b8443f05632d8f Reviewed-on: https://chromium-review.googlesource.com/1145851 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577088}(cherry picked from commit 7d4ead6) Reviewed-on: https://chromium-review.googlesource.com/1146781 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#15} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

TBR=govind@chromium.org Change-Id: I8976a820a648bf9ead43d0b4bde439a477ee34e3 Reviewed-on: https://chromium-review.googlesource.com/1203433 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#15} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

See what it looks like in comment #15 of the linked bug. TBR=manucornet@chromium.org (cherry picked from commit d7f0b691f70fa8699018ca2d0737b9f64d5cc1c3) Bug: 874161 Change-Id: I42a81c93742fb68720e237e34e2b66b68b3e9de5 Reviewed-on: https://chromium-review.googlesource.com/1197730 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587849} Reviewed-on: https://chromium-review.googlesource.com/1214262 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#156} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

This CL updates the UI to show a badge icon in the app menu icon whenever the user is running Chrome on a currently unsupported Android version. This badge in the app menu is only displayed once, until the user taps the app menu icon. If the user does in fact get a new version, the badge state is reset, and will be shown again. The current behavior for out of date users stays the same as before (once per cold start). In addition, a new menu item is displayed at the top of the menu that explains that Chrome is unable to update. Nothing happens when you tap the menu item in the case of an unsupported OS version. The new menu item and the new warning message in About Chrome will always be displayed when the user is in this state, regardless of whether the app menu has already been tapped (which removes the badge). This CL also updates the UI in Settings - About Chrome to show a new message and a warning icon when the user is running Chrome on an unsupported version of the Android OS. By default, Jelly Bean is considered unsupported after this CL, but this can be overridden from the variations framework. It is possible to use command line flags or chrome://flags for testing the different states, though that does not impact the About Chrome screen. Binary-Size: This CL adds new assets and the minimal code required. Bug: 847940 Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6 Reviewed-on: https://chromium-review.googlesource.com/c/1243167 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599369}(cherry picked from commit 5423fd8) Reviewed-on: https://chromium-review.googlesource.com/c/1279959 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#15} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

…pported." This reverts commit 601b3e3. Reason for revert: Breaks Chrome Custom Tabs. Original change's description: > Update UI for unsupported Android OS and make Jelly Bean unsupported. > > This CL updates the UI to show a badge icon in the app menu icon > whenever the user is running Chrome on a currently unsupported Android > version. This badge in the app menu is only displayed once, until the > user taps the app menu icon. If the user does in fact get a new version, > the badge state is reset, and will be shown again. The current behavior > for out of date users stays the same as before (once per cold start). > > In addition, a new menu item is displayed at the top of the menu that > explains that Chrome is unable to update. Nothing happens when you tap > the menu item in the case of an unsupported OS version. > > The new menu item and the new warning message in About Chrome will > always be displayed when the user is in this state, regardless of > whether the app menu has already been tapped (which removes the badge). > > This CL also updates the UI in Settings - About Chrome to show a new > message and a warning icon when the user is running Chrome on an > unsupported version of the Android OS. > > By default, Jelly Bean is considered unsupported after this CL, but this > can be overridden from the variations framework. > > It is possible to use command line flags or chrome://flags for > testing the different states, though that does not impact the > About Chrome screen. > > Binary-Size: This CL adds new assets and the minimal code required. > Bug: 847940 > Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6 > Reviewed-on: https://chromium-review.googlesource.com/c/1243167 > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#599369}(cherry picked from commit 5423fd8) > Reviewed-on: https://chromium-review.googlesource.com/c/1279959 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#15} > Cr-Branched-From: 4226ddf-refs/heads/master@{#599034} TBR=nyquist@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847940 Change-Id: Iec0d8b4c07f123597f4883d1be3f14c3207e7c05 Reviewed-on: https://chromium-review.googlesource.com/c/1286281 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#92} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

Revert "[unified-consent] Fix official browser tests" This reverts commit 44c85b6. Reason for revert: <INSERT REASONING HERE> Original change's description: > [unified-consent] Fix official browser tests > > The unified consent feature was not enabled in > UnifiedConsentBrowserTest for official tests. > This is fixed now. > > Bug: 910523, 888527 > Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda > Reviewed-on: https://chromium-review.googlesource.com/c/1356960 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#612678}(cherry picked from commit 3763198) > Reviewed-on: https://chromium-review.googlesource.com/c/1358449 > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/branch-heads/3626@{#9} > Cr-Branched-From: d897fb1-refs/heads/master@{#612437} TBR=tangltom@chromium.org Change-Id: Ifda419362b527ef0567a4a283542a772389a3261 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910523, 888527 Reviewed-on: https://chromium-review.googlesource.com/c/1359306 Reviewed-by: Abdul Syed <abdulsyed@google.com> Cr-Commit-Position: refs/branch-heads/3626@{#15} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

In the condition when the device is disabled by policy it was referencing a yet uninitialized LoginScreenClient leading to SYSSEGV and boot/login loop in Chromebooks. Bug: 884127 Change-Id: If99d945777e56cbc1299f5094afd32cee1872f3a Reviewed-on: https://chromium-review.googlesource.com/c/1435436 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626120}(cherry picked from commit 1453a24) Reviewed-on: https://chromium-review.googlesource.com/c/1439075 Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#15} Cr-Branched-From: e510299-refs/heads/master@{#625896}

TBR=mmoss@chromium.org Change-Id: Id44d8f8673cac651c2dcf1b2d0c2eb83a7e5b23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513739 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#15} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

Use package name as WM_CLASS

958566c

This patch fixed the name in top bar of GNOME. Fixed nwjs/nw.js#4693

rogerwang closed this Apr 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use package name as WM_CLASS #15

Use package name as WM_CLASS #15

ghostoy commented Apr 11, 2016

rogerwang commented Apr 11, 2016

Use package name as WM_CLASS #15

Use package name as WM_CLASS #15

Conversation

ghostoy commented Apr 11, 2016

rogerwang commented Apr 11, 2016