-
Notifications
You must be signed in to change notification settings - Fork 127
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert of getComputedStyle should handle over-constrained properties.…
… (patchset #7 id:100001 of https://codereview.chromium.org/1988813002/ ) Reason for revert: Other vendors didn't implement this yet. And work with the others to either get all to fix or to change the spec. BUG=614198 Original issue's description: > getComputedStyle should handle over-constrained properties. > > If neither 'left' nor 'right' is 'auto', the position is over-constrained, > and one of them has to be ignored. If 'direction' property of the > containing block is 'ltr', the value of 'left' wins and 'right' > becomes -'left'. If 'direction' of the containing block is 'rtl', > 'right' wins and 'left' is ignored. Detail is described by > https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning > > BUG=601118 > > Committed: https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05 > Cr-Commit-Position: refs/heads/master@{#394780} TBR=mstensho@opera.com,alancutter@chromium.org,rune@opera.com,eae@chromium.org,timloh@chromium.org BUG=601118 Review-Url: https://codereview.chromium.org/2016913003 Cr-Commit-Position: refs/heads/master@{#396470} (cherry picked from commit 9835ebf) Review URL: https://codereview.chromium.org/2025523002 . Cr-Commit-Position: refs/branch-heads/2743@{#116} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
- Loading branch information
Rune Lillesveen
committed
May 28, 2016
1 parent
aa008be
commit 608b46d
Showing
7 changed files
with
16 additions
and
148 deletions.
There are no files selected for viewing
24 changes: 12 additions & 12 deletions
24
third_party/WebKit/LayoutTests/fast/css/computed-offset-with-zoom-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 0 additions & 17 deletions
17
...bKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-over-constrained-expected.txt
This file was deleted.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
...party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-over-constrained.html
This file was deleted.
Oops, something went wrong.
17 changes: 0 additions & 17 deletions
17
...rty/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-right-auto-expected.txt
This file was deleted.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-right-auto.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters