Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'width' and 'height' in the manifest file does not work properly on OSX.[nw 0.13 rc1] #4493

Closed
sean220 opened this issue Mar 4, 2016 · 5 comments
Closed

The 'width' and 'height' in the manifest file does not work properly on OSX.[nw 0.13 rc1] #4493

sean220 opened this issue Mar 4, 2016 · 5 comments
Assignees
@ghostoy
Labels
nw13
Milestone
0.13.0

Comments

@sean220
Copy link

sean220 commented Mar 4, 2016

The behavior of these two parameters for main window is unstable on OSX,Sometimes it loads the old value, or get some unpredictable values.
@yeaphone
Copy link

yeaphone commented Mar 4, 2016

I meet the same problem.

@rogerwang rogerwang added the nw13 label Mar 7, 2016
@rogerwang
Copy link
Member

Did it restore with the dimension saved when you close it last time?

@rogerwang rogerwang modified the milestone: 0.13.0 Mar 7, 2016
@sean220
Copy link
Author

sean220 commented Mar 7, 2016

YES,After tests found it's just restores the last dimension and ignores the values in the package.json even updated.

@JaredSartin
Copy link

fullscreen doesn't take either.

@ghostoy ghostoy self-assigned this Mar 8, 2016
ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Mar 9, 2016
Fix window open size
14a7969 
Previously `id` is provided as `.main` with default window, which
caused the geometry of the window recorded and restored when the
window opened again. Removing `id` for default window fixes the issue.

This patch contains doc changes and test case. The real fix in on
Chromium side.

Partial fix for nwjs#4493
ghostoy pushed a commit to ghostoy/chromium.src that referenced this issue Mar 9, 2016
Removing id for default window
6d6c9d7 
Fixed nwjs/nw.js#4493
@ghostoy ghostoy mentioned this issue Mar 9, 2016
Closed
ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Mar 9, 2016
Fix window open size
d715f34 
This patch contains doc changes and test case. The real fix in on
Chromium side.

Partial fix for nwjs#4493
ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Mar 9, 2016
Fix window open size
2d36ea8 
This patch contains doc changes and test case. The real fix in on
Chromium side.

Partial fix for nwjs#4493
@ghostoy ghostoy mentioned this issue Mar 9, 2016
Merged
@rogerwang
Copy link
Member

fixed in git and will be available in the next build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghostoy ghostoy

Labels
nw13
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
5 participants
@rogerwang @ghostoy @JaredSartin @sean220 @yeaphone