-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLT DQM #19142
Comments
A new Issue was created by @mtosi mia tosi. @davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
Hi @mtosi, where is this code coming from?
I've seen it in half of the pull requests listed here. Ironically, one of these modules is actually called 'GENERICDQM'... |
ciao
it was in one of mine example for non experts
and as you saw almost everybody copied-n-pasted it :(
I agree we should have a more general class for doing it
mia
…On Fri, Jun 23, 2017 at 3:28 PM, Dmitrijus ***@***.***> wrote:
Hi @mtosi <https://github.com/mtosi>,
where is this code coming from:
+void HTMonitor::bookME(DQMStore::IBooker &ibooker, HTME& me, const std::string& histname, const std::string& histtitle, int nbins, double min, double max)
I've seen it in half of the pull requests listed here.
If this comes from some kind of template for HLT module, please turn it
into some kind of generic cpp module.
Ironically one of such modules is actually called 'GENERICDQM'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19142 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt5851T-z5XucKbpWLc9JKd-JeEQDcYks5sG71mgaJpZM4Nz-no>
.
|
The text was updated successfully, but these errors were encountered: