Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #19293: EXOtrigger MET & HT prompt monitoring 92X #19534

Closed
wants to merge 12 commits into from

Conversation

rappoccio
Copy link
Contributor

Backport of #19293 to 92x, since that was automatically moved to 93x.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

A new Pull Request was created by @rappoccio for CMSSW_9_2_X.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21117/console Started: 2017/07/04 02:48

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison job queued.

@fwyzard
Copy link
Contributor

fwyzard commented Jul 4, 2017

backport of #19293

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19534/21117/summary.html

Comparison Summary:

  • You potentially added 30 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813696
  • DQMHistoTests: Total failures: 14873
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1798657
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@mtosi
Copy link
Contributor

mtosi commented Jul 6, 2017

tracked by #19142

@rappoccio
Copy link
Contributor Author

Similarly to the main PR #19293, I have updated the 92x backports to include the jet+mass paths.

CMSSW_9_2_X...rappoccio:EXOB2G_HLTMON_92xbackport_Part2

As in the other PR, once the two prerequisite PRs are merged, I will rebase this to the new IB and submit another PR for the next paths.

@rappoccio
Copy link
Contributor Author

@davidlange6 Is this going in "as is" or do you want the changes from #19293 backported?

@rappoccio
Copy link
Contributor Author

@davidlange6 what should I do here? The changes are ready if you want them in.

@fwyzard
Copy link
Contributor

fwyzard commented Jul 25, 2017

Hi,
given the amount of stuff that needs to be backported, I plan to do it in a single PR as soon as the DQM for the HLT menu v2.1 is fully integrated in 9.3.x.
If the 9.3.x equivalent of this PR has already been merged, or is listed as "Open" at #19412, can you close this PR ?

@rappoccio
Copy link
Contributor Author

The only bit left to backport is #19820

Should I handle that or do you want to add it?

@rappoccio rappoccio closed this Jul 26, 2017
@fwyzard
Copy link
Contributor

fwyzard commented Jul 26, 2017

I'll do that centrally.

@rappoccio
Copy link
Contributor Author

OK thanks!

@rappoccio rappoccio deleted the EXOB2G_HLTMON_92x branch February 6, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants