Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B2G HLT DQM for 93x, part 2 #19820

Merged
merged 2 commits into from
Jul 21, 2017
Merged

B2G HLT DQM for 93x, part 2 #19820

merged 2 commits into from
Jul 21, 2017

Conversation

rappoccio
Copy link
Contributor

Here are the promised updates for the B2G HLT DQM, after the previous monitors were integrated. This adds the single jet plus mass triggers and the e+jet boosted top trigger.

@alefisico @UBParker

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Jul 19, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@alefisico
Copy link
Contributor

thanks @rappoccio, including @lbenato in the loop

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21620/console Started: 2017/07/19 20:40

@cmsbuild
Copy link
Contributor

+1
Tested at: e1e3387
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19820/21620/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b5ed5c7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19820/21620/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19820/21620/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19820/21620/summary.html

Comparison Summary:

  • You potentially added 420 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2310405
  • DQMHistoTests: Total failures: 14994
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2295245
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@rappoccio
Copy link
Contributor Author

@mtosi is should be good to go for these B2G triggers.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4fa79e5 into cms-sw:master Jul 21, 2017
@rappoccio rappoccio mentioned this pull request Jul 26, 2017
Closed
@rappoccio rappoccio deleted the EXOB2G_HLTMON_93x_Part3 branch February 6, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@rappoccio @cmsbuild @alefisico @davidlange6 @dmitrijus