Adding HLT_Ele50_CaloIdVT_GsfTrkIdT_PFJet165_v* to B2G HLT Monitoring #19407

UBParker · 2017-06-22T16:27:10Z

No description provided.

cmsbuild · 2017-06-22T16:27:29Z

A new Pull Request was created by @UBParker (Ashley Marie Parker) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-06-26T10:27:15Z

tracked by #19142

mtosi · 2017-06-26T10:27:21Z

please, rebase

mtosi · 2017-06-26T10:28:23Z

DQMOffline/Trigger/plugins/HTMonitor.cc

+  , muoToken_             ( mayConsume<reco::MuonCollection>       (iConfig.getParameter<edm::InputTag>("muons")     ) )   
+  , vtxToken_             ( mayConsume<reco::VertexCollection>      (iConfig.getParameter<edm::InputTag>("vertices")      ) )
+  , ht_variable_binning_ ( iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<std::vector<double> >("htBinning") )
+  , ht_binning_          ( getHistoPSet   (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet>   ("htPSet")    ) )


do you really need it ?

Again, this was already present, I did not change it. If it is not needed I can remove it.

@mtosi - I don't understand what are you pointing to exactly?

we need to squeeze the #bins,
=> if the fix size binning is not needed, because you have the variable binning already
please, drop the fix one

@sudhaahuja Can you tell me which lines to remove ?

Sorry for the delay in checking the compilation errors, but I was traveling for EPS and now attending the conference.
@mtosi - we (me and @UBParker ) removed the fixed binning but then we realised that htvsLS 2D histogram depends on fixed binning, so we changed the definition of this histogram as - variable binning vs LS 2D histogram (https://github.com/UBParker/cmssw/blob/AddingHLTEl50PFJet165/DQMOffline/Trigger/plugins/METMonitor.cc#L117-#L126). I think the compilation error is coming because its not defined in the header (.h) file. After adding that in the .h file, I am trying to compile it locally but now I see that kind of format is not defined in the DQMServices/Core/interface/DQMStore.h file. So can we just keep the fixed binning definition for the htvsLS plot and also similarly for the metvsLS plot.

mtosi · 2017-06-26T10:29:07Z

DQMOffline/Trigger/plugins/HTMonitor.cc

+  for ( auto const & j : *jetHandle ) {
+    if ( jetSelection_( j ) ) {
+      jets.push_back(j);
+      if ( jetSelection_HT_(j)) ht += j.pt();


please, move outside the jetSelection

or better, drop this line !
it is already in l171 !!!!!

@UBParker - could you please remove this L167 from the old commit versions, as the jetSelection_HT_ was already moved to L171 in the recent commits by @rappoccio I think. Thank you.

mtosi · 2017-06-26T10:29:50Z

DQMOffline/Trigger/plugins/HTMonitor.cc

+  iEvent.getByToken(vtxToken_, vtxHandle);
+
+  reco::Vertex vtx;
+  math::XYZPoint pv(0, 0, 0);


why don't you make use of the beam spot if the PV is not available/valid ?

This code was already present before I began working on this. If you would like me to make use of beam spot and if @rappoccio agrees that this is a necessary update then I will implement it.

@sudhaahuja Can you comment on this?

mtosi · 2017-06-26T10:30:05Z

DQMOffline/Trigger/plugins/HTMonitor.cc

+  std::vector<reco::Muon> muons;
+  muons.clear();
+  for ( auto const & m : *muoHandle ) {
+    if ( muoSelection_( m ) && m.isGlobalMuon() && m.isPFMuon() && m.globalTrack()->normalizedChi2() < 10. && m.globalTrack()->hitPattern().numberOfValidMuonHits() > 0 && m.numberOfMatchedStations() > 1 && fabs(m.muonBestTrack()->dxy(pv)) < 0.2 && fabs(m.muonBestTrack()->dz(pv)) < 0.5 && m.innerTrack()->hitPattern().numberOfValidPixelHits() > 0 && m.innerTrack()->hitPattern().trackerLayersWithMeasurement() > 5 )  muons.push_back(m);


no hardcoded selection, please

Same comment as METMonitor, @mtosi - For calculating the efficiency of certain triggers, there is a requirement to select one tight muon (while using the singleMuon dataset). Also, its was not possible to define the same selection cuts in the cff files so I put them here instead. Also, I can not use the function "isTightMuon()" directly, so I put in the tight muon selection cuts one by one in the code.

please, add a flag in order to switch ON these selections

mtosi · 2017-06-26T10:31:41Z

DQMOffline/Trigger/plugins/METMonitor.cc

+  iEvent.getByToken(vtxToken_, vtxHandle);
+
+  reco::Vertex vtx;
+  math::XYZPoint pv(0, 0, 0);


as in HTMonitor, why don't you use the beam spot ?

@sudhaahuja Can you comment on this? I have not edited this file.

mtosi · 2017-06-26T10:31:51Z

DQMOffline/Trigger/plugins/METMonitor.cc

  for ( auto const & m : *muoHandle ) {
-    if ( muoSelection_( m ) ) muons.push_back(m);
+    bool pass = m.isGlobalMuon() && m.isPFMuon() && m.globalTrack()->normalizedChi2() < 10. && m.globalTrack()->hitPattern().numberOfValidMuonHits() > 0 && m.numberOfMatchedStations() > 1 && fabs(m.muonBestTrack()->dxy(pv)) < 0.2 && fabs(m.muonBestTrack()->dz(pv)) < 0.5 && m.innerTrack()->hitPattern().numberOfValidPixelHits() > 0 && m.innerTrack()->hitPattern().trackerLayersWithMeasurement() > 5;


no hard coded selection

I have asked @sudhaahuja to reply to these comments as only the files with "B2G" in the title are those I actually edited for this PR.

@mtosi - For calculating the efficiency of certain triggers, there is a requirement to select one tight muon (while using the singleMuon dataset). Also, its was not possible to define the same selection cuts in the cff files so I put them here instead. Also, I can not use the function "isTightMuon()" directly, so I put in the tight muon selection cuts one by one in the code.

mtosi · 2017-06-26T10:32:26Z

DQMOffline/Trigger/python/B2GMonitoring_Client_cff.py

+    ),
+
+    efficiencyProfile = cms.untracked.vstring(
+        "effic_pfjetpT_vs_LS 'JET efficiency vs LS; LS; PF JET efficiency' jetpTVsLS_numerator jetpTVsLS_denominator",


do you really need it ?
are you applying different selection w.r.t. the HT one ?

No, it is the same. I have fixed this here https://github.com/UBParker/cmssw/blob/AddingHLTEl50PFJet165/DQMOffline/Trigger/python/B2GMonitoring_Client_cff.py

mtosi · 2017-06-26T10:33:41Z

DQMOffline/Trigger/python/B2GMonitoring_cff.py

+# HLT_AK8PFHT700_TrimR0p1PT0p03Mass50                                                                                                                                         
+AK8PFHT750_TrimMass50_HTmonitoring = hltHTmonitoring.clone()
+AK8PFHT750_TrimMass50_HTmonitoring.FolderName = cms.string('HLT/B2GMonitor/AK8PFHT750_TrimMass50')
+AK8PFHT750_TrimMass50_HTmonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_AK8PFHT750_TrimMass50_v*")


don't you monitor the SD mass and tau2/tau1 ?

Not at trigger level

not at trigger level, as none of the quantities in these plots, i would say...
shouldn't you monitor the bias on these very important quantities in your analyses ?!?

These are analysis dependent. I would say that the HLT monitoring we want should be more directly related to the trigger than to individual analyses, no?

mtosi · 2017-06-26T10:36:42Z

DQMOffline/Trigger/python/ExoticaMonitoring_Client_cff.py

@@ -9,13 +12,35 @@
        "effic_met          'MET turnON;            PF MET [GeV]; efficiency'     met_numerator          met_denominator",
        "effic_met_variable 'MET turnON;            PF MET [GeV]; efficiency'     met_variable_numerator met_variable_denominator",
        "effic_metPhi       'MET efficiency vs phi; PF MET phi [rad]; efficiency' metPhi_numerator       metPhi_denominator",
+        "effic_ht          'HT turnON;            PF HT [GeV]; efficiency'     ht_numerator          ht_denominator",


I'm confused :(

@mtosi Could you clarify? Maybe @sudhaahuja could comment on any questions you have about this.

isn't this turnOn done in an other client as well ?!?
the B2G monitor client for instance

@mtosi I have removed this turn on from the B2G client here https://github.com/UBParker/cmssw/blob/AddingHLTEl50PFJet165/DQMOffline/Trigger/python/B2GMonitoring_Client_cff.py

mtosi · 2017-06-26T10:37:17Z

DQMOffline/Trigger/python/HTMonitor_cff.py

+# HLT_PFMETNoMu90_PFMHTNoMu90_IDTight
+PFMETNoMu90_PFMHTNoMu90_HTmonitoring = hltHTmonitoring.clone()
+PFMETNoMu90_PFMHTNoMu90_HTmonitoring.FolderName = cms.string('HLT/HT/PFMETNoMu90/')
+PFMETNoMu90_PFMHTNoMu90_HTmonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_PFMETNoMu90_PFMHTNoMu90_IDTight_v*")


why I do not see it in the silvio's google doc ?

@UBParker - Could you please remove these paths from you cff file. These came from the original template I used and were never deleted. Thank you.

@sudhaahuja I need clarification on which paths to remove, just LT_PFMETNoMu90_PFMHTNoMu90_IDTight or others as well ?

@UBParker - can you please remove PFMETNoMu90_PFMHTNoMu90 , MET200 & MonoCentralPFJet80_PFMETNoMu90_PFMHTNoMu90 monitoring from both METMonitor and HTMonitor cff files. Thanks a lot.

@mtosi @sudhaahuja I have removed those paths from both files.

mtosi · 2017-06-26T16:46:48Z

please make it configurable

…

On 26 Jun 2017, at 18:07, sudha ***@***.***> wrote: @sudhaahuja commented on this pull request. In DQMOffline/Trigger/plugins/METMonitor.cc: > for ( auto const & m : *muoHandle ) { - if ( muoSelection_( m ) ) muons.push_back(m); + bool pass = m.isGlobalMuon() && m.isPFMuon() && m.globalTrack()->normalizedChi2() < 10. && m.globalTrack()->hitPattern().numberOfValidMuonHits() > 0 && m.numberOfMatchedStations() > 1 && fabs(m.muonBestTrack()->dxy(pv)) < 0.2 && fabs(m.muonBestTrack()->dz(pv)) < 0.5 && m.innerTrack()->hitPattern().numberOfValidPixelHits() > 0 && m.innerTrack()->hitPattern().trackerLayersWithMeasurement() > 5; @mtosi - For calculating the efficiency of certain triggers, there is a requirement to select one tight muon (while using the singleMuon dataset). Also, I can not use the function "isTightMuon()" directly, so I put in the tight muon selection cuts one by one in the code. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mtosi · 2017-06-26T17:25:52Z

are you referring to the SD and tau2/tau1 ? i tend to agree, but at the same time i think it would be worth to have at least one representative one mia

…

On 26 Jun 2017, at 19:02, rappoccio ***@***.***> wrote: @rappoccio commented on this pull request. In DQMOffline/Trigger/python/B2GMonitoring_cff.py: > +#from DQMOffline.Trigger.JetMETMonitor_cfi import hltJetMETmonitoring +from DQMOffline.Trigger.HTMonitor_cfi import hltHTmonitoring +from DQMOffline.Trigger.B2GTnPMonitor_cfi import B2GegmGsfElectronIDsForDQM,B2GegHLTDQMOfflineTnPSource + +# B2G triggers: +#HLT_AK8PFHT750_TrimMass50_v* +#HLT_AK8PFJet380_TrimMass30_v* +#HLT_AK8PFHT800_TrimMass50_v* +#HLT_AK8PFJet400_TrimMass30_v* +#HLT_AK8PFHT850_TrimMass50_v* +#HLT_AK8PFJet420_TrimMass30_v* +#HLT_AK8PFHT900_TrimMass50_v* +# HLT_AK8PFHT700_TrimR0p1PT0p03Mass50 +AK8PFHT750_TrimMass50_HTmonitoring = hltHTmonitoring.clone() +AK8PFHT750_TrimMass50_HTmonitoring.FolderName = cms.string('HLT/B2GMonitor/AK8PFHT750_TrimMass50') +AK8PFHT750_TrimMass50_HTmonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_AK8PFHT750_TrimMass50_v*") These are analysis dependent. I would say that the HLT monitoring we want should be more directly related to the trigger than to individual analyses, no? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cmsbuild · 2017-07-04T15:49:43Z

Pull request #19407 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

fwyzard · 2017-07-04T22:13:54Z

I'm sure at some point @cmsbuild will simply refuse to run the tests

fwyzard · 2017-07-04T22:14:10Z

@cmsbuild, please test

cmsbuild · 2017-07-04T22:14:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21158/console Started: 2017/07/05 00:24

cmsbuild · 2017-07-04T22:33:06Z

-1

Tested at: 491bd35

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd7fdb2
0c63302
e4d2a49
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19407/21158/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19407/21158/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19407/21158/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/HTMonitor.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/NoBPTXMonitor.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/HLTTagAndProbeOfflineSource.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/METMonitor.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/RazorMonitor.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/HTMonitor.cc:110:6: error: prototype for 'void HTMonitor::bookME(DQMStore::IBooker&, HTMonitor::HTME&, const string&, const string&, int, double, double, const std::vector&)' does not match any in class 'HTMonitor'
 void HTMonitor::bookME(DQMStore::IBooker &ibooker, HTME& me, const std::string& histname, const std::string& histtitle,int nbinsX, double xmin, double xmax , const std::vector& binningY)
      ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/HTMonitor.cc:97:6: error: candidates are: void HTMonitor::bookME(DQMStore::IBooker&, HTMonitor::HTME&, const string&, const string&, const std::vector&, const std::vector&)
 void HTMonitor::bookME(DQMStore::IBooker &ibooker, HTME& me, const std::string& histname, const std::string& histtitle, const std::vector& binningX, const std::vector& binningY)
      ^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/src/JetMETHLTOfflineSource.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/src/HotlineDQM.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/src/TopHLTOfflineDQMHelper.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/src/HLTTauCertifier.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/src/EgHLTOffHelper.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/METMonitor.cc:117:18: error: out-of-line definition of 'bookME' does not match any declaration in 'METMonitor'
void METMonitor::bookME(DQMStore::IBooker &ibooker, METME& me, const std::string& histname, const std::string& histtitle, int nbinsX, double xmin, double xmax, const std::vector& binningY)
                 ^~~~~~
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-04-1100/src/DQMOffline/Trigger/plugins/METMonitor.cc:152:3: error: no matching member function for call to 'bookME'
  bookME(ibooker,metVsLS_ ,histname,histtitle,ls_binning_.nbins, ls_binning_.xmin, ls_binning_.xmax, met_variable_binning_ );
  ^~~~~~

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd7fdb2
0c63302
e4d2a49
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19407/21158/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19407/21158/git-merge-result

cmsbuild · 2017-07-04T22:33:08Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

UBParker · 2017-07-04T23:44:25Z

@sudhaahuja Please test the file DQMOffline/Trigger/plugins/METMonitor.cc and let me know the appropriate changes. These errors are related to the changes you suggested that we make to the file during our meeting on Monday.

physicist87 · 2017-07-05T05:51:04Z

@UBParker
Hello,

Bobae and I are planning to update pure MET Trigger which was suggested by JME Group.

We think we just added MET triggers in METMonitor_cff file. (We copied METMonitor_cff.py from this PR and then we added METTriggers. )

If you go to this link[1], you can see our METMonitor_cff.py

I'm not sure we can update this file in this PR.

Can we update this file?

Thank you,
Seungkyu

[1] https://cernbox.cern.ch/index.php/s/AZQ8iiqkQiZRXj8

fwyzard · 2017-07-05T06:53:06Z

Can you *please* test the changes locally before pushing them to the PR ?

UBParker · 2017-07-05T10:24:28Z

Yes, apologies, those are not my changes though, which is why I have asked @sudhaahuja to test them.

UBParker · 2017-07-05T10:25:59Z

@physicist87 If you have already tested your changes and others agree @fwyzard @mtosi @rappoccio then I can make the required additions.

physicist87 · 2017-07-05T10:31:54Z

@UBParker Thank you !!
We only modified METMonitor_cff. Actually, we just copied and pasted. So we think there is no problem, if METMonitor.cc works.
Thank you,
Seungkyu

rappoccio · 2017-07-06T13:47:43Z

It looks like basically everything since July 3rd is already implemented in #19293 and its backport, #19534. =/

The only unique commits are these (*). I will work on integrating them.

Cheers,
Sal

mtosi · 2017-07-06T15:51:54Z

could not you simply have the parameter, but make use of it only for the 2D plot ?!?!?!?

…

On Thu, Jul 6, 2017 at 10:47 AM, sudha ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In DQMOffline/Trigger/plugins/HTMonitor.cc <#19407 (comment)>: > + +#include "DataFormats/Math/interface/deltaPhi.h" + +// ----------------------------- +// constructors and destructor +// ----------------------------- + +HTMonitor::HTMonitor( const edm::ParameterSet& iConfig ) : + folderName_ ( iConfig.getParameter<std::string>("FolderName") ) + , metToken_ ( consumes<reco::PFMETCollection> (iConfig.getParameter<edm::InputTag>("met") ) ) + , jetToken_ ( mayConsume<reco::PFJetCollection> (iConfig.getParameter<edm::InputTag>("jets") ) ) + , eleToken_ ( mayConsume<reco::GsfElectronCollection>(iConfig.getParameter<edm::InputTag>("electrons") ) ) + , muoToken_ ( mayConsume<reco::MuonCollection> (iConfig.getParameter<edm::InputTag>("muons") ) ) + , vtxToken_ ( mayConsume<reco::VertexCollection> (iConfig.getParameter<edm::InputTag>("vertices") ) ) + , ht_variable_binning_ ( iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<std::vector<double> >("htBinning") ) + , ht_binning_ ( getHistoPSet (iConfig.getParameter<edm::ParameterSet>("histoPSet").getParameter<edm::ParameterSet> ("htPSet") ) ) @mtosi <https://github.com/mtosi> - we (me and @UBParker <https://github.com/ubparker> ) removed the fixed binning but then we realised that htvsLS 2D histogram depends on fixed binning, so we changed the definition of this histogram as - variable binning vs LS 2D histogram ( https://github.com/UBParker/cmssw/blob/AddingHLTEl50PFJet165/ DQMOffline/Trigger/plugins/METMonitor.cc#L117-#L126). I think the compilation error is coming because its not defined in the header (.h) file. After adding that in the .h file, I am trying to compile it locally but now I see that kind of format is not defined in the DQMServices/Core/interface/DQMStore.h file. So can we just keep the fixed binning definition for the htvsLS plot and also similarly for the metvsLS plot. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19407 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt58_BtAQnjIfU-dSEZzvty0q89A3J5ks5sLJ8igaJpZM4OCib-> .

rappoccio · 2017-07-09T03:58:08Z

Let's close this PR. I have the necessary changes implemented here:

master...rappoccio:EXOB2G_HLTMON_92x_Part3

Once #19178 and #19534 are integrated, I can integrate this on top of them (after a quick rebase).

rappoccio · 2017-07-09T04:20:59Z

Also I have the 92x backport ready, with similar prerequisite PRs:

https://github.com/rappoccio/cmssw/tree/EXOB2G_HLTMON_92xbackport_Part3

physicist87 added 6 commits June 9, 2017 18:35

Update Prompt DQM for HLT Jet

33c0800

Update Prompt DQM for HLT Jet

ad4178b

Update To use edm::View<reco::Jet>

0710087

Update To use edm::View<reco::Jet>

5eeaf13

Ratio Plot(HEP17/HEM17) for eta phi pT

97f4f26

To avoid the case of non ak4pfjet, bug fix

aaa57c0

cmsbuild added this to the CMSSW_9_2_X milestone Jun 22, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jun 22, 2017

mtosi mentioned this pull request Jun 26, 2017

HLT DQM #19142

Open

mtosi reviewed Jun 26, 2017

View reviewed changes

smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017

cmsbuild added comparison-notrun tests-rejected labels Jul 4, 2017

fix typo in metVsLS_ name

491bd35

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jul 4, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 4, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 4, 2017

UBParker closed this Jul 11, 2017

Adding HLT_Ele50_CaloIdVT_GsfTrkIdT_PFJet165_v* to B2G HLT Monitoring #19407

Adding HLT_Ele50_CaloIdVT_GsfTrkIdT_PFJet165_v* to B2G HLT Monitoring #19407

Conversation

UBParker commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

mtosi commented Jun 26, 2017

mtosi commented Jun 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudhaahuja Jul 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudhaahuja Jun 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi commented Jun 26, 2017 via email

mtosi commented Jun 26, 2017 via email

cmsbuild commented Jul 4, 2017

fwyzard commented Jul 4, 2017

fwyzard commented Jul 4, 2017

cmsbuild commented Jul 4, 2017 • edited Loading

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

UBParker commented Jul 4, 2017

physicist87 commented Jul 5, 2017

fwyzard commented Jul 5, 2017 via email

UBParker commented Jul 5, 2017

UBParker commented Jul 5, 2017

physicist87 commented Jul 5, 2017

rappoccio commented Jul 6, 2017 • edited Loading

mtosi commented Jul 6, 2017 via email

rappoccio commented Jul 9, 2017

rappoccio commented Jul 9, 2017

sudhaahuja Jul 6, 2017 •

edited

Loading

sudhaahuja Jun 26, 2017 •

edited

Loading

cmsbuild commented Jul 4, 2017 •

edited

Loading

rappoccio commented Jul 6, 2017 •

edited

Loading