Monitoring VBF jets for VBF + 2 Taus HLT paths #19794

albertdow · 2017-07-18T13:31:17Z

This PR is for adding an initial monitoring strategy for the VBF jets of three new paths:

HLT_VBF_DoubleLooseChargedIsoPFTau20_Trk1_eta2p1_Reg_v*
HLT_VBF_DoubleMediumChargedIsoPFTau20_Trk1_eta2p1_Reg_v*
HLT_VBF_DoubleTightChargedIsoPFTau20_Trk1_eta2p1_Reg_v*

It is based on the framework developed for HLT VBF+MET paths in PR #19294 (backport #19561).

…thin VBF Monitor cffs

cmsbuild · 2017-07-18T13:31:40Z

A new Pull Request was created by @albertdow for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

dmitrijus · 2017-07-18T13:33:47Z

+1

cmsbuild · 2017-07-18T13:34:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21575/console Started: 2017/07/18 15:34

cmsbuild · 2017-07-18T13:34:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-07-18T14:59:40Z

-1

Tested at: 9f18bc4

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2862e4e
9accd33
026420d
cdbe01a
34621bc
e5004c7
d8bda16
f56dad1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21575/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21575/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21575/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

Material budget:

There was error running material budget tests.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2862e4e
9accd33
026420d
cdbe01a
34621bc
e5004c7
d8bda16
f56dad1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21575/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21575/git-merge-result

cmsbuild · 2017-07-18T14:59:43Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-07-20T10:54:33Z

+1
Tested at: ebefb0e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21632/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e332c1d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21632/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21632/git-merge-result

cmsbuild · 2017-07-20T10:54:36Z

Comparison job queued.

cmsbuild · 2017-07-20T13:02:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19794/21632/summary.html

Comparison Summary:

You potentially added 20 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2310405
DQMHistoTests: Total failures: 15054
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2295185
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

dmitrijus · 2017-07-21T11:57:30Z

+1

cmsbuild · 2017-07-21T11:57:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-21T15:31:52Z

+1

fwyzard · 2017-07-25T08:56:18Z

tracked by #19142

davidlange6 · 2017-07-27T07:13:55Z

hi @albertdow @fwyzard it looks like this PR has introduced some problems - could you provide a fix today/tomorrow?

(runTheMatrix.py -l 10026 -i all)

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_aarch64_gcc700/CMSSW_9_3_X_2017-07-26-2300/pyRelValMatrixLogs/run/10026.0_QCD_Pt_600_800_13+QCD_Pt_600_800_13TeV_TuneCUETP8M1_2017_GenSimFullINPUT+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_QCD_Pt_600_800_13+QCD_Pt_600_800_13TeV_TuneCUETP8M1_2017_GenSimFullINPUT+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

fwyzard · 2017-07-27T10:04:08Z

Hi David,
the error is caused by both "jet1etaVsLS_numerator" and "jet1etaVsLS_denominator" having negative values, while the DQMGenericClient is not protected against it.

I can add the protection if this is what you or @dmitrijus prefer, but I guess the numerator and denominator plots should actually be fixed anyway. @albertdow can you check them ASAP ?

.A

fwyzard · 2017-07-27T10:51:18Z

The "technical" fix is #19933 .

davidlange6 · 2017-07-27T11:07:15Z

yea - unless i'm mistaken this makes no sense to use to compute efficiencies bookME(ibooker,jet1etaVsLS_,histname,histtitle,ls_binning_.nbins, ls_binning_.xmin, ls_binning_.xmax,jeteta_binning_.xmin, jeteta_binning_.xmax); means two TProfiles , not two TH2Fs.. (one numerator, one denominator)

…

On Jul 27, 2017, at 12:04 PM, Andrea Bocci ***@***.***> wrote: Hi David, the error is caused by both "jet1etaVsLS_numerator" and "jet1etaVsLS_denominator" having negative values, while the DQMGenericClient is not protected against it. I can add the protection if this is what you or @dmitrijus prefer, but I guess the numerator and denominator plots should actually be fixed anyway. @albertdow can you check them ASAP ? .A — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

davidlange6 · 2017-07-27T11:14:41Z

now that I think about it - this construct is used in many places in the HLT pRs.... I maybe the ratio of the mean of eta before/after selection vs LS is indeed whats intended, but thats not something I understand the meaning of. (its done for met, pt, etc etc in TopMonitor for example)

…

On Jul 27, 2017, at 1:06 PM, David Lange ***@***.***> wrote: yea - unless i'm mistaken this makes no sense to use to compute efficiencies bookME(ibooker,jet1etaVsLS_,histname,histtitle,ls_binning_.nbins, ls_binning_.xmin, ls_binning_.xmax,jeteta_binning_.xmin, jeteta_binning_.xmax); means two TProfiles , not two TH2Fs.. (one numerator, one denominator) > On Jul 27, 2017, at 12:04 PM, Andrea Bocci ***@***.***> wrote: > > Hi David, > the error is caused by both "jet1etaVsLS_numerator" and "jet1etaVsLS_denominator" having negative values, while the DQMGenericClient is not protected against it. > > I can add the protection if this is what you or @dmitrijus prefer, but I guess the numerator and denominator plots should actually be fixed anyway. @albertdow can you check them ASAP ? > > .A > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. >

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

mtosi · 2017-07-31T15:34:26Z

using the etaVsLS does not make too much sense, indeed ....

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

albertdow added 5 commits July 18, 2017 11:37

adding VBFTauMonitor and updated offline objects for VBFMETMonitor

6507a9f

changed offline objects directly within ObjMonitor_cfi rather than wi…

b049c57

…thin VBF Monitor cffs

removing MET histos from Client

9c155d1

resolve merge conflict 930pre2

2862e4e

adding DoubleMediumChargedIsoPFTau35 path in denominator

9f18bc4

cmsbuild added this to the CMSSW_9_3_X milestone Jul 18, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 18, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 18, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 18, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 18, 2017

added missing import VBFTauMonitor line in HiggsMonitor_cff

ebefb0e

cmsbuild removed comparison-notrun dqm-approved labels Jul 18, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 20, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 20, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 21, 2017

cmsbuild added orp-approved and removed orp-pending labels Jul 21, 2017

cmsbuild merged commit 4bc26f1 into cms-sw:master Jul 21, 2017

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

amagnan mentioned this pull request Jul 31, 2017

Backporting DQM for VBF+MET triggers to 92X #19561

Closed

fwyzard mentioned this pull request Jul 31, 2017

Enable HLT DQM for MET plus Track EXO triggers #19946

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Monitoring VBF jets for VBF + 2 Taus HLT paths #19794

Monitoring VBF jets for VBF + 2 Taus HLT paths #19794

albertdow commented Jul 18, 2017 •

edited

Loading

cmsbuild commented Jul 18, 2017

dmitrijus commented Jul 18, 2017

cmsbuild commented Jul 18, 2017 •

edited

Loading

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 20, 2017

cmsbuild commented Jul 20, 2017

cmsbuild commented Jul 20, 2017

dmitrijus commented Jul 21, 2017

cmsbuild commented Jul 21, 2017

davidlange6 commented Jul 21, 2017

fwyzard commented Jul 25, 2017

davidlange6 commented Jul 27, 2017

fwyzard commented Jul 27, 2017

fwyzard commented Jul 27, 2017

davidlange6 commented Jul 27, 2017 via email

davidlange6 commented Jul 27, 2017 via email

mtosi commented Jul 31, 2017

Monitoring VBF jets for VBF + 2 Taus HLT paths #19794

Monitoring VBF jets for VBF + 2 Taus HLT paths #19794

Conversation

albertdow commented Jul 18, 2017 • edited Loading

cmsbuild commented Jul 18, 2017

dmitrijus commented Jul 18, 2017

cmsbuild commented Jul 18, 2017 • edited Loading

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 18, 2017

cmsbuild commented Jul 20, 2017

cmsbuild commented Jul 20, 2017

cmsbuild commented Jul 20, 2017

dmitrijus commented Jul 21, 2017

cmsbuild commented Jul 21, 2017

davidlange6 commented Jul 21, 2017

fwyzard commented Jul 25, 2017

davidlange6 commented Jul 27, 2017

fwyzard commented Jul 27, 2017

fwyzard commented Jul 27, 2017

davidlange6 commented Jul 27, 2017 via email

davidlange6 commented Jul 27, 2017 via email

mtosi commented Jul 31, 2017

albertdow commented Jul 18, 2017 •

edited

Loading

cmsbuild commented Jul 18, 2017 •

edited

Loading