-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DQM for VBF Higgs invisible HLT path #19294
Add DQM for VBF Higgs invisible HLT path #19294
Conversation
A new Pull Request was created by @amagnan for master. It involves the following packages: DQMOffline/Trigger @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
tracked by #19142 |
JetDQM jetDQM_; | ||
|
||
|
||
GenericTriggerEventFlag* num_genTriggerEventFlag_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, make unique_ptr
EXO_VBF_METmonitoring = hltobjmonitoring.clone() | ||
EXO_VBF_METmonitoring.FolderName = cms.string('HLT/Higgs/VBFMET/EXOVBF/') | ||
EXO_VBF_METmonitoring.numGenericTriggerEventPSet.hltInputTag = cms.InputTag( "TriggerResults","","reHLT" ) | ||
EXO_VBF_METmonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_EXO_VBF") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need to update this string as soon as we have it in confDB ;)
hltobjmonitoring = objMonitoring.clone() | ||
hltobjmonitoring.FolderName = cms.string('HLT/GENERIC/') | ||
hltobjmonitoring.doMETHistos = cms.bool(True) | ||
hltobjmonitoring.histoPSet.metPSet = cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, make use of variable binning ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I did but only for the histograms that make sense, for which turn-on vs variable makes sense. I think for the others it is useful to have the distributions with and without the filter but not mandatory to have fine binning because no expected turn-on.....
xmax = cms.double(3.1416), | ||
) | ||
hltobjmonitoring.doJetHistos = cms.bool(True) | ||
hltobjmonitoring.histoPSet.jet1ptPSet = cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, make use of variable binning
xmin = cms.double( 0), | ||
xmax = cms.double(6000), | ||
) | ||
hltobjmonitoring.histoPSet.detajjPSet = cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, decrease the # bins
xmin = cms.double( -5), | ||
xmax = cms.double(5), | ||
) | ||
hltobjmonitoring.histoPSet.mjjPSet = cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even here you might prefer a variable binning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so here I have both variable and fixed for Mjj
do you have the 2D plot (eta-phi) ? |
is it possible that I do not see the client ? |
1 similar comment
is it possible that I do not see the client ? |
ahah, I was wondering if I had to do the turn-on by hand, so there should be more ;) Will ask you Monday! Thanks! |
DQMGenericClient |
the point is that we should try to squeeze as much as possible the # bins |
Pull request #19294 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
Oups, pushed too quickly, some issues with unique_ptr, will fix now, sorry..... |
Pull request #19294 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
OK I hope it is correct now for the unique_ptr. I have added the Client, removed duplicated histograms to keep only the ones with variable binning, and made variable binning for all pT/mass variables to avoid low-stat tails. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Pull request #19294 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
@cmsbuild, please test
…On Tue, Jul 4, 2017 at 1:42 PM, cmsbuild ***@***.***> wrote:
Pull request #19294 <#19294> was
updated. @vazzolini <https://github.com/vazzolini>, @kmaeshima
<https://github.com/kmaeshima>, @dmitrijus <https://github.com/dmitrijus>,
@cmsbuild <https://github.com/cmsbuild>, @vanbesien
<https://github.com/vanbesien>, @davidlange6
<https://github.com/davidlange6> can you please check and sign again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19294 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt585cSd5srsfqV3rXbbeMVcKx9UAygks5sKiUZgaJpZM4N8kAK>
.
|
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
great ! |
So, if I follow correctly, this fix suggested by @davidlange6 was
forgotten before, but it is no problem to just put them in PR 19585,
which is also for 93X is that correct ? Then it will anyway superseed my
previous PR which is already merged.
For the backports, my PR 19561 has not been merged yet, and you also
have a duplicated one corresponding to 19585, is that correct ?
If this is correct, I close 19561, you correct the code with the
initialisation in 19585 and in the 92X backport PR and we are good to
go.....
Right ????
…On 07/12/2017 04:02 PM, Minsuk Kim wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In DQMOffline/Trigger/plugins/GENERICDQM.h
<#19294 (comment)>:
> +#define DQMOffline_Trigger_GENERICDQM_H
+
+#include "DQMServices/Core/interface/MonitorElement.h"
+#include "DQMServices/Core/interface/DQMStore.h"
+#include "FWCore/ParameterSet/interface/ParameterSetDescription.h"
+
+struct MEbinning {
+ int nbins;
+ double xmin;
+ double xmax;
+};
+
+struct OBJME {
+ MonitorElement* numerator;
+ MonitorElement* denominator;
+ inline void clear(){
Hi, I now wonder how it will affect various developments using this
base class in 93x and backport to 92x. For example, #19561
<#19561> and #19585
<#19585> have DQM codes with the
initializations. Are they okay with the current base class that uses
the clear method?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19294 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEeCzLSBEwmeuZt8KiydcQhYVRYXfiBCks5sNNHPgaJpZM4N8kAK>.
--
####################################################
Dr. Anne-Marie Magnan
CMS
---------------------- ---------------------------
42-3-037, CERN Imperial College, HEP Dept.
CH-1210 Geneva The Blackett Laboratory
Prince Consort Road
London SW7 2AZ
(+41)(0)22 76 6 25 46
http://www.cern.ch http://www.imperial.ac.uk
####################################################
â à è é ê ë æ î ï ô ö ù û ü ç
####################################################
|
Yes, PR 19585 is also for 93X. For the backports, I have to close my backport because it has the duplicated one corresponding to 19585 and your TriggerDQMBase/METDQM/JetDQM codes. This means that it is not a backport. I am sorry for my misunderstanding on backporting. Because I am using your codes above, your backport should be merged first unless two backports will be combined at the moment. So, I don't think that you close 19561. @davidlange6 please let us know if you have any comments or suggestions. |
@amagnan please check the following link in the case that you agree to combine the two backports: |
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
No description provided.