-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUSY VBF trigger monitoring 93X #19565
Conversation
A new Pull Request was created by @tankit (Minsuk Kim) for master. It involves the following packages: DQMOffline/Trigger @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Mia, "@cmsbuild, please test" has to be the first line of the message, it doesn't work if you put it in the body. |
@tankit, could you add here the list of triggers being monitored ? |
The list of triggers being monitored: |
:(
thanks
… On 5 Jul 2017, at 15:44, Andrea Bocci ***@***.***> wrote:
Mia, ***@***.***, please test" has to be the first line of the message, it doesn't work if you put it in the body.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
-1 Tested at: a9e6bff The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Unit Tests failure probably related to fixing int32->uint32 in https://github.com/cms-sw/cmssw/commits/master/DQMOffline/Trigger/python/ObjMonitor_cfi.py |
I'm a little but puzzled by this
is it possible that we need to update the PR w/ the most recent fix done by
@amagnan ?
…On Thu, Jul 6, 2017 at 12:29 PM, Minsuk Kim ***@***.***> wrote:
Unit Tests failure probably related to fixing int32->uint32 in
https://github.com/cms-sw/cmssw/commits/master/DQMOffline/Trigger/python/
ObjMonitor_cfi.py
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19565 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt589d1YiHVYOq2foZC8Ne4VWtmredJks5sLLcGgaJpZM4OONvg>
.
|
yes it looks like it :( Sorry should have checked with Minsuk when she
did the merge topic.
…On 07/06/2017 12:35 PM, mia tosi wrote:
I'm a little but puzzled by this
is it possible that we need to update the PR w/ the most recent fix
done by
@amagnan ?
On Thu, Jul 6, 2017 at 12:29 PM, Minsuk Kim ***@***.***>
wrote:
> Unit Tests failure probably related to fixing int32->uint32 in
>
https://github.com/cms-sw/cmssw/commits/master/DQMOffline/Trigger/python/
> ObjMonitor_cfi.py
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#19565 (comment)>,
or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AEt589d1YiHVYOq2foZC8Ne4VWtmredJks5sLLcGgaJpZM4OONvg>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19565 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEeCzG2ntHqBrdAlOxVEwJLJQ_SBrEsXks5sLLiGgaJpZM4OONvg>.
--
####################################################
Dr. Anne-Marie Magnan
CMS
---------------------- ---------------------------
42-3-037, CERN Imperial College, HEP Dept.
CH-1210 Geneva The Blackett Laboratory
Prince Consort Road
London SW7 2AZ
(+41)(0)22 76 6 25 46
http://www.cern.ch http://www.imperial.ac.uk
####################################################
â à è é ê ë æ î ï ô ö ù û ü ç
####################################################
|
hmm, is this PR still needed ? |
As Mia asked, I close this because of #19585, which has tests approved and comparison available. |
Update of #19565: SUSY VBF trigger monitoring 93X
use #19294 which was merged this morning and add histos for VBF SUSY path