Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSY VBF trigger monitoring 93X #19565

Closed
wants to merge 2 commits into from

Conversation

tankit
Copy link
Contributor

@tankit tankit commented Jul 5, 2017

use #19294 which was merged this morning and add histos for VBF SUSY path

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

A new Pull Request was created by @tankit (Minsuk Kim) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@tankit tankit changed the title Cmssw 9 2 x 2017 07 05 1320 Add DQM for VBF SUSY HLT path Jul 5, 2017
@mtosi
Copy link
Contributor

mtosi commented Jul 5, 2017

@tankit , please update the name of this PR (w/ some more clear title ;) )
then, we will need a backport to 92x

@cmsbuild, please test

tracked by #19142

@mtosi mtosi mentioned this pull request Jul 5, 2017
@tankit tankit changed the title Add DQM for VBF SUSY HLT path SUSY VBF trigger monitoring 92X Jul 5, 2017
@tankit tankit changed the title SUSY VBF trigger monitoring 92X SUSY VBF trigger monitoring 93X Jul 5, 2017
@fwyzard
Copy link
Contributor

fwyzard commented Jul 5, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21177/console Started: 2017/07/05 15:47

@fwyzard
Copy link
Contributor

fwyzard commented Jul 5, 2017

Mia, "@cmsbuild, please test" has to be the first line of the message, it doesn't work if you put it in the body.

@fwyzard
Copy link
Contributor

fwyzard commented Jul 5, 2017

@tankit, could you add here the list of triggers being monitored ?

@tankit
Copy link
Contributor Author

tankit commented Jul 5, 2017

The list of triggers being monitored:
HLT_Mu8_TrkIsoVVL_DiPFJet40_DEta3p5_MJJ750_HTT300_PFMETNoMu60_v*
HLT_Mu10_TrkIsoVVL_DiPFJet40_DEta3p5_MJJ750_HTT350_PFMETNoMu60_v* (backup path)

@mtosi
Copy link
Contributor

mtosi commented Jul 5, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

-1

Tested at: a9e6bff

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f194090
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19565/21177/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19565/21177/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19565/21177/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f194090
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19565/21177/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19565/21177/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19565/21177/summary.html

Comparison Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1786918
  • DQMHistoTests: Total failures: 29421
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1757331
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@tankit
Copy link
Contributor Author

tankit commented Jul 6, 2017

Unit Tests failure probably related to fixing int32->uint32 in https://github.com/cms-sw/cmssw/commits/master/DQMOffline/Trigger/python/ObjMonitor_cfi.py

@mtosi
Copy link
Contributor

mtosi commented Jul 6, 2017 via email

@amagnan
Copy link
Contributor

amagnan commented Jul 6, 2017 via email

@mtosi
Copy link
Contributor

mtosi commented Jul 6, 2017

hmm, is this PR still needed ?
I see #19585, now
if this one is no longer needed, please close this
(and next time, please try to update the PR instead of creating a new one, thanks)

@tankit
Copy link
Contributor Author

tankit commented Jul 9, 2017

As Mia asked, I close this because of #19585, which has tests approved and comparison available.

@tankit tankit closed this Jul 9, 2017
cmsbuild added a commit that referenced this pull request Jul 13, 2017
Update of #19565: SUSY VBF trigger monitoring 93X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants