-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating the E/gamma HLT TnP DQM to have muon tags #20167
Conversation
A new Pull Request was created by @Sam-Harper for master. It involves the following packages: DQMOffline/Trigger @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20167/110 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
thanks ! ah, do you have the backport for 92x ? |
Hi @mtosi I'll do the backport once its generally accepted that this is done. As for binning, well I could dump all HEM17 and HEP17 plots for this package. That would save 2/3rds of the histograms. They so far have not been that useful. The 2D plots are reasonably sensibility binned |
in the root file I even find plots for |
tracked by #19142 |
so I have a plan to re-visit how I do HEP17 and HEM17. Should cut the number of bins by ~1/3. Will submit soon |
thanks !
mia
…On Tue, Aug 15, 2017 at 10:58 AM, Sam-Harper ***@***.***> wrote:
so I have a plan to re-visit how I do HEP17 and HEM17. Should cut the
number of bins by ~1/3. Will submit soon
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20167 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt589Rj5EMq-FQRw162MO7TmtMFnWilks5sYV3GgaJpZM4O3AB8>
.
|
Pull request #20167 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+code-checks |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@kmaeshima @vanbesien, @vazzolini, @dmitrijus just a ping on the status of approval of this. This PR adds more useful DQM plots for EGM while reducing the total bin count by ~50% so is a clear improvement. |
@kmaeshima @vanbesien, @vazzolini, @dmitrijus another ping on the status of approval of this. This PR adds more useful DQM plots for EGM while reducing the total bin count by ~50% so is a clear improvement |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Dear All,
This update of the E/gamma HLT TnP DQM package now allows triggers to be monitored by muon tags, adding further cross trigger monitoring. It is also enabled for a few select electron triggers to be able to monitor e/gamma problems that may impact the tag & probe in a correlated way (online beamspot issues immediately jump to mind there)
As well as adding DQM plots where the tag is a muon, this update also fixes the newly introduced for V3 HLT_Ele32_WPTight_Gsf filters which were slightly miss named.
The new filters have been tested on ttbar lepton relval sample and the results are below, showing the filters run and are filled. The full listing is at
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/
HLT_Ele32_WPTight_Gsf:
ele tag:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/eleWPTightTag_HLT_Ele32_WPTight_Gsf_hltEle32WPTightGsfTrackIsoFilter.gif
muon tag:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Ele32_WPTight_Gsf_hltEle32WPTightGsfTrackIsoFilter.gif
HLT_Ele32_WPTight_Gsf_L1DoubleEG:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Ele32_WPTight_Gsf_L1DoubleEG_hltEle32L1DoubleEGWPTightGsfTrackIsoFilter.gif
HLT_DoubleEle33_CaloIdL_MW:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_DoubleEle33_CaloIdL_MW_hltEle33CaloIdLMWPMS2Filter.gif
HLT_Mu12_DoublePhoton20:
with photon probe:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagPhoProbe_HLT_Mu12_DoublePhoton20_hltMu12DiEG20HEUnseededFilter.gif
with electron probe
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Mu12_DoublePhoton20_hltMu12DiEG20HEUnseededFilter.gif
HLT_Mu27_Ele37_CaloIdL_MW:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Mu27_Ele37_CaloIdL_MW_hltEle37CaloIdLMWPMS2UnseededFilter.gif
HLT_Mu37_Ele27_CaloIdL_MW:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Mu37_Ele27_CaloIdL_MW_hltEle27CaloIdLMWPMS2UnseededFilter.gif