Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T4 pb 12150 #1039

Closed
wants to merge 64 commits into from
Closed

T4 pb 12150 #1039

wants to merge 64 commits into from

Conversation

nobuotakamasa
Copy link
Contributor

Description

adding ECU CMOS Battery condition monitoring node.
if codition variable CMAKE_ECU_PLATFORM is "adlink", this node is enable.
Otherwise it will be disabled.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

  • The PR reviewers must check the checkboxes below before approval.
  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
    The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.
    After all checkboxes are checked, anyone who has write access can merge the PR.

kenji-miyake and others added 30 commits January 24, 2022 18:00
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* ci(pre-commit): autofix

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
fix(obstacle_stop_planner): use utils function to caluculate nearest index from ego (#651)
* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Revert "chore: sync files"

This reverts commit b24f530.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* sync codecov.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
…age (#666)

* fix(autoware_state_panel): fix message type for /api/autoware/get/engage

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
* fix(system_monitor): fix build error on tegra platform

Signed-off-by: Shark Liu <shark.liu@autocore.ai>

* ci(pre-commit): autofix

* Update system/system_monitor/src/gpu_monitor/tegra_gpu_monitor.cpp

Co-authored-by: Shark Liu <shark.liu@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
HiroIshida and others added 17 commits May 18, 2022 09:48
#882)

* fix: single -> multiple layers pointcloud

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* refactor: share common among different pcloud creators

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>
* feat(vehicle_info_util): add max_steer_angle

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* applied pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Added max_steer_angle in test config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
* fix(lidar_centerpoint): fix google drive url to avoid 404

* Update CMakeLists.txt

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…894)

* feat(state_rviz_plugin): add GateMode and PathChangeApproval Button

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
#890)

* add random point sampling function to quickly calculate the 'viewer' coordinate

Signed-off-by: IshitaTakeshi <ishitah.takeshi@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
* fixed panel type

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* modified instruction for rosbag replay case

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* modified update_map_dir service name

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…it is empty (#898)

* skipping emplace back stop reason if it is empty

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>

* add braces

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
#838)

* feat(behavior_path_planner): Weakened noise filtering of drivable area

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix lanelet's longitudinal disconnection

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comments of erode/dilate process

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@nobuotakamasa nobuotakamasa marked this pull request as ready for review June 5, 2022 10:44
@@ -0,0 +1,28 @@
name: sync-upstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm your diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted unnecessary fixes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm, there is no change. 🥺

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove sync-upstream.yaml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please confirm the pull request guidelines.

@kenji-miyake kenji-miyake marked this pull request as draft June 5, 2022 15:10
@stale
Copy link

stale bot commented Aug 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 30, 2022
@kenji-miyake
Copy link
Contributor

@nobuotakamasa @ito-san Could you update the status of this PR? If it's not necessary anymore, please close it.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Sep 7, 2022
@ito-san
Copy link
Contributor

ito-san commented Sep 7, 2022

@nobuotakamasa @ito-san Could you update the status of this PR? If it's not necessary anymore, please close it.

There is a similar PR(#1447) and I believe all of these PRs should be closed.

@nobuotakamasa
May I close these PRs or would you please close it?

@nobuotakamasa nobuotakamasa deleted the T4PB-12150 branch September 9, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.