Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (backport #5089) #884

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Sep 27, 2023

Description

2023-09-27時点のHumble Syncにおいて、ビルドが通らなくなっている
autowarefoundation#5089 を参考に修正が必要な場所をpickした

Related links

https://star4.slack.com/archives/C04CKSQ7ZFZ/p1695796136636259

Tests performed

以下のビルドエラーが解消されていることを確認した

Starting >>> autoware_auto_tf2
Finished <<< autoware_auto_vehicle_msgs [13.4s]                                                                        
--- stderr: autoware_auto_tf2                                
In file included from /home/hrkota/pilot-auto.x1.eve/src/autoware/universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:22:
/home/hrkota/pilot-auto.x1.eve/src/autoware/universe/common/autoware_auto_tf2/include/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp:55:6: error: redefinition of ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Point32_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’
   55 | void doTransform(
      |      ^~~~~~~~~~~
In file included from /home/hrkota/pilot-auto.x1.eve/src/autoware/universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:21:
/opt/ros/humble/include/tf2_geometry_msgs/tf2_geometry_msgs/tf2_geometry_msgs.hpp:260:6: note: ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Point32_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’ previously declared here
  260 | void doTransform(
      |      ^~~~~~~~~~~
In file included from /home/hrkota/pilot-auto.x1.eve/src/autoware/universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:22:
/home/hrkota/pilot-auto.x1.eve/src/autoware/universe/common/autoware_auto_tf2/include/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp:78:6: error: redefinition of ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Polygon_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’
   78 | void doTransform(
      |      ^~~~~~~~~~~
In file included from /home/hrkota/pilot-auto.x1.eve/src/autoware/universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:21:
/opt/ros/humble/include/tf2_geometry_msgs/tf2_geometry_msgs/tf2_geometry_msgs.hpp:460:6: note: ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Polygon_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’ previously declared here
  460 | void doTransform(
      |      ^~~~~~~~~~~
gmake[2]: *** [CMakeFiles/test_tf2_autoware_auto_msgs.dir/build.make:76: CMakeFiles/test_tf2_autoware_auto_msgs.dir/test/test_tf2_autoware_auto_msgs.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:156: CMakeFiles/test_tf2_autoware_auto_msgs.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< autoware_auto_tf2 [10.7s, exited with code 2]

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from KeisukeShima September 27, 2023 07:19
@h-ohta h-ohta changed the title fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (#5089) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (backport #5089) Sep 27, 2023
@h-ohta h-ohta merged commit 1b231f3 into beta/v0.3.17 Sep 27, 2023
@h-ohta h-ohta deleted the backport/5089 branch September 27, 2023 07:36
YoheiMishina pushed a commit that referenced this pull request Oct 2, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
@h-ohta
Copy link
Author

h-ohta commented Oct 12, 2023

@Mergifyio backport beta/v0.3.16

@mergify
Copy link

mergify bot commented Oct 12, 2023

backport beta/v0.3.16

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 12, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
(cherry picked from commit 1b231f3)
h-ohta added a commit that referenced this pull request Oct 12, 2023
…2 geometry msgs (backport autowarefoundation#5089) (backport #884) (#933)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (backport autowarefoundation#5089) (#884)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
(cherry picked from commit 1b231f3)

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants