Drop Akka 2.5 dependency #1209
Merged
Drop Akka 2.5 dependency #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
force-pushed
the
seglo/drop-akka-2.5
branch
from
40614e1 to
ccf1dda
Compare
seglo
force-pushed
the
seglo/drop-akka-2.5
branch
from
ccf1dda to
ac2f03e
Compare
seglo
commented
Oct 6, 2020
ignasi35
reviewed
Oct 7, 2020
seglo
force-pushed
the
seglo/drop-akka-2.5
branch
from
ac2f03e to
e17c7da
Compare
seglo
commented
Oct 13, 2020
ennru
approved these changes
Oct 14, 2020
| @@ -25,16 +26,17 @@ public void discoverySetup() throws Exception { | |||
| ConfigFactory.parseString(ConsumerSettingsSpec$.MODULE$.DiscoveryConfigSection()) | |||
| .withFallback(ConfigFactory.load()) | |||
| .resolve(); | |||
| ActorSystem system = ActorSystem.create("ConsumerSettingsTest", config); | |||
| ClassicActorSystemProvider system = ActorSystem.create("ConsumerSettingsTest", config); | |||
There was a problem hiding this comment.
I believe we should remove the deprecation on the DiscoverySupport instead. Users normally can't avoid that that method is chosen with a classic actor system.
There was a problem hiding this comment.
IIUC I'm suppressing the deprecation warning instead.
tests/src/test/scala/akka/kafka/scaladsl/TransactionsSpec.scala
Outdated
Show resolved
Hide resolved
fix travis step review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113