Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: actually compile cluster sharding #1227

Merged
merged 2 commits into from
Oct 12, 2020
Merged

CI: actually compile cluster sharding #1227

merged 2 commits into from
Oct 12, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 10, 2020

As it turns out, the build step to compile cluster sharding didn't run anything in sbt as the environment variable wasn't correctly set.

raboof
raboof approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

@raboof raboof merged commit 5df5b0e into akka:master Oct 12, 2020
@ennru ennru deleted the cluster-sharding-cmd branch October 12, 2020 08:53
@ennru ennru added this to the 2.1.0 milestone Oct 12, 2020
@seglo
Copy link
Contributor

seglo commented Oct 13, 2020

D'oh. This will be removed altogether with #1209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@ennru @seglo @raboof