-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.12.11 and 2.13.2 #1212
Scala 2.12.11 and 2.13.2 #1212
Conversation
@@ -91,7 +91,7 @@ val commonSettings = Def.settings( | |||
licenses := Seq("Apache-2.0" -> url("http://opensource.org/licenses/Apache-2.0")), | |||
description := "Alpakka is a Reactive Enterprise Integration library for Java and Scala, based on Reactive Streams and Akka.", | |||
crossScalaVersions := Seq(Scala212, Scala213), | |||
scalaVersion := Scala212, | |||
scalaVersion := Scala213, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sneaky!
Oh wow, Kafka hits Scala binary compatibility issues as it looks to me
https://travis-ci.org/github/akka/alpakka-kafka/jobs/733600592#L654 |
The error occurs in EmbeddedKafka on Scala 2.12.12 (Scala 2.13.3 works) |
The Kafka broker itself is compiled against Scala 2.12.11 (https://mvnrepository.com/artifact/org.apache.kafka/kafka_2.12/2.6.0). |
Seems there is a broken assumption here
if (project.name.equals('core'))
inlineFrom = ["-opt-inline-from:scala.**", "-opt-inline-from:kafka.**", "-opt-inline-from:org.apache.kafka.**"] https://github.com/apache/kafka/blob/2.6.0/build.gradle#L485-L492 |
Rolled back this PR to Scala 2.12.11 and 2.13.2 so we can continue dropping Embedded Kafka in #1209 |
This makes Scala 2.13.2 the default version for all modules.